From: kernel test robot <lkp@intel.com> To: ryan_chen <ryan_chen@aspeedtech.com>, BMC-SW@aspeedtech.com, Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Ryan Chen <ryan_chen@aspeedtech.com> Subject: Re: [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode driver Date: Wed, 23 Mar 2022 12:07:53 +0800 [thread overview] Message-ID: <202203231247.KCb0uKWD-lkp@intel.com> (raw) In-Reply-To: <20220323004009.943298-3-ryan_chen@aspeedtech.com> Hi ryan_chen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on robh/for-next pza/reset/next v5.17 next-20220322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/ryan_chen/Add-ASPEED-AST2600-I2C-new-controller-driver/20220323-084205 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220323/202203231247.KCb0uKWD-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4fa1d6c517dfca057852514880a8e52e5da51572 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review ryan_chen/Add-ASPEED-AST2600-I2C-new-controller-driver/20220323-084205 git checkout 4fa1d6c517dfca057852514880a8e52e5da51572 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/i2c/busses/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/i2c/busses/i2c-new-aspeed.c: In function 'aspeed_new_i2c_init': >> drivers/i2c/busses/i2c-new-aspeed.c:1407:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1407 | u8 i2c_count = (((u32)(i2c_bus->reg_base) & 0xFFF)/0x80); | ^ vim +1407 drivers/i2c/busses/i2c-new-aspeed.c 1402 1403 static void aspeed_new_i2c_init(struct aspeed_new_i2c_bus *i2c_bus) 1404 { 1405 struct platform_device *pdev = to_platform_device(i2c_bus->dev); 1406 u32 fun_ctrl = AST_I2CC_BUS_AUTO_RELEASE | AST_I2CC_MASTER_EN; > 1407 u8 i2c_count = (((u32)(i2c_bus->reg_base) & 0xFFF)/0x80); 1408 1409 /* I2C Reset */ 1410 writel(0, i2c_bus->reg_base + AST_I2CC_FUN_CTRL); 1411 1412 if (of_property_read_bool(pdev->dev.of_node, "multi-master")) 1413 i2c_bus->multi_master = true; 1414 else 1415 fun_ctrl |= AST_I2CC_MULTI_MASTER_DIS; 1416 1417 /* AST2600 i2c10 need to overcome sda glich with is flag. */ 1418 if (i2c_count == 0xA) 1419 fun_ctrl |= AST_I2CC_SDA_DRIVE_1T_EN; 1420 1421 /* Enable Master Mode */ 1422 writel(fun_ctrl, i2c_bus->reg_base + AST_I2CC_FUN_CTRL); 1423 /* disable slave address */ 1424 writel(0, i2c_bus->reg_base + AST_I2CS_ADDR_CTRL); 1425 1426 /* Set AC Timing */ 1427 writel(aspeed_select_i2c_clock(i2c_bus), i2c_bus->reg_base + AST_I2CC_AC_TIMING); 1428 1429 /* Clear Interrupt */ 1430 writel(0xfffffff, i2c_bus->reg_base + AST_I2CM_ISR); 1431 -- 0-DAY CI Kernel Test Service https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: ryan_chen <ryan_chen@aspeedtech.com>, BMC-SW@aspeedtech.com, Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Ryan Chen <ryan_chen@aspeedtech.com> Subject: Re: [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode driver Date: Wed, 23 Mar 2022 12:07:53 +0800 [thread overview] Message-ID: <202203231247.KCb0uKWD-lkp@intel.com> (raw) In-Reply-To: <20220323004009.943298-3-ryan_chen@aspeedtech.com> Hi ryan_chen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on robh/for-next pza/reset/next v5.17 next-20220322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/ryan_chen/Add-ASPEED-AST2600-I2C-new-controller-driver/20220323-084205 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220323/202203231247.KCb0uKWD-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4fa1d6c517dfca057852514880a8e52e5da51572 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review ryan_chen/Add-ASPEED-AST2600-I2C-new-controller-driver/20220323-084205 git checkout 4fa1d6c517dfca057852514880a8e52e5da51572 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/i2c/busses/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/i2c/busses/i2c-new-aspeed.c: In function 'aspeed_new_i2c_init': >> drivers/i2c/busses/i2c-new-aspeed.c:1407:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1407 | u8 i2c_count = (((u32)(i2c_bus->reg_base) & 0xFFF)/0x80); | ^ vim +1407 drivers/i2c/busses/i2c-new-aspeed.c 1402 1403 static void aspeed_new_i2c_init(struct aspeed_new_i2c_bus *i2c_bus) 1404 { 1405 struct platform_device *pdev = to_platform_device(i2c_bus->dev); 1406 u32 fun_ctrl = AST_I2CC_BUS_AUTO_RELEASE | AST_I2CC_MASTER_EN; > 1407 u8 i2c_count = (((u32)(i2c_bus->reg_base) & 0xFFF)/0x80); 1408 1409 /* I2C Reset */ 1410 writel(0, i2c_bus->reg_base + AST_I2CC_FUN_CTRL); 1411 1412 if (of_property_read_bool(pdev->dev.of_node, "multi-master")) 1413 i2c_bus->multi_master = true; 1414 else 1415 fun_ctrl |= AST_I2CC_MULTI_MASTER_DIS; 1416 1417 /* AST2600 i2c10 need to overcome sda glich with is flag. */ 1418 if (i2c_count == 0xA) 1419 fun_ctrl |= AST_I2CC_SDA_DRIVE_1T_EN; 1420 1421 /* Enable Master Mode */ 1422 writel(fun_ctrl, i2c_bus->reg_base + AST_I2CC_FUN_CTRL); 1423 /* disable slave address */ 1424 writel(0, i2c_bus->reg_base + AST_I2CS_ADDR_CTRL); 1425 1426 /* Set AC Timing */ 1427 writel(aspeed_select_i2c_clock(i2c_bus), i2c_bus->reg_base + AST_I2CC_AC_TIMING); 1428 1429 /* Clear Interrupt */ 1430 writel(0xfffffff, i2c_bus->reg_base + AST_I2CM_ISR); 1431 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-23 4:08 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-23 0:40 [PATCH 0/2] Add ASPEED AST2600 I2C new controller driver ryan_chen 2022-03-23 0:40 ` ryan_chen 2022-03-23 0:40 ` [PATCH 1/2] dt-bindings: i2c-new: Add bindings for AST2600 i2C new controller ryan_chen 2022-03-23 0:40 ` ryan_chen 2022-03-23 0:40 ` [PATCH 2/2] i2c:aspeed:support ast2600 i2c new register mode driver ryan_chen 2022-03-23 0:40 ` ryan_chen 2022-03-23 4:07 ` kernel test robot [this message] 2022-03-23 4:07 ` kernel test robot 2022-03-23 12:37 ` Andrew Lunn 2022-03-23 12:37 ` Andrew Lunn 2022-03-25 5:19 ` Ryan Chen 2022-03-25 5:19 ` Ryan Chen 2022-03-24 8:56 ` kernel test robot 2022-03-24 8:56 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202203231247.KCb0uKWD-lkp@intel.com \ --to=lkp@intel.com \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=joel@jms.id.au \ --cc=kbuild-all@lists.01.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=ryan_chen@aspeedtech.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.