* [PATCH v4 1/1] arm64: dts: qcom: sm8150: Add ufs power-domain entries
@ 2022-03-23 20:30 Bhupesh Sharma
2022-04-08 13:37 ` patchwork-bot+linux-arm-msm
2022-04-12 18:51 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Bhupesh Sharma @ 2022-03-23 20:30 UTC (permalink / raw)
To: linux-arm-msm
Cc: bhupesh.sharma, bhupesh.linux, agross, linux-kernel, devicetree,
robh+dt, bjorn.andersson, Rob Herring
Add power-domain entries for UFS phy node in sm8150 dts.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
Changes since v3:
----------------
- v3 can be found here: https://lore.kernel.org/linux-arm-msm/20220303082140.240745-1-bhupesh.sharma@linaro.org/
- Dropped [PATCH 1/2] from v3, which is already in linux-next now.
- Addressed Dmitry's and Bjorn's review comments.
- This patch is rebase on linux-next.
arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 6012322a5984..eed601e70229 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1637,6 +1637,7 @@ ufs_mem_hc: ufshc@1d84000 {
phy-names = "ufsphy";
lanes-per-direction = <2>;
#reset-cells = <1>;
+
resets = <&gcc GCC_UFS_PHY_BCR>;
reset-names = "rst";
@@ -1687,6 +1688,8 @@ ufs_mem_phy: phy@1d87000 {
clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
<&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
+ power-domains = <&gcc UFS_PHY_GDSC>;
+ power-domain-names = "ufs_phy_gdsc";
resets = <&ufs_mem_hc 0>;
reset-names = "ufsphy";
status = "disabled";
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/1] arm64: dts: qcom: sm8150: Add ufs power-domain entries
2022-03-23 20:30 [PATCH v4 1/1] arm64: dts: qcom: sm8150: Add ufs power-domain entries Bhupesh Sharma
@ 2022-04-08 13:37 ` patchwork-bot+linux-arm-msm
2022-04-12 18:51 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2022-04-08 13:37 UTC (permalink / raw)
To: Bhupesh Sharma; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (for-next)
by Bjorn Andersson <bjorn.andersson@linaro.org>:
On Thu, 24 Mar 2022 02:00:52 +0530 you wrote:
> Add power-domain entries for UFS phy node in sm8150 dts.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> Changes since v3:
>
> [...]
Here is the summary with links:
- [v4,1/1] arm64: dts: qcom: sm8150: Add ufs power-domain entries
https://git.kernel.org/qcom/c/a0fa9be9a735
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/1] arm64: dts: qcom: sm8150: Add ufs power-domain entries
2022-03-23 20:30 [PATCH v4 1/1] arm64: dts: qcom: sm8150: Add ufs power-domain entries Bhupesh Sharma
2022-04-08 13:37 ` patchwork-bot+linux-arm-msm
@ 2022-04-12 18:51 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-04-12 18:51 UTC (permalink / raw)
To: Bhupesh Sharma
Cc: linux-arm-msm, bhupesh.linux, agross, linux-kernel, devicetree,
robh+dt, Rob Herring
On Wed 23 Mar 15:30 CDT 2022, Bhupesh Sharma wrote:
> Add power-domain entries for UFS phy node in sm8150 dts.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> Changes since v3:
> ----------------
> - v3 can be found here: https://lore.kernel.org/linux-arm-msm/20220303082140.240745-1-bhupesh.sharma@linaro.org/
> - Dropped [PATCH 1/2] from v3, which is already in linux-next now.
> - Addressed Dmitry's and Bjorn's review comments.
> - This patch is rebase on linux-next.
>
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 6012322a5984..eed601e70229 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -1637,6 +1637,7 @@ ufs_mem_hc: ufshc@1d84000 {
> phy-names = "ufsphy";
> lanes-per-direction = <2>;
> #reset-cells = <1>;
> +
> resets = <&gcc GCC_UFS_PHY_BCR>;
> reset-names = "rst";
>
> @@ -1687,6 +1688,8 @@ ufs_mem_phy: phy@1d87000 {
> clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
> <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
>
> + power-domains = <&gcc UFS_PHY_GDSC>;
> + power-domain-names = "ufs_phy_gdsc";
As far as I can tell the UFS PHY sits in the MX domain, while the
controller and perhaps the connection between the two sits in
UFS_PHY_GDSC.
So I believe the power-domains should be moved to the &ufs_mem_hc node.
There's no need for power-domain-names in either case.
Regards,
Bjorn
> resets = <&ufs_mem_hc 0>;
> reset-names = "ufsphy";
> status = "disabled";
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-12 18:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 20:30 [PATCH v4 1/1] arm64: dts: qcom: sm8150: Add ufs power-domain entries Bhupesh Sharma
2022-04-08 13:37 ` patchwork-bot+linux-arm-msm
2022-04-12 18:51 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.