* [PATCH] cifs: fix FILE_BOTH_DIRECTORY_INFO definition
@ 2022-03-24 7:26 Yupeng Li
0 siblings, 0 replies; 4+ messages in thread
From: Yupeng Li @ 2022-03-24 7:26 UTC (permalink / raw)
To: sfrench, linux-cifs, samba-technical, linux-kernel
Cc: Eugene Korenevsky, Steve French, Yupeng Li
From: Eugene Korenevsky <ekorenevsky@astralinux.ru>
commit 9bbf8662a27b56358366027d1a77c0676f85b222 upstream.
The size of FILE_BOTH_DIRECTORY_INFO.ShortName must be 24 bytes, not 12
(see MS-FSCC documentation).
Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
---
fs/cifs/cifspdu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h
index 1ce733f3582f..504a20250f73 100644
--- a/fs/cifs/cifspdu.h
+++ b/fs/cifs/cifspdu.h
@@ -2588,7 +2588,7 @@ typedef struct {
__le32 EaSize; /* length of the xattrs */
__u8 ShortNameLength;
__u8 Reserved;
- __u8 ShortName[12];
+ __u8 ShortName[24];
char FileName[1];
} __attribute__((packed)) FILE_BOTH_DIRECTORY_INFO; /* level 0x104 FFrsp data */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cifs: fix FILE_BOTH_DIRECTORY_INFO definition
2022-01-11 8:36 Eugene Korenevsky
@ 2022-01-12 5:59 ` Steve French
0 siblings, 0 replies; 4+ messages in thread
From: Steve French @ 2022-01-12 5:59 UTC (permalink / raw)
To: Eugene Korenevsky; +Cc: CIFS
Merged into cifs-2.6.git for-next
On Tue, Jan 11, 2022 at 6:16 PM Eugene Korenevsky
<ekorenevsky@astralinux.ru> wrote:
>
> The size of FILE_BOTH_DIRECTORY_INFO.ShortName must be 24 bytes, not 12
> (see MS-FSCC documentation).
>
> Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru>
> ---
> fs/cifs/cifspdu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h
> index d2ff438fd31f..68b9a436af4b 100644
> --- a/fs/cifs/cifspdu.h
> +++ b/fs/cifs/cifspdu.h
> @@ -2560,7 +2560,7 @@ typedef struct {
> __le32 EaSize; /* length of the xattrs */
> __u8 ShortNameLength;
> __u8 Reserved;
> - __u8 ShortName[12];
> + __u8 ShortName[24];
> char FileName[1];
> } __attribute__((packed)) FILE_BOTH_DIRECTORY_INFO; /* level 0x104 FFrsp data */
>
> --
> 2.30.2
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cifs: fix FILE_BOTH_DIRECTORY_INFO definition
@ 2022-01-11 14:42 Eugene Korenevsky
0 siblings, 0 replies; 4+ messages in thread
From: Eugene Korenevsky @ 2022-01-11 14:42 UTC (permalink / raw)
To: linux-cifs; +Cc: Steve French
The size of FILE_BOTH_DIRECTORY_INFO.ShortName must be 24 bytes, not 12
(see MS-FSCC documentation).
Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru>
---
fs/cifs/cifspdu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h
index d2ff438fd31f..68b9a436af4b 100644
--- a/fs/cifs/cifspdu.h
+++ b/fs/cifs/cifspdu.h
@@ -2560,7 +2560,7 @@ typedef struct {
__le32 EaSize; /* length of the xattrs */
__u8 ShortNameLength;
__u8 Reserved;
- __u8 ShortName[12];
+ __u8 ShortName[24];
char FileName[1];
} __attribute__((packed)) FILE_BOTH_DIRECTORY_INFO; /* level 0x104 FFrsp data */
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] cifs: fix FILE_BOTH_DIRECTORY_INFO definition
@ 2022-01-11 8:36 Eugene Korenevsky
2022-01-12 5:59 ` Steve French
0 siblings, 1 reply; 4+ messages in thread
From: Eugene Korenevsky @ 2022-01-11 8:36 UTC (permalink / raw)
To: linux-cifs; +Cc: Steve French
The size of FILE_BOTH_DIRECTORY_INFO.ShortName must be 24 bytes, not 12
(see MS-FSCC documentation).
Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru>
---
fs/cifs/cifspdu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h
index d2ff438fd31f..68b9a436af4b 100644
--- a/fs/cifs/cifspdu.h
+++ b/fs/cifs/cifspdu.h
@@ -2560,7 +2560,7 @@ typedef struct {
__le32 EaSize; /* length of the xattrs */
__u8 ShortNameLength;
__u8 Reserved;
- __u8 ShortName[12];
+ __u8 ShortName[24];
char FileName[1];
} __attribute__((packed)) FILE_BOTH_DIRECTORY_INFO; /* level 0x104 FFrsp data */
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-24 7:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 7:26 [PATCH] cifs: fix FILE_BOTH_DIRECTORY_INFO definition Yupeng Li
-- strict thread matches above, loose matches on Subject: below --
2022-01-11 14:42 Eugene Korenevsky
2022-01-11 8:36 Eugene Korenevsky
2022-01-12 5:59 ` Steve French
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.