* drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min()
@ 2022-03-25 6:32 kernel test robot
2022-03-25 6:24 ` [PATCH] drm/msm: fix minmax.cocci warnings kernel test robot
2022-03-25 6:24 ` [PATCH] drm/msm: fix returnvar.cocci warnings kernel test robot
0 siblings, 2 replies; 4+ messages in thread
From: kernel test robot @ 2022-03-25 6:32 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Christian König" <christian.koenig@amd.com>
CC: Rob Clark <robdclark@gmail.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 85c7000fda0029ec16569b1eec8fd3a8d026be73
commit: b3ed524f84f573ece1aa2f26e9db3c34a593e0d1 drm/msm: allow compile_test on !ARM
date: 6 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 6 months ago
config: arc-randconfig-c004-20220324 (https://download.01.org/0day-ci/archive/20220325/202203251444.fzwS8xP3-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min()
--
>> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: "ret". Return "0" on line 75
Please review and possibly fold the followup patch.
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/msm: fix minmax.cocci warnings
2022-03-25 6:32 drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min() kernel test robot
@ 2022-03-25 6:24 ` kernel test robot
2022-03-25 6:24 ` [PATCH] drm/msm: fix returnvar.cocci warnings kernel test robot
1 sibling, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-03-25 6:24 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Christian König" <christian.koenig@amd.com>
CC: Rob Clark <robdclark@gmail.com>
CC: Sean Paul <sean@poorly.run>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: linux-arm-msm(a)vger.kernel.org
CC: dri-devel(a)lists.freedesktop.org
CC: freedreno(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min()
Check for opencoded min(), max() implementations.
Generated patches sometimes require adding a cast to fix compile warning.
Warnings/patches scope intentionally limited to a function body.
Generated by: scripts/coccinelle/misc/minmax.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 85c7000fda0029ec16569b1eec8fd3a8d026be73
commit: b3ed524f84f573ece1aa2f26e9db3c34a593e0d1 drm/msm: allow compile_test on !ARM
:::::: branch date: 5 hours ago
:::::: commit date: 6 months ago
Please take the patch only if it's a positive warning. Thanks!
drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c
@@ -138,7 +138,7 @@ static inline u32 pll_get_integloop_gain
base <<= digclk_divsel;
- return (base <= 2046 ? base : 2046);
+ return min(base, 2046);
}
static inline u32 pll_get_pll_cmp(u64 fdata, unsigned long ref_clk)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/msm: fix returnvar.cocci warnings
2022-03-25 6:32 drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min() kernel test robot
2022-03-25 6:24 ` [PATCH] drm/msm: fix minmax.cocci warnings kernel test robot
@ 2022-03-25 6:24 ` kernel test robot
1 sibling, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-03-25 6:24 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Christian König" <christian.koenig@amd.com>
CC: Rob Clark <robdclark@gmail.com>
CC: Sean Paul <sean@poorly.run>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: David Heidelberg <david@ixit.cz>
CC: Lyude Paul <lyude@redhat.com>
CC: linux-arm-msm(a)vger.kernel.org
CC: dri-devel(a)lists.freedesktop.org
CC: freedreno(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: "ret". Return "0" on line 75
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 85c7000fda0029ec16569b1eec8fd3a8d026be73
commit: b3ed524f84f573ece1aa2f26e9db3c34a593e0d1 drm/msm: allow compile_test on !ARM
:::::: branch date: 5 hours ago
:::::: commit date: 6 months ago
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
@@ -21,7 +21,6 @@ static int mdp4_hw_init(struct msm_kms *
struct drm_device *dev = mdp4_kms->dev;
u32 dmap_cfg, vg_cfg;
unsigned long clk;
- int ret = 0;
pm_runtime_get_sync(dev->dev);
@@ -72,7 +71,7 @@ static int mdp4_hw_init(struct msm_kms *
pm_runtime_put_sync(dev->dev);
- return ret;
+ return 0;
}
static void mdp4_enable_commit(struct msm_kms *kms)
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min()
@ 2022-04-08 19:18 kernel test robot
2022-04-08 19:08 ` [PATCH] drm/msm: fix returnvar.cocci warnings kernel test robot
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2022-04-08 19:18 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Christian König" <christian.koenig@amd.com>
CC: Rob Clark <robdclark@gmail.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1831fed559732b132aef0ea8261ac77e73f7eadf
commit: b3ed524f84f573ece1aa2f26e9db3c34a593e0d1 drm/msm: allow compile_test on !ARM
date: 6 months ago
:::::: branch date: 14 hours ago
:::::: commit date: 6 months ago
config: arc-randconfig-c004-20220408 (https://download.01.org/0day-ci/archive/20220409/202204090334.JC5H5iNS-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min()
--
>> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: "ret". Return "0" on line 75
Please review and possibly fold the followup patch.
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/msm: fix returnvar.cocci warnings
2022-04-08 19:18 drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min() kernel test robot
@ 2022-04-08 19:08 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-04-08 19:08 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Christian König" <christian.koenig@amd.com>
CC: Rob Clark <robdclark@gmail.com>
CC: Sean Paul <sean@poorly.run>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: David Heidelberg <david@ixit.cz>
CC: Lyude Paul <lyude@redhat.com>
CC: linux-arm-msm(a)vger.kernel.org
CC: dri-devel(a)lists.freedesktop.org
CC: freedreno(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c:24:5-8: Unneeded variable: "ret". Return "0" on line 75
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1831fed559732b132aef0ea8261ac77e73f7eadf
commit: b3ed524f84f573ece1aa2f26e9db3c34a593e0d1 drm/msm: allow compile_test on !ARM
:::::: branch date: 14 hours ago
:::::: commit date: 6 months ago
drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
@@ -21,7 +21,6 @@ static int mdp4_hw_init(struct msm_kms *
struct drm_device *dev = mdp4_kms->dev;
u32 dmap_cfg, vg_cfg;
unsigned long clk;
- int ret = 0;
pm_runtime_get_sync(dev->dev);
@@ -72,7 +71,7 @@ static int mdp4_hw_init(struct msm_kms *
pm_runtime_put_sync(dev->dev);
- return ret;
+ return 0;
}
static void mdp4_enable_commit(struct msm_kms *kms)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-08 19:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 6:32 drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min() kernel test robot
2022-03-25 6:24 ` [PATCH] drm/msm: fix minmax.cocci warnings kernel test robot
2022-03-25 6:24 ` [PATCH] drm/msm: fix returnvar.cocci warnings kernel test robot
2022-04-08 19:18 drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c:141:14-16: WARNING opportunity for min() kernel test robot
2022-04-08 19:08 ` [PATCH] drm/msm: fix returnvar.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.