All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12
@ 2022-03-25 14:28 Marko Zekovic
  2022-03-25 15:07 ` Alex Deucher
  0 siblings, 1 reply; 4+ messages in thread
From: Marko Zekovic @ 2022-03-25 14:28 UTC (permalink / raw)
  To: amd-gfx; +Cc: Marko Zekovic

SMI clock measure API is failing, because sysfs node
for pp_dpm_vclk is not existing
Bug:
https://ontrack-internal.amd.com/browse/SWDEV-327254

Signed-off-by: Marko Zekovic <Marko.Zekovic@amd.com>
---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 5cd67ddf84956..095cf57d73de4 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -1999,7 +1999,7 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
 		if (asic_type < CHIP_VEGA12)
 			*states = ATTR_STATE_UNSUPPORTED;
 	} else if (DEVICE_ATTR_IS(pp_dpm_vclk)) {
-		if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
+		if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID || asic_type == CHIP_NAVI12))
 			*states = ATTR_STATE_UNSUPPORTED;
 	} else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
 		if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
-- 
2.24.1.windows.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12
  2022-03-25 14:28 [PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12 Marko Zekovic
@ 2022-03-25 15:07 ` Alex Deucher
  0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2022-03-25 15:07 UTC (permalink / raw)
  To: Marko Zekovic; +Cc: amd-gfx list

On Fri, Mar 25, 2022 at 10:29 AM Marko Zekovic <Marko.Zekovic@amd.com> wrote:
>
> SMI clock measure API is failing, because sysfs node
> for pp_dpm_vclk is not existing
> Bug:
> https://ontrack-internal.amd.com/browse/SWDEV-327254

Please drop internal bug tickets.  With that fixed, assuming vclk dpm
node is actually supported on navi12,
Acked-by: Alex Deucher <alexander.deucher@amd.com>

>
> Signed-off-by: Marko Zekovic <Marko.Zekovic@amd.com>
> ---
>  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 5cd67ddf84956..095cf57d73de4 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -1999,7 +1999,7 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
>                 if (asic_type < CHIP_VEGA12)
>                         *states = ATTR_STATE_UNSUPPORTED;
>         } else if (DEVICE_ATTR_IS(pp_dpm_vclk)) {
> -               if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
> +               if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID || asic_type == CHIP_NAVI12))
>                         *states = ATTR_STATE_UNSUPPORTED;
>         } else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
>                 if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
> --
> 2.24.1.windows.2
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12
  2022-03-28 10:51 Marko Zekovic
@ 2022-03-28 13:01 ` Lazar, Lijo
  0 siblings, 0 replies; 4+ messages in thread
From: Lazar, Lijo @ 2022-03-28 13:01 UTC (permalink / raw)
  To: Marko Zekovic, amd-gfx



On 3/28/2022 4:21 PM, Marko Zekovic wrote:
> SMI clock measure API is failing on NAVI12, because
> sysfs node for pp_dpm_vclk is not existing
> 
> Signed-off-by: Marko Zekovic <Marko.Zekovic@amd.com>
> Change-Id: I240fa055600bfc0d46dfec374339ba61764f9ab2
> ---
>   drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 9ce597ded31db..5d0602d2c1a1e 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2001,7 +2001,8 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
>   			*states = ATTR_STATE_UNSUPPORTED;
>   	} else if (DEVICE_ATTR_IS(pp_dpm_vclk)) {
>   		if (!(gc_ver == IP_VERSION(10, 3, 1) ||
> -		      gc_ver == IP_VERSION(10, 3, 0)))
> +		      gc_ver == IP_VERSION(10, 3, 0) ||
> +		      gc_ver == IP_VERSION(10, 1, 2)))

For VCN, V and DCLK go in pair. A similar change needed for DCLK?

Thanks,
Lijo

>   			*states = ATTR_STATE_UNSUPPORTED;
>   	} else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
>   		if (!(gc_ver == IP_VERSION(10, 3, 1) ||
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12
@ 2022-03-28 10:51 Marko Zekovic
  2022-03-28 13:01 ` Lazar, Lijo
  0 siblings, 1 reply; 4+ messages in thread
From: Marko Zekovic @ 2022-03-28 10:51 UTC (permalink / raw)
  To: amd-gfx; +Cc: Marko Zekovic

SMI clock measure API is failing on NAVI12, because
sysfs node for pp_dpm_vclk is not existing

Signed-off-by: Marko Zekovic <Marko.Zekovic@amd.com>
Change-Id: I240fa055600bfc0d46dfec374339ba61764f9ab2
---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 9ce597ded31db..5d0602d2c1a1e 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -2001,7 +2001,8 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
 			*states = ATTR_STATE_UNSUPPORTED;
 	} else if (DEVICE_ATTR_IS(pp_dpm_vclk)) {
 		if (!(gc_ver == IP_VERSION(10, 3, 1) ||
-		      gc_ver == IP_VERSION(10, 3, 0)))
+		      gc_ver == IP_VERSION(10, 3, 0) ||
+		      gc_ver == IP_VERSION(10, 1, 2)))
 			*states = ATTR_STATE_UNSUPPORTED;
 	} else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
 		if (!(gc_ver == IP_VERSION(10, 3, 1) ||
-- 
2.24.1.windows.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-28 13:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 14:28 [PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12 Marko Zekovic
2022-03-25 15:07 ` Alex Deucher
2022-03-28 10:51 Marko Zekovic
2022-03-28 13:01 ` Lazar, Lijo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.