* [igt-dev] [PATCH i-g-t 1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+
@ 2022-03-25 17:42 Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 2/4] tools/intel_watermark: Don't do intel_register_access_fini() too early on hsw/bdw Ville Syrjala
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Ville Syrjala @ 2022-03-25 17:42 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The skl+ code forgot to call intel_register_access_fini(). Make
it do so.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_watermark.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
index 1e235ed30a63..1818d79d0bee 100644
--- a/tools/intel_watermark.c
+++ b/tools/intel_watermark.c
@@ -590,6 +590,8 @@ static void skl_wm_dump(void)
printf("\n");
/* clear the sticky bits */
write_reg(0x45280, wm_dbg);
+
+ intel_register_access_fini(&mmio_data);
}
static void ilk_wm_dump(void)
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 2/4] tools/intel_watermark: Don't do intel_register_access_fini() too early on hsw/bdw
2022-03-25 17:42 [igt-dev] [PATCH i-g-t 1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Ville Syrjala
@ 2022-03-25 17:42 ` Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 3/4] tools/intel_watermark: Add missing newline Ville Syrjala
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjala @ 2022-03-25 17:42 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The tool will segfault if we try to the WM_DBG read/write after
intel_register_access_fini(). So move intel_register_access_fini()
to the very end.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_watermark.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
index 1818d79d0bee..d61379c6dc7f 100644
--- a/tools/intel_watermark.c
+++ b/tools/intel_watermark.c
@@ -644,8 +644,6 @@ static void ilk_wm_dump(void)
if (IS_BROADWELL(devid) || IS_HASWELL(devid))
wm_misc = read_reg(0x45260);
- intel_register_access_fini(&mmio_data);
-
for (i = 0; i < num_pipes; i++)
printf(" WM_PIPE_%c = 0x%08x\n", pipe_name(i), wm_pipe[i]);
if (IS_BROADWELL(devid) || IS_HASWELL(devid)) {
@@ -765,6 +763,8 @@ static void ilk_wm_dump(void)
/* clear the sticky bits */
write_reg(0x45280, wm_dbg);
}
+
+ intel_register_access_fini(&mmio_data);
}
static void vlv_wm_dump(void)
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 3/4] tools/intel_watermark: Add missing newline
2022-03-25 17:42 [igt-dev] [PATCH i-g-t 1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 2/4] tools/intel_watermark: Don't do intel_register_access_fini() too early on hsw/bdw Ville Syrjala
@ 2022-03-25 17:42 ` Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 4/4] tools/intel_watermark: Read LP usage from FPGA_DBG on ivb Ville Syrjala
2022-03-25 19:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjala @ 2022-03-25 17:42 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The hsw/bdw WM_DBG output is missing a newline at the end, add one.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_watermark.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
index d61379c6dc7f..863261e823a5 100644
--- a/tools/intel_watermark.c
+++ b/tools/intel_watermark.c
@@ -760,6 +760,7 @@ static void ilk_wm_dump(void)
if (wm_dbg & (1 << (23+i)))
printf(" LP%d", i);
}
+ printf("\n");
/* clear the sticky bits */
write_reg(0x45280, wm_dbg);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 4/4] tools/intel_watermark: Read LP usage from FPGA_DBG on ivb
2022-03-25 17:42 [igt-dev] [PATCH i-g-t 1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 2/4] tools/intel_watermark: Don't do intel_register_access_fini() too early on hsw/bdw Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 3/4] tools/intel_watermark: Add missing newline Ville Syrjala
@ 2022-03-25 17:42 ` Ville Syrjala
2022-03-25 19:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjala @ 2022-03-25 17:42 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
On ivb FPGA_DBG contains the similar LP level sticky bits that
are present in WM_DBG on hsw+. Let's dump these out.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_watermark.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
index 863261e823a5..eac40e4a5d17 100644
--- a/tools/intel_watermark.c
+++ b/tools/intel_watermark.c
@@ -763,6 +763,22 @@ static void ilk_wm_dump(void)
printf("\n");
/* clear the sticky bits */
write_reg(0x45280, wm_dbg);
+ } else if (IS_IVYBRIDGE(devid)) {
+ uint32_t fpga_dbg;
+
+ fpga_dbg = read_reg(0x42300);
+ printf("FPGA_DBG: 0x%08x\n", fpga_dbg);
+ printf(" LP used:");
+ if (fpga_dbg & (1 << 18))
+ printf(" LP0.5");
+ for (i = 1; i < 4; i++) {
+ if (fpga_dbg & (1 << (18+i)))
+ printf(" LP%d", i);
+ }
+ printf("\n");
+ /* clear the sticky LP bits */
+ fpga_dbg &= 1 << 21 | 1 << 20 | 1 << 19 | 1 << 18;
+ write_reg(0x42300, fpga_dbg);
}
intel_register_access_fini(&mmio_data);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+
2022-03-25 17:42 [igt-dev] [PATCH i-g-t 1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Ville Syrjala
` (2 preceding siblings ...)
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 4/4] tools/intel_watermark: Read LP usage from FPGA_DBG on ivb Ville Syrjala
@ 2022-03-25 19:00 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-03-25 19:00 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 9893 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+
URL : https://patchwork.freedesktop.org/series/101799/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11407 -> IGTPW_6830
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6830 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_6830, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/index.html
Participating hosts (45 -> 34)
------------------------------
Additional (1): fi-pnv-d510
Missing (12): fi-bdw-samus bat-dg1-6 bat-dg2-8 bat-dg2-9 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-hsw-1 bat-rpls-1 bat-rpls-2 bat-jsl-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6830:
### IGT changes ###
#### Possible regressions ####
* igt@core_hotunplug@unbind-rebind:
- fi-bsw-n3050: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bsw-n3050/igt@core_hotunplug@unbind-rebind.html
- fi-glk-dsi: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-glk-dsi/igt@core_hotunplug@unbind-rebind.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-glk-dsi/igt@core_hotunplug@unbind-rebind.html
* igt@gem_render_tiled_blits@basic:
- fi-kbl-x1275: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-kbl-x1275/igt@gem_render_tiled_blits@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-kbl-x1275/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- fi-hsw-4770: [PASS][6] -> [INCOMPLETE][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-hsw-4770/igt@gem_tiled_blits@basic.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-hsw-4770/igt@gem_tiled_blits@basic.html
- fi-pnv-d510: NOTRUN -> [INCOMPLETE][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-pnv-d510/igt@gem_tiled_blits@basic.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_render_tiled_blits@basic:
- {fi-tgl-dsi}: NOTRUN -> [INCOMPLETE][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-tgl-dsi/igt@gem_render_tiled_blits@basic.html
- {fi-hsw-g3258}: [PASS][10] -> [INCOMPLETE][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-hsw-g3258/igt@gem_render_tiled_blits@basic.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-hsw-g3258/igt@gem_render_tiled_blits@basic.html
Known issues
------------
Here are the changes found in IGTPW_6830 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-pnv-d510: NOTRUN -> [SKIP][12] ([fdo#109271]) +11 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-pnv-d510/igt@gem_huc_copy@huc-copy.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bsw-n3050/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-bwr-2160: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#5341])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bwr-2160/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-bsw-n3050: NOTRUN -> [SKIP][15] ([fdo#109271]) +22 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bsw-n3050/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-bwr-2160: NOTRUN -> [SKIP][16] ([fdo#109271]) +45 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bwr-2160/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][17] ([i915#2403] / [i915#4312])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-pnv-d510/igt@runner@aborted.html
- fi-glk-dsi: NOTRUN -> [FAIL][18] ([i915#4312] / [k.org#202321])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-glk-dsi/igt@runner@aborted.html
- fi-hsw-4770: NOTRUN -> [FAIL][19] ([i915#4312])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-hsw-4770/igt@runner@aborted.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- {fi-adl-ddr5}: [INCOMPLETE][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-adl-ddr5/igt@core_hotunplug@unbind-rebind.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-adl-ddr5/igt@core_hotunplug@unbind-rebind.html
* igt@gem_render_linear_blits@basic:
- {fi-tgl-dsi}: [INCOMPLETE][22] -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-tgl-dsi/igt@gem_render_linear_blits@basic.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-tgl-dsi/igt@gem_render_linear_blits@basic.html
* igt@gem_render_tiled_blits@basic:
- fi-bsw-n3050: [INCOMPLETE][24] -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-bsw-n3050/igt@gem_render_tiled_blits@basic.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bsw-n3050/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- fi-bwr-2160: [INCOMPLETE][26] -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-bwr-2160/igt@gem_tiled_blits@basic.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bwr-2160/igt@gem_tiled_blits@basic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- fi-bsw-kefka: [FAIL][28] ([i915#2122]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][30] ([i915#295]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][32] ([i915#295]) -> [PASS][33] +9 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-cfl-8109u: [DMESG-WARN][34] ([i915#295] / [i915#5341]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
#### Warnings ####
* igt@gem_tiled_blits@basic:
- fi-cfl-guc: [INCOMPLETE][36] -> [INCOMPLETE][37] ([i915#1982])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-cfl-guc/igt@gem_tiled_blits@basic.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-cfl-guc/igt@gem_tiled_blits@basic.html
* igt@runner@aborted:
- fi-bsw-n3050: [FAIL][38] ([i915#3428] / [i915#4312]) -> [FAIL][39] ([i915#4312])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-bsw-n3050/igt@runner@aborted.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/fi-bsw-n3050/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6393 -> IGTPW_6830
CI-20190529: 20190529
CI_DRM_11407: a2fff1c90d9587c65608497d5bf5781c073bf46a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6830: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/index.html
IGT_6393: 1d267ea1b829fa10b31a37ccf6b4a970f032784a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6830/index.html
[-- Attachment #2: Type: text/html, Size: 11750 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-25 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 17:42 [igt-dev] [PATCH i-g-t 1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 2/4] tools/intel_watermark: Don't do intel_register_access_fini() too early on hsw/bdw Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 3/4] tools/intel_watermark: Add missing newline Ville Syrjala
2022-03-25 17:42 ` [igt-dev] [PATCH i-g-t 4/4] tools/intel_watermark: Read LP usage from FPGA_DBG on ivb Ville Syrjala
2022-03-25 19:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] tools/intel_watermark: Add missing intel_register_access_fini() for skl+ Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.