* [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
@ 2022-03-27 11:18 Tianci Yin
2022-03-27 13:47 ` Zhu, James
2022-03-28 1:25 ` Chen, Guchun
0 siblings, 2 replies; 6+ messages in thread
From: Tianci Yin @ 2022-03-27 11:18 UTC (permalink / raw)
To: amd-gfx; +Cc: Wang Yu, Zhu James, Tianci Yin, Guchun Chen
From: tiancyin <tianci.yin@amd.com>
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x00000001 != 0x00000002
Signed-off-by: tiancyin <tianci.yin@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, &state);
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, &state);
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
2022-03-27 11:18 [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 Tianci Yin
@ 2022-03-27 13:47 ` Zhu, James
2022-03-27 14:54 ` Yin, Tianci (Rico)
2022-03-28 1:25 ` Chen, Guchun
1 sibling, 1 reply; 6+ messages in thread
From: Zhu, James @ 2022-03-27 13:47 UTC (permalink / raw)
To: Yin, Tianci (Rico), amd-gfx; +Cc: Wang, Yu (Charlie), Chen, Guchun
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
[AMD Official Use Only]
This patch is Reviewed-by: James Zhu <James.Zhu@amd.com>
________________________________
From: Tianci Yin <tianci.yin@amd.com>
Sent: Sunday, March 27, 2022 7:18 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Chen, Guchun <Guchun.Chen@amd.com>; Zhu, James <James.Zhu@amd.com>; Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin <tianci.yin@amd.com>
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x00000001 != 0x00000002
Signed-off-by: tiancyin <tianci.yin@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, &state);
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, &state);
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
[-- Attachment #2: Type: text/html, Size: 3111 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
2022-03-27 13:47 ` Zhu, James
@ 2022-03-27 14:54 ` Yin, Tianci (Rico)
0 siblings, 0 replies; 6+ messages in thread
From: Yin, Tianci (Rico) @ 2022-03-27 14:54 UTC (permalink / raw)
To: Zhu, James, amd-gfx; +Cc: Wang, Yu (Charlie), Chen, Guchun
[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]
[AMD Official Use Only]
Thank you James!
Rico
________________________________
From: Zhu, James <James.Zhu@amd.com>
Sent: Sunday, March 27, 2022 21:47
To: Yin, Tianci (Rico) <Tianci.Yin@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Chen, Guchun <Guchun.Chen@amd.com>; Wang, Yu (Charlie) <Yu.Wang4@amd.com>
Subject: Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
[AMD Official Use Only]
This patch is Reviewed-by: James Zhu <James.Zhu@amd.com>
________________________________
From: Tianci Yin <tianci.yin@amd.com>
Sent: Sunday, March 27, 2022 7:18 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Chen, Guchun <Guchun.Chen@amd.com>; Zhu, James <James.Zhu@amd.com>; Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin <tianci.yin@amd.com>
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x00000001 != 0x00000002
Signed-off-by: tiancyin <tianci.yin@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, &state);
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, &state);
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
[-- Attachment #2: Type: text/html, Size: 4315 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
2022-03-27 11:18 [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 Tianci Yin
2022-03-27 13:47 ` Zhu, James
@ 2022-03-28 1:25 ` Chen, Guchun
2022-03-28 2:17 ` Chen, Guchun
1 sibling, 1 reply; 6+ messages in thread
From: Chen, Guchun @ 2022-03-28 1:25 UTC (permalink / raw)
To: Yin, Tianci (Rico), amd-gfx
Cc: Wang, Yu (Charlie), Zhu, James, Yin, Tianci (Rico)
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: Tianci Yin <tianci.yin@amd.com>
Sent: Sunday, March 27, 2022 7:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun <Guchun.Chen@amd.com>; Zhu, James <James.Zhu@amd.com>; Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin <tianci.yin@amd.com>
Some video card has more than one vcn instance, passing 0 to vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x00000001 != 0x00000002
Signed-off-by: tiancyin <tianci.yin@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, &state);
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, &state);
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
2022-03-28 1:25 ` Chen, Guchun
@ 2022-03-28 2:17 ` Chen, Guchun
2022-03-28 2:22 ` Yin, Tianci (Rico)
0 siblings, 1 reply; 6+ messages in thread
From: Chen, Guchun @ 2022-03-28 2:17 UTC (permalink / raw)
To: Chen, Guchun, Yin, Tianci (Rico), amd-gfx
Cc: Wang, Yu (Charlie), Zhu, James, Yin, Tianci (Rico)
Hi Tianci,
I think we shall improve the subject a bit like "drm/amdgpu: fix incorrect instance id passing when stopping dpg mode". How do you think?
Regards,
Guchun
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Chen, Guchun
Sent: Monday, March 28, 2022 9:26 AM
To: Yin, Tianci (Rico) <Tianci.Yin@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Zhu, James <James.Zhu@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: Tianci Yin <tianci.yin@amd.com>
Sent: Sunday, March 27, 2022 7:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun <Guchun.Chen@amd.com>; Zhu, James <James.Zhu@amd.com>; Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin <tianci.yin@amd.com>
Some video card has more than one vcn instance, passing 0 to vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x00000001 != 0x00000002
Signed-off-by: tiancyin <tianci.yin@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, &state);
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, &state);
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
2022-03-28 2:17 ` Chen, Guchun
@ 2022-03-28 2:22 ` Yin, Tianci (Rico)
0 siblings, 0 replies; 6+ messages in thread
From: Yin, Tianci (Rico) @ 2022-03-28 2:22 UTC (permalink / raw)
To: Chen, Guchun, amd-gfx; +Cc: Wang, Yu (Charlie), Zhu, James
[-- Attachment #1: Type: text/plain, Size: 2606 bytes --]
[AMD Official Use Only]
Thank you very much for your suggestion, but I have already submitted.
Regards,
Rico
________________________________
From: Chen, Guchun <Guchun.Chen@amd.com>
Sent: Monday, March 28, 2022 10:17
To: Chen, Guchun <Guchun.Chen@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Zhu, James <James.Zhu@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Hi Tianci,
I think we shall improve the subject a bit like "drm/amdgpu: fix incorrect instance id passing when stopping dpg mode". How do you think?
Regards,
Guchun
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Chen, Guchun
Sent: Monday, March 28, 2022 9:26 AM
To: Yin, Tianci (Rico) <Tianci.Yin@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Zhu, James <James.Zhu@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: Tianci Yin <tianci.yin@amd.com>
Sent: Sunday, March 27, 2022 7:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun <Guchun.Chen@amd.com>; Zhu, James <James.Zhu@amd.com>; Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Yin, Tianci (Rico) <Tianci.Yin@amd.com>
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin <tianci.yin@amd.com>
Some video card has more than one vcn instance, passing 0 to vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x00000001 != 0x00000002
Signed-off-by: tiancyin <tianci.yin@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, &state);
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, &state);
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
[-- Attachment #2: Type: text/html, Size: 4365 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-28 2:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-27 11:18 [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 Tianci Yin
2022-03-27 13:47 ` Zhu, James
2022-03-27 14:54 ` Yin, Tianci (Rico)
2022-03-28 1:25 ` Chen, Guchun
2022-03-28 2:17 ` Chen, Guchun
2022-03-28 2:22 ` Yin, Tianci (Rico)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.