From: Victor Toso <victortoso@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [PATCH v3 00/14] Fix some qapi examples and a TODO section
Date: Mon, 28 Mar 2022 16:05:50 +0200 [thread overview]
Message-ID: <20220328140604.41484-1-victortoso@redhat.com> (raw)
Hi,
I've being using the examples as unit tests and found a few that
doesn't work out-of-the-box, might be inteded in order to be less
verbose in the qapi documentation but nevertheless I'm sending this
out in case you want to cherry-pick them.
* Changes in v3:
Improved commit log from patch 03 to 14 with suggetions based on:
https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg06490.html
* Changes in v2:
02/14: qapi: fix example of BLOCK_IMAGE_CORRUPTED event
- changed the example to an actual error picked from
qemu-iotests/60.out
- added recent timestamp :)
03/14: qapi: fix example of BLOCK_IO_ERROR event
- use real error message, in this case "No space left on device"
04/14: qapi: fix example of BLOCK_JOB_PENDING event
- added an extra space
- added recent timestamp
07/14: qapi: fix example of UNPLUG_PRIMARY event
- amended commit message
08/14: qapi: fix example of FAILOVER_NEGOTIATED event
- fixed syntax for proper document parameter
09/14: qapi: run-state examples: add missing member
- fixed commit message
10/14: qapi: run-state examples: add missing timestamp
- added chronological timestamps ;)
Cheers,
Victor
Victor Toso (14):
qapi: BlockExportRemoveMode: move comments to TODO
qapi: fix example of BLOCK_IMAGE_CORRUPTED event
qapi: fix example of BLOCK_IO_ERROR event
qapi: fix example of BLOCK_JOB_PENDING event
qapi: fix example of DUMP_COMPLETED event
qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event
qapi: fix example of UNPLUG_PRIMARY event
qapi: fix example of FAILOVER_NEGOTIATED event
qapi: fix examples: SHUTDOWN and RESET events
qapi: run-state examples: add missing @timestamp
qapi: fix example of MEMORY_FAILURE
qapi: ui examples: add missing @websocket member
qapi: fix example of ACPI_DEVICE_OST event
qapi: fix example of dump-guest-memory
qapi/acpi.json | 5 +++--
qapi/block-core.json | 14 +++++++-------
qapi/block-export.json | 10 +++++-----
qapi/dump.json | 9 +++++----
qapi/machine.json | 3 ++-
qapi/migration.json | 4 +++-
qapi/net.json | 6 ++++--
qapi/run-state.json | 16 +++++++++++-----
qapi/ui.json | 12 ++++++------
9 files changed, 46 insertions(+), 33 deletions(-)
--
2.35.1
next reply other threads:[~2022-03-28 14:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 14:05 Victor Toso [this message]
2022-03-28 14:05 ` [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO Victor Toso
2022-03-28 14:05 ` [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Victor Toso
2022-03-29 15:34 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event Victor Toso
2022-03-29 15:39 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event Victor Toso
2022-03-28 14:05 ` [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event Victor Toso
2022-03-28 14:05 ` [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Victor Toso
2022-03-28 14:05 ` [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event Victor Toso
2022-03-29 15:40 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Victor Toso
2022-03-29 15:41 ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events Victor Toso
2022-03-29 15:45 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp Victor Toso
2022-03-29 15:46 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE Victor Toso
2022-03-29 15:52 ` Markus Armbruster
2022-03-30 10:15 ` Victor Toso
2022-03-28 14:06 ` [PATCH v3 12/14] qapi: ui examples: add missing @websocket member Victor Toso
2022-03-29 15:55 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event Victor Toso
2022-03-29 15:55 ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 14/14] qapi: fix example of dump-guest-memory Victor Toso
2022-03-29 15:56 ` Markus Armbruster
2022-03-29 16:00 ` [PATCH v3 00/14] Fix some qapi examples and a TODO section Markus Armbruster
2022-03-29 16:14 ` John Snow
2022-03-31 10:44 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328140604.41484-1-victortoso@redhat.com \
--to=victortoso@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.