All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Victor Toso <victortoso@redhat.com>
Cc: John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event
Date: Tue, 29 Mar 2022 17:39:32 +0200	[thread overview]
Message-ID: <87lews22ff.fsf@pond.sub.org> (raw)
In-Reply-To: <20220328140604.41484-4-victortoso@redhat.com> (Victor Toso's message of "Mon, 28 Mar 2022 16:05:53 +0200")

Victor Toso <victortoso@redhat.com> writes:

> Example output lacks mandatory member @reason.  Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  qapi/block-core.json | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 63c30a5378..46580ac551 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -5058,7 +5058,8 @@
>  #      "data": { "device": "ide0-hd1",
>  #                "node-name": "#block212",
>  #                "operation": "write",
> -#                "action": "stop" },
> +#                "action": "stop",
> +#                "reason": "No space left on device" },
>  #      "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
>  #
>  ##

I briefly wondered whether "reason": "No space left on device" implies
"nospace: true, but it looks like it doesn't.

Reviewed-by: Markus Armbruster <armbru@redhat.com>



  reply	other threads:[~2022-03-29 15:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 14:05 [PATCH v3 00/14] Fix some qapi examples and a TODO section Victor Toso
2022-03-28 14:05 ` [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO Victor Toso
2022-03-28 14:05 ` [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Victor Toso
2022-03-29 15:34   ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event Victor Toso
2022-03-29 15:39   ` Markus Armbruster [this message]
2022-03-28 14:05 ` [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event Victor Toso
2022-03-28 14:05 ` [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event Victor Toso
2022-03-28 14:05 ` [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Victor Toso
2022-03-28 14:05 ` [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event Victor Toso
2022-03-29 15:40   ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Victor Toso
2022-03-29 15:41   ` Markus Armbruster
2022-03-28 14:05 ` [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events Victor Toso
2022-03-29 15:45   ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp Victor Toso
2022-03-29 15:46   ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE Victor Toso
2022-03-29 15:52   ` Markus Armbruster
2022-03-30 10:15     ` Victor Toso
2022-03-28 14:06 ` [PATCH v3 12/14] qapi: ui examples: add missing @websocket member Victor Toso
2022-03-29 15:55   ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event Victor Toso
2022-03-29 15:55   ` Markus Armbruster
2022-03-28 14:06 ` [PATCH v3 14/14] qapi: fix example of dump-guest-memory Victor Toso
2022-03-29 15:56   ` Markus Armbruster
2022-03-29 16:00 ` [PATCH v3 00/14] Fix some qapi examples and a TODO section Markus Armbruster
2022-03-29 16:14   ` John Snow
2022-03-31 10:44 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lews22ff.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=victortoso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.