All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration
@ 2022-03-22 18:42 Tim Harvey
  2022-03-23  0:32 ` Fabio Estevam
  2022-03-28 18:41 ` Tom Rini
  0 siblings, 2 replies; 5+ messages in thread
From: Tim Harvey @ 2022-03-22 18:42 UTC (permalink / raw)
  To: u-boot, Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team; +Cc: Tim Harvey

Enable ONFI detection to fix NAND chip configuration. Without this
the NAND oobsize will be wrong which leads to invalid ECC strength and
incompatibility with the previous configuration.

Fixes: 777f333c375a ("imx: ventana: enable dm for MTD and NAND")

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 configs/gwventana_nand_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/gwventana_nand_defconfig b/configs/gwventana_nand_defconfig
index 9fadc014a2c6..42e4f98b13b0 100644
--- a/configs/gwventana_nand_defconfig
+++ b/configs/gwventana_nand_defconfig
@@ -106,6 +106,7 @@ CONFIG_DM_MTD=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_NAND_MXS=y
 CONFIG_NAND_MXS_DT=y
+CONFIG_SYS_NAND_ONFI_DETECTION=y
 CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
 CONFIG_SYS_NAND_U_BOOT_OFFS=0xe00000
 CONFIG_PHYLIB=y
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration
  2022-03-22 18:42 [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration Tim Harvey
@ 2022-03-23  0:32 ` Fabio Estevam
  2022-03-28 16:40   ` Tim Harvey
  2022-03-28 18:41 ` Tom Rini
  1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2022-03-23  0:32 UTC (permalink / raw)
  To: Tim Harvey; +Cc: U-Boot-Denx, Stefano Babic, NXP i . MX U-Boot Team

Hi Tim,

On Tue, Mar 22, 2022 at 3:42 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> Enable ONFI detection to fix NAND chip configuration. Without this
> the NAND oobsize will be wrong which leads to invalid ECC strength and
> incompatibility with the previous configuration.
>
> Fixes: 777f333c375a ("imx: ventana: enable dm for MTD and NAND")
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Reviewed-by: Fabio Estevam <festevam@denx.de>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration
  2022-03-23  0:32 ` Fabio Estevam
@ 2022-03-28 16:40   ` Tim Harvey
  2022-03-28 16:44     ` Tom Rini
  0 siblings, 1 reply; 5+ messages in thread
From: Tim Harvey @ 2022-03-28 16:40 UTC (permalink / raw)
  To: Tom Rini, Stefano Babic
  Cc: U-Boot-Denx, NXP i . MX U-Boot Team, Fabio Estevam

On Tue, Mar 22, 2022 at 5:32 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Tim,
>
> On Tue, Mar 22, 2022 at 3:42 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > Enable ONFI detection to fix NAND chip configuration. Without this
> > the NAND oobsize will be wrong which leads to invalid ECC strength and
> > incompatibility with the previous configuration.
> >
> > Fixes: 777f333c375a ("imx: ventana: enable dm for MTD and NAND")
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>
> Reviewed-by: Fabio Estevam <festevam@denx.de>

Tom and Stefano,

With commit ed48490f8d3f ("mtd: gpmi: fix the bch setting backward
compatible issue") now applied could this be applied for v2022.04 as
well to fix NAND on the gw_ventana boards?

Best Regards,

Tim

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration
  2022-03-28 16:40   ` Tim Harvey
@ 2022-03-28 16:44     ` Tom Rini
  0 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2022-03-28 16:44 UTC (permalink / raw)
  To: Tim Harvey
  Cc: Stefano Babic, U-Boot-Denx, NXP i . MX U-Boot Team, Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Mon, Mar 28, 2022 at 09:40:59AM -0700, Tim Harvey wrote:
> On Tue, Mar 22, 2022 at 5:32 PM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Hi Tim,
> >
> > On Tue, Mar 22, 2022 at 3:42 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > Enable ONFI detection to fix NAND chip configuration. Without this
> > > the NAND oobsize will be wrong which leads to invalid ECC strength and
> > > incompatibility with the previous configuration.
> > >
> > > Fixes: 777f333c375a ("imx: ventana: enable dm for MTD and NAND")
> > >
> > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> >
> > Reviewed-by: Fabio Estevam <festevam@denx.de>
> 
> Tom and Stefano,
> 
> With commit ed48490f8d3f ("mtd: gpmi: fix the bch setting backward
> compatible issue") now applied could this be applied for v2022.04 as
> well to fix NAND on the gw_ventana boards?

Yes, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration
  2022-03-22 18:42 [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration Tim Harvey
  2022-03-23  0:32 ` Fabio Estevam
@ 2022-03-28 18:41 ` Tom Rini
  1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2022-03-28 18:41 UTC (permalink / raw)
  To: Tim Harvey; +Cc: u-boot, Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On Tue, Mar 22, 2022 at 11:42:49AM -0700, Tim Harvey wrote:

> Enable ONFI detection to fix NAND chip configuration. Without this
> the NAND oobsize will be wrong which leads to invalid ECC strength and
> incompatibility with the previous configuration.
> 
> Fixes: 777f333c375a ("imx: ventana: enable dm for MTD and NAND")
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-03-28 18:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 18:42 [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration Tim Harvey
2022-03-23  0:32 ` Fabio Estevam
2022-03-28 16:40   ` Tim Harvey
2022-03-28 16:44     ` Tom Rini
2022-03-28 18:41 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.