* [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path
@ 2022-03-28 10:58 Xianting Tian
2022-03-28 10:58 ` [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check Xianting Tian
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Xianting Tian @ 2022-03-28 10:58 UTC (permalink / raw)
To: mst, jasowang, sgarzare; +Cc: virtualization, linux-kernel, Xianting Tian
It passes '_vq' to virtqueue_use_indirect(), which still calls
to_vvq to get 'vq', let's directly pass 'vq'. It can avoid
unnecessary call of to_vvq in hot path.
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
drivers/virtio/virtio_ring.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 962f1477b1fa..d597fc0874ec 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -205,11 +205,9 @@ struct vring_virtqueue {
#define to_vvq(_vq) container_of(_vq, struct vring_virtqueue, vq)
-static inline bool virtqueue_use_indirect(struct virtqueue *_vq,
+static inline bool virtqueue_use_indirect(struct vring_virtqueue *vq,
unsigned int total_sg)
{
- struct vring_virtqueue *vq = to_vvq(_vq);
-
/*
* If the host supports indirect descriptor tables, and we have multiple
* buffers, then go indirect. FIXME: tune this threshold
@@ -507,7 +505,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
head = vq->free_head;
- if (virtqueue_use_indirect(_vq, total_sg))
+ if (virtqueue_use_indirect(vq, total_sg))
desc = alloc_indirect_split(_vq, total_sg, gfp);
else {
desc = NULL;
@@ -1194,7 +1192,7 @@ static inline int virtqueue_add_packed(struct virtqueue *_vq,
BUG_ON(total_sg == 0);
- if (virtqueue_use_indirect(_vq, total_sg)) {
+ if (virtqueue_use_indirect(vq, total_sg)) {
err = virtqueue_add_indirect_packed(vq, sgs, total_sg, out_sgs,
in_sgs, data, gfp);
if (err != -ENOMEM) {
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check
2022-03-28 10:58 [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path Xianting Tian
@ 2022-03-28 10:58 ` Xianting Tian
2022-03-29 4:57 ` Jason Wang
2022-03-29 7:50 ` Stefano Garzarella
2022-03-29 4:56 ` Jason Wang
2022-03-29 7:49 ` Stefano Garzarella
2 siblings, 2 replies; 13+ messages in thread
From: Xianting Tian @ 2022-03-28 10:58 UTC (permalink / raw)
To: mst, jasowang, sgarzare; +Cc: virtualization, linux-kernel, Xianting Tian
The 'if (vq->vq.num_free < descs_used)' check will almost always be false.
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
drivers/virtio/virtio_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index d597fc0874ec..ab6d5f0cb579 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -525,7 +525,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
descs_used = total_sg;
}
- if (vq->vq.num_free < descs_used) {
+ if (unlikely(vq->vq.num_free < descs_used)) {
pr_debug("Can't add buf len %i - avail = %i\n",
descs_used, vq->vq.num_free);
/* FIXME: for historical reasons, we force a notify here if
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check
2022-03-28 10:58 ` [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check Xianting Tian
@ 2022-03-29 4:57 ` Jason Wang
2022-03-29 7:50 ` Stefano Garzarella
1 sibling, 0 replies; 13+ messages in thread
From: Jason Wang @ 2022-03-29 4:57 UTC (permalink / raw)
To: Xianting Tian; +Cc: mst, Stefano Garzarella, virtualization, linux-kernel
On Mon, Mar 28, 2022 at 6:58 PM Xianting Tian
<xianting.tian@linux.alibaba.com> wrote:
>
> The 'if (vq->vq.num_free < descs_used)' check will almost always be false.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index d597fc0874ec..ab6d5f0cb579 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -525,7 +525,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
> descs_used = total_sg;
> }
>
> - if (vq->vq.num_free < descs_used) {
> + if (unlikely(vq->vq.num_free < descs_used)) {
> pr_debug("Can't add buf len %i - avail = %i\n",
> descs_used, vq->vq.num_free);
> /* FIXME: for historical reasons, we force a notify here if
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check
@ 2022-03-29 4:57 ` Jason Wang
0 siblings, 0 replies; 13+ messages in thread
From: Jason Wang @ 2022-03-29 4:57 UTC (permalink / raw)
To: Xianting Tian; +Cc: virtualization, linux-kernel, mst
On Mon, Mar 28, 2022 at 6:58 PM Xianting Tian
<xianting.tian@linux.alibaba.com> wrote:
>
> The 'if (vq->vq.num_free < descs_used)' check will almost always be false.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index d597fc0874ec..ab6d5f0cb579 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -525,7 +525,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
> descs_used = total_sg;
> }
>
> - if (vq->vq.num_free < descs_used) {
> + if (unlikely(vq->vq.num_free < descs_used)) {
> pr_debug("Can't add buf len %i - avail = %i\n",
> descs_used, vq->vq.num_free);
> /* FIXME: for historical reasons, we force a notify here if
> --
> 2.17.1
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check
2022-03-28 10:58 ` [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check Xianting Tian
@ 2022-03-29 7:50 ` Stefano Garzarella
2022-03-29 7:50 ` Stefano Garzarella
1 sibling, 0 replies; 13+ messages in thread
From: Stefano Garzarella @ 2022-03-29 7:50 UTC (permalink / raw)
To: Xianting Tian; +Cc: virtualization, linux-kernel, mst
On Mon, Mar 28, 2022 at 06:58:17PM +0800, Xianting Tian wrote:
>The 'if (vq->vq.num_free < descs_used)' check will almost always be false.
>
>Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>index d597fc0874ec..ab6d5f0cb579 100644
>--- a/drivers/virtio/virtio_ring.c
>+++ b/drivers/virtio/virtio_ring.c
>@@ -525,7 +525,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
> descs_used = total_sg;
> }
>
>- if (vq->vq.num_free < descs_used) {
>+ if (unlikely(vq->vq.num_free < descs_used)) {
> pr_debug("Can't add buf len %i - avail = %i\n",
> descs_used, vq->vq.num_free);
> /* FIXME: for historical reasons, we force a notify here if
>--
>2.17.1
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check
@ 2022-03-29 7:50 ` Stefano Garzarella
0 siblings, 0 replies; 13+ messages in thread
From: Stefano Garzarella @ 2022-03-29 7:50 UTC (permalink / raw)
To: Xianting Tian; +Cc: mst, jasowang, virtualization, linux-kernel
On Mon, Mar 28, 2022 at 06:58:17PM +0800, Xianting Tian wrote:
>The 'if (vq->vq.num_free < descs_used)' check will almost always be false.
>
>Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>index d597fc0874ec..ab6d5f0cb579 100644
>--- a/drivers/virtio/virtio_ring.c
>+++ b/drivers/virtio/virtio_ring.c
>@@ -525,7 +525,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
> descs_used = total_sg;
> }
>
>- if (vq->vq.num_free < descs_used) {
>+ if (unlikely(vq->vq.num_free < descs_used)) {
> pr_debug("Can't add buf len %i - avail = %i\n",
> descs_used, vq->vq.num_free);
> /* FIXME: for historical reasons, we force a notify here if
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check
2022-03-29 7:50 ` Stefano Garzarella
(?)
@ 2022-04-04 15:11 ` Xianting Tian
2022-04-04 16:27 ` Michael S. Tsirkin
-1 siblings, 1 reply; 13+ messages in thread
From: Xianting Tian @ 2022-04-04 15:11 UTC (permalink / raw)
To: Stefano Garzarella; +Cc: mst, jasowang, virtualization, linux-kernel
I can't find it in next branch, will you apply this patch?
在 2022/3/29 下午3:50, Stefano Garzarella 写道:
> On Mon, Mar 28, 2022 at 06:58:17PM +0800, Xianting Tian wrote:
>> The 'if (vq->vq.num_free < descs_used)' check will almost always be
>> false.
>>
>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>> ---
>> drivers/virtio/virtio_ring.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>>
>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>> index d597fc0874ec..ab6d5f0cb579 100644
>> --- a/drivers/virtio/virtio_ring.c
>> +++ b/drivers/virtio/virtio_ring.c
>> @@ -525,7 +525,7 @@ static inline int virtqueue_add_split(struct
>> virtqueue *_vq,
>> descs_used = total_sg;
>> }
>>
>> - if (vq->vq.num_free < descs_used) {
>> + if (unlikely(vq->vq.num_free < descs_used)) {
>> pr_debug("Can't add buf len %i - avail = %i\n",
>> descs_used, vq->vq.num_free);
>> /* FIXME: for historical reasons, we force a notify here if
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path
2022-03-28 10:58 [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path Xianting Tian
@ 2022-03-29 4:56 ` Jason Wang
2022-03-29 4:56 ` Jason Wang
2022-03-29 7:49 ` Stefano Garzarella
2 siblings, 0 replies; 13+ messages in thread
From: Jason Wang @ 2022-03-29 4:56 UTC (permalink / raw)
To: Xianting Tian; +Cc: virtualization, linux-kernel, mst
On Mon, Mar 28, 2022 at 6:58 PM Xianting Tian
<xianting.tian@linux.alibaba.com> wrote:
>
> It passes '_vq' to virtqueue_use_indirect(), which still calls
> to_vvq to get 'vq', let's directly pass 'vq'. It can avoid
> unnecessary call of to_vvq in hot path.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/virtio/virtio_ring.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 962f1477b1fa..d597fc0874ec 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -205,11 +205,9 @@ struct vring_virtqueue {
>
> #define to_vvq(_vq) container_of(_vq, struct vring_virtqueue, vq)
>
> -static inline bool virtqueue_use_indirect(struct virtqueue *_vq,
> +static inline bool virtqueue_use_indirect(struct vring_virtqueue *vq,
> unsigned int total_sg)
> {
> - struct vring_virtqueue *vq = to_vvq(_vq);
> -
> /*
> * If the host supports indirect descriptor tables, and we have multiple
> * buffers, then go indirect. FIXME: tune this threshold
> @@ -507,7 +505,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
>
> head = vq->free_head;
>
> - if (virtqueue_use_indirect(_vq, total_sg))
> + if (virtqueue_use_indirect(vq, total_sg))
> desc = alloc_indirect_split(_vq, total_sg, gfp);
> else {
> desc = NULL;
> @@ -1194,7 +1192,7 @@ static inline int virtqueue_add_packed(struct virtqueue *_vq,
>
> BUG_ON(total_sg == 0);
>
> - if (virtqueue_use_indirect(_vq, total_sg)) {
> + if (virtqueue_use_indirect(vq, total_sg)) {
> err = virtqueue_add_indirect_packed(vq, sgs, total_sg, out_sgs,
> in_sgs, data, gfp);
> if (err != -ENOMEM) {
> --
> 2.17.1
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path
@ 2022-03-29 4:56 ` Jason Wang
0 siblings, 0 replies; 13+ messages in thread
From: Jason Wang @ 2022-03-29 4:56 UTC (permalink / raw)
To: Xianting Tian; +Cc: mst, Stefano Garzarella, virtualization, linux-kernel
On Mon, Mar 28, 2022 at 6:58 PM Xianting Tian
<xianting.tian@linux.alibaba.com> wrote:
>
> It passes '_vq' to virtqueue_use_indirect(), which still calls
> to_vvq to get 'vq', let's directly pass 'vq'. It can avoid
> unnecessary call of to_vvq in hot path.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/virtio/virtio_ring.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 962f1477b1fa..d597fc0874ec 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -205,11 +205,9 @@ struct vring_virtqueue {
>
> #define to_vvq(_vq) container_of(_vq, struct vring_virtqueue, vq)
>
> -static inline bool virtqueue_use_indirect(struct virtqueue *_vq,
> +static inline bool virtqueue_use_indirect(struct vring_virtqueue *vq,
> unsigned int total_sg)
> {
> - struct vring_virtqueue *vq = to_vvq(_vq);
> -
> /*
> * If the host supports indirect descriptor tables, and we have multiple
> * buffers, then go indirect. FIXME: tune this threshold
> @@ -507,7 +505,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
>
> head = vq->free_head;
>
> - if (virtqueue_use_indirect(_vq, total_sg))
> + if (virtqueue_use_indirect(vq, total_sg))
> desc = alloc_indirect_split(_vq, total_sg, gfp);
> else {
> desc = NULL;
> @@ -1194,7 +1192,7 @@ static inline int virtqueue_add_packed(struct virtqueue *_vq,
>
> BUG_ON(total_sg == 0);
>
> - if (virtqueue_use_indirect(_vq, total_sg)) {
> + if (virtqueue_use_indirect(vq, total_sg)) {
> err = virtqueue_add_indirect_packed(vq, sgs, total_sg, out_sgs,
> in_sgs, data, gfp);
> if (err != -ENOMEM) {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path
2022-03-28 10:58 [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path Xianting Tian
@ 2022-03-29 7:49 ` Stefano Garzarella
2022-03-29 4:56 ` Jason Wang
2022-03-29 7:49 ` Stefano Garzarella
2 siblings, 0 replies; 13+ messages in thread
From: Stefano Garzarella @ 2022-03-29 7:49 UTC (permalink / raw)
To: Xianting Tian; +Cc: virtualization, linux-kernel, mst
On Mon, Mar 28, 2022 at 06:58:16PM +0800, Xianting Tian wrote:
>It passes '_vq' to virtqueue_use_indirect(), which still calls
>to_vvq to get 'vq', let's directly pass 'vq'. It can avoid
>unnecessary call of to_vvq in hot path.
>
>Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>---
> drivers/virtio/virtio_ring.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>index 962f1477b1fa..d597fc0874ec 100644
>--- a/drivers/virtio/virtio_ring.c
>+++ b/drivers/virtio/virtio_ring.c
>@@ -205,11 +205,9 @@ struct vring_virtqueue {
>
> #define to_vvq(_vq) container_of(_vq, struct vring_virtqueue, vq)
>
>-static inline bool virtqueue_use_indirect(struct virtqueue *_vq,
>+static inline bool virtqueue_use_indirect(struct vring_virtqueue *vq,
> unsigned int total_sg)
> {
>- struct vring_virtqueue *vq = to_vvq(_vq);
>-
> /*
> * If the host supports indirect descriptor tables, and we have multiple
> * buffers, then go indirect. FIXME: tune this threshold
>@@ -507,7 +505,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
>
> head = vq->free_head;
>
>- if (virtqueue_use_indirect(_vq, total_sg))
>+ if (virtqueue_use_indirect(vq, total_sg))
> desc = alloc_indirect_split(_vq, total_sg, gfp);
> else {
> desc = NULL;
>@@ -1194,7 +1192,7 @@ static inline int virtqueue_add_packed(struct virtqueue *_vq,
>
> BUG_ON(total_sg == 0);
>
>- if (virtqueue_use_indirect(_vq, total_sg)) {
>+ if (virtqueue_use_indirect(vq, total_sg)) {
> err = virtqueue_add_indirect_packed(vq, sgs, total_sg, out_sgs,
> in_sgs, data, gfp);
> if (err != -ENOMEM) {
>--
>2.17.1
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path
@ 2022-03-29 7:49 ` Stefano Garzarella
0 siblings, 0 replies; 13+ messages in thread
From: Stefano Garzarella @ 2022-03-29 7:49 UTC (permalink / raw)
To: Xianting Tian; +Cc: mst, jasowang, virtualization, linux-kernel
On Mon, Mar 28, 2022 at 06:58:16PM +0800, Xianting Tian wrote:
>It passes '_vq' to virtqueue_use_indirect(), which still calls
>to_vvq to get 'vq', let's directly pass 'vq'. It can avoid
>unnecessary call of to_vvq in hot path.
>
>Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>---
> drivers/virtio/virtio_ring.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>index 962f1477b1fa..d597fc0874ec 100644
>--- a/drivers/virtio/virtio_ring.c
>+++ b/drivers/virtio/virtio_ring.c
>@@ -205,11 +205,9 @@ struct vring_virtqueue {
>
> #define to_vvq(_vq) container_of(_vq, struct vring_virtqueue, vq)
>
>-static inline bool virtqueue_use_indirect(struct virtqueue *_vq,
>+static inline bool virtqueue_use_indirect(struct vring_virtqueue *vq,
> unsigned int total_sg)
> {
>- struct vring_virtqueue *vq = to_vvq(_vq);
>-
> /*
> * If the host supports indirect descriptor tables, and we have multiple
> * buffers, then go indirect. FIXME: tune this threshold
>@@ -507,7 +505,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
>
> head = vq->free_head;
>
>- if (virtqueue_use_indirect(_vq, total_sg))
>+ if (virtqueue_use_indirect(vq, total_sg))
> desc = alloc_indirect_split(_vq, total_sg, gfp);
> else {
> desc = NULL;
>@@ -1194,7 +1192,7 @@ static inline int virtqueue_add_packed(struct virtqueue *_vq,
>
> BUG_ON(total_sg == 0);
>
>- if (virtqueue_use_indirect(_vq, total_sg)) {
>+ if (virtqueue_use_indirect(vq, total_sg)) {
> err = virtqueue_add_indirect_packed(vq, sgs, total_sg, out_sgs,
> in_sgs, data, gfp);
> if (err != -ENOMEM) {
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-04-04 22:08 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 10:58 [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path Xianting Tian
2022-03-28 10:58 ` [PATCH 2/2] virtio_ring: add unlikely annotation for free descs check Xianting Tian
2022-03-29 4:57 ` Jason Wang
2022-03-29 4:57 ` Jason Wang
2022-03-29 7:50 ` Stefano Garzarella
2022-03-29 7:50 ` Stefano Garzarella
2022-04-04 15:11 ` Xianting Tian
2022-04-04 16:27 ` Michael S. Tsirkin
2022-04-04 16:27 ` Michael S. Tsirkin
2022-03-29 4:56 ` [PATCH 1/2] virtio_ring: remove unnecessary to_vvq call in vring hot path Jason Wang
2022-03-29 4:56 ` Jason Wang
2022-03-29 7:49 ` Stefano Garzarella
2022-03-29 7:49 ` Stefano Garzarella
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.