From: Sascha Hauer <s.hauer@pengutronix.de> To: alsa-devel@alsa-project.org Cc: Xiubo Li <Xiubo.Lee@gmail.com>, Fabio Estevam <festevam@gmail.com>, Shengjiu Wang <shengjiu.wang@gmail.com>, kernel@pengutronix.de, Vinod Koul <vkoul@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, dmaengine@vger.kernel.org Subject: Re: [PATCH v2 11/19] ASoC: fsl_micfil: add multi fifo support Date: Wed, 30 Mar 2022 09:50:22 +0200 [thread overview] Message-ID: <20220330075022.GO22780@pengutronix.de> (raw) In-Reply-To: <20220328112744.1575631-12-s.hauer@pengutronix.de> On Mon, Mar 28, 2022 at 01:27:36PM +0200, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- This also lacks a commit message. Will add: The micfil hardware provides the microphone data on multiple successive FIFO registers, one register per stereo pair. Also to work properly the SDMA_DONE0_CONFIG_DONE_SEL bit in the SDMA engines SDMA_DONE0_CONFIG register must be set. This patch provides the necessary information to the SDMA engine driver. Sascha > sound/soc/fsl/fsl_micfil.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c > index ffca56d72562d..fe3e1319b35fd 100644 > --- a/sound/soc/fsl/fsl_micfil.c > +++ b/sound/soc/fsl/fsl_micfil.c > @@ -16,6 +16,7 @@ > #include <linux/regmap.h> > #include <linux/sysfs.h> > #include <linux/types.h> > +#include <linux/platform_data/dma-imx.h> > #include <sound/dmaengine_pcm.h> > #include <sound/pcm.h> > #include <sound/soc.h> > @@ -35,6 +36,7 @@ struct fsl_micfil { > struct clk *busclk; > struct clk *mclk; > struct snd_dmaengine_dai_dma_data dma_params_rx; > + struct sdma_peripheral_config sdmacfg; > unsigned int dataline; > char name[32]; > int irq[MICFIL_IRQ_LINES]; > @@ -324,6 +326,10 @@ static int fsl_micfil_hw_params(struct snd_pcm_substream *substream, > return ret; > } > > + micfil->dma_params_rx.peripheral_config = &micfil->sdmacfg; > + micfil->dma_params_rx.peripheral_size = sizeof(micfil->sdmacfg); > + micfil->sdmacfg.n_fifos_src = channels; > + micfil->sdmacfg.sw_done = true; > micfil->dma_params_rx.maxburst = channels * MICFIL_DMA_MAXBURST_RX; > > return 0; > -- > 2.30.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de> To: alsa-devel@alsa-project.org Cc: Xiubo Li <Xiubo.Lee@gmail.com>, Fabio Estevam <festevam@gmail.com>, Vinod Koul <vkoul@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, kernel@pengutronix.de, dmaengine@vger.kernel.org, Shengjiu Wang <shengjiu.wang@gmail.com> Subject: Re: [PATCH v2 11/19] ASoC: fsl_micfil: add multi fifo support Date: Wed, 30 Mar 2022 09:50:22 +0200 [thread overview] Message-ID: <20220330075022.GO22780@pengutronix.de> (raw) In-Reply-To: <20220328112744.1575631-12-s.hauer@pengutronix.de> On Mon, Mar 28, 2022 at 01:27:36PM +0200, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- This also lacks a commit message. Will add: The micfil hardware provides the microphone data on multiple successive FIFO registers, one register per stereo pair. Also to work properly the SDMA_DONE0_CONFIG_DONE_SEL bit in the SDMA engines SDMA_DONE0_CONFIG register must be set. This patch provides the necessary information to the SDMA engine driver. Sascha > sound/soc/fsl/fsl_micfil.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c > index ffca56d72562d..fe3e1319b35fd 100644 > --- a/sound/soc/fsl/fsl_micfil.c > +++ b/sound/soc/fsl/fsl_micfil.c > @@ -16,6 +16,7 @@ > #include <linux/regmap.h> > #include <linux/sysfs.h> > #include <linux/types.h> > +#include <linux/platform_data/dma-imx.h> > #include <sound/dmaengine_pcm.h> > #include <sound/pcm.h> > #include <sound/soc.h> > @@ -35,6 +36,7 @@ struct fsl_micfil { > struct clk *busclk; > struct clk *mclk; > struct snd_dmaengine_dai_dma_data dma_params_rx; > + struct sdma_peripheral_config sdmacfg; > unsigned int dataline; > char name[32]; > int irq[MICFIL_IRQ_LINES]; > @@ -324,6 +326,10 @@ static int fsl_micfil_hw_params(struct snd_pcm_substream *substream, > return ret; > } > > + micfil->dma_params_rx.peripheral_config = &micfil->sdmacfg; > + micfil->dma_params_rx.peripheral_size = sizeof(micfil->sdmacfg); > + micfil->sdmacfg.n_fifos_src = channels; > + micfil->sdmacfg.sw_done = true; > micfil->dma_params_rx.maxburst = channels * MICFIL_DMA_MAXBURST_RX; > > return 0; > -- > 2.30.2 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-03-30 7:50 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-28 11:27 [PATCH v2 00/19] ASoC: fsl_micfil: Driver updates Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 01/19] ASoC: fsl_micfil: Drop unnecessary register read Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 02/19] ASoC: fsl_micfil: Drop unused " Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 03/19] ASoC: fsl_micfil: drop fsl_micfil_set_mclk_rate() Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 04/19] ASoC: fsl_micfil: do not define SHIFT/MASK for single bits Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 05/19] ASoC: fsl_micfil: use GENMASK to define register bit fields Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-04-07 2:08 ` Shengjiu Wang 2022-04-07 7:38 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 06/19] ASoC: fsl_micfil: use clear/set bits Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 07/19] ASoC: fsl_micfil: drop error messages from failed register accesses Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 08/19] ASoC: fsl_micfil: drop unused variables Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 09/19] dma: imx-sdma: error out on unsupported transfer types Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 10/19] dma: imx-sdma: Add multi fifo support Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-29 10:55 ` Fabio Estevam 2022-03-29 10:55 ` Fabio Estevam 2022-03-30 7:49 ` Sascha Hauer 2022-03-30 7:49 ` Sascha Hauer 2022-03-31 5:26 ` Vinod Koul 2022-03-31 5:26 ` Vinod Koul 2022-03-31 6:49 ` Sascha Hauer 2022-03-31 6:49 ` Sascha Hauer 2022-03-31 6:54 ` Vinod Koul 2022-03-31 6:54 ` Vinod Koul 2022-03-31 7:58 ` Sascha Hauer 2022-03-31 7:58 ` Sascha Hauer 2022-04-07 7:22 ` Vinod Koul 2022-04-07 7:22 ` Vinod Koul 2022-04-01 12:01 ` Sascha Hauer 2022-04-01 12:01 ` Sascha Hauer 2022-04-07 7:23 ` Vinod Koul 2022-04-07 7:23 ` Vinod Koul 2022-04-07 7:41 ` Sascha Hauer 2022-04-07 7:41 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 11/19] ASoC: fsl_micfil: add " Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-30 7:50 ` Sascha Hauer [this message] 2022-03-30 7:50 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 12/19] ASoC: fsl_micfil: use define for OSR default value Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 13/19] ASoC: fsl_micfil: Drop get_pdm_clk() Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 14/19] ASoC: fsl_micfil: simplify clock setting Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 15/19] ASoC: fsl_micfil: rework quality setting Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 16/19] ASoC: fsl_micfil: drop unused include Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 17/19] ASoC: fsl_micfil: drop only once used defines Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 18/19] ASoC: fsl_micfil: drop support for undocumented property Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer 2022-03-28 11:27 ` [PATCH v2 19/19] ASoC: fsl_micfil: fold fsl_set_clock_params() into its only user Sascha Hauer 2022-03-28 11:27 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220330075022.GO22780@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=Xiubo.Lee@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-imx@nxp.com \ --cc=shengjiu.wang@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.