[meta-oe][PATCH v2 0/4] add idevicerestore support

[meta-oe][PATCH v2 0/4] add idevicerestore support

[Potin Lai]

This patch series adds idevicerestore package and dependent libraries.

LINK: [v1] https://lore.kernel.org/all/20220329024856.27349-1-potin.lai@quantatw.com/

Changes v1 --> v2:
- add patch for libimobiledevice-glue to fix undefined bswap error

Potin Lai (4):
  libimobiledevice-glue: add recipe
  libimobiledevice-glue: fix undefined bswap error
  libirecovery: add recipe
  idevicerestore: add recipe

 ...wap32-and-bswap64-errors-for-MIPS-ma.patch | 32 +++++++++++++++++++
 .../libimobiledevice-glue_git.bb              | 18 +++++++++++
 .../libirecovery/libirecovery_git.bb          | 15 +++++++++
 .../idevicerestore/idevicerestore_git.bb      | 15 +++++++++
 4 files changed, 80 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/libimobiledevice-glue/files/0001-fix-undefined-bswap32-and-bswap64-errors-for-MIPS-ma.patch
 create mode 100644 meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
 create mode 100644 meta-oe/recipes-connectivity/libirecovery/libirecovery_git.bb
 create mode 100644 meta-oe/recipes-support/idevicerestore/idevicerestore_git.bb

-- 
2.17.1

[meta-oe][PATCH v2 1/4] libimobiledevice-glue: add recipe

[Potin Lai]

libimobiledevice-glue is the library with common code used by the
libraries and tools around the libimobiledevice project.

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
 .../libimobiledevice-glue_git.bb                  | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb

diff --git a/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb b/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
new file mode 100644
index 000000000..28303d082
--- /dev/null
+++ b/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
@@ -0,0 +1,15 @@
+SUMMARY = "Library with common code used by the libraries and tools around the libimobiledevice project"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "\
+    file://COPYING;md5=6ab17b41640564434dda85c06b7124f7 \
+"
+
+HOMEPAGE = "http://www.libimobiledevice.org/"
+
+DEPENDS = "libplist"
+
+SRCREV = "ecb0996fd2a3b0539153dd3ef901d137bf498ffe"
+SRC_URI = "git://github.com/libimobiledevice/libimobiledevice-glue;protocol=https;branch=master"
+
+S = "${WORKDIR}/git"
+inherit autotools pkgconfig
-- 
2.17.1

[meta-oe][PATCH v2 2/4] libimobiledevice-glue: fix undefined bswap error

[Potin Lai]

Add patch for fixing undefiened bswap32 & bswap64 error on MIPS machine

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
 ...wap32-and-bswap64-errors-for-MIPS-ma.patch | 32 +++++++++++++++++++
 .../libimobiledevice-glue_git.bb              |  5 ++-
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 meta-oe/recipes-connectivity/libimobiledevice-glue/files/0001-fix-undefined-bswap32-and-bswap64-errors-for-MIPS-ma.patch

diff --git a/meta-oe/recipes-connectivity/libimobiledevice-glue/files/0001-fix-undefined-bswap32-and-bswap64-errors-for-MIPS-ma.patch b/meta-oe/recipes-connectivity/libimobiledevice-glue/files/0001-fix-undefined-bswap32-and-bswap64-errors-for-MIPS-ma.patch
new file mode 100644
index 000000000..cff37fb5d
--- /dev/null
+++ b/meta-oe/recipes-connectivity/libimobiledevice-glue/files/0001-fix-undefined-bswap32-and-bswap64-errors-for-MIPS-ma.patch
@@ -0,0 +1,32 @@
+From 73fcf0b54f4c1fc07a2aa003dddaeb5a97177cce Mon Sep 17 00:00:00 2001
+From: Potin Lai <potin.lai@quantatw.com>
+Date: Thu, 31 Mar 2022 08:44:31 +0800
+Subject: [PATCH 1/1] fix undefined bswap32 and bswap64 errors for MIPS machine
+
+Replace bswap32 and bswap64 with internal defined version (__bswap_X)
+
+Upstream Status: Submitted [libimobiledevice-devel@libimobiledevice.org]
+
+Signed-off-by: Potin Lai <potin.lai@quantatw.com>
+---
+ include/endianness.h | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/include/endianness.h b/include/endianness.h
+index 099877a..88b63db 100644
+--- a/include/endianness.h
++++ b/include/endianness.h
+@@ -113,8 +113,8 @@
+      && !defined(__FLOAT_WORD_ORDER__)) \
+  || (defined(__FLOAT_WORD_ORDER__) \
+      && __FLOAT_WORD_ORDER__ == __ORDER_BIG_ENDIAN__)
+-#define float_bswap64(x) bswap64(x)
+-#define float_bswap32(x) bswap32(x)
++#define float_bswap64(x) __bswap_64(x)
++#define float_bswap32(x) __bswap_32(x)
+ #else
+ #define float_bswap64(x) (x)
+ #define float_bswap32(x) (x)
+-- 
+2.17.1
+
diff --git a/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb b/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
index 28303d082..297a7d427 100644
--- a/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
+++ b/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
@@ -9,7 +9,10 @@ HOMEPAGE = "http://www.libimobiledevice.org/"
 DEPENDS = "libplist"
 
 SRCREV = "ecb0996fd2a3b0539153dd3ef901d137bf498ffe"
-SRC_URI = "git://github.com/libimobiledevice/libimobiledevice-glue;protocol=https;branch=master"
+SRC_URI = "\
+    git://github.com/libimobiledevice/libimobiledevice-glue;protocol=https;branch=master \
+    file://0001-fix-undefined-bswap32-and-bswap64-errors-for-MIPS-ma.patch \
+"
 
 S = "${WORKDIR}/git"
 inherit autotools pkgconfig
-- 
2.17.1

[meta-oe][PATCH v2 3/4] libirecovery: add recipe

[Potin Lai]

libirecovery is a cross-platform library which implements communication
to iBoot/iBSS found on Apple's iOS devices via USB.

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
 .../libirecovery/libirecovery_git.bb              | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta-oe/recipes-connectivity/libirecovery/libirecovery_git.bb

diff --git a/meta-oe/recipes-connectivity/libirecovery/libirecovery_git.bb b/meta-oe/recipes-connectivity/libirecovery/libirecovery_git.bb
new file mode 100644
index 000000000..30c633caf
--- /dev/null
+++ b/meta-oe/recipes-connectivity/libirecovery/libirecovery_git.bb
@@ -0,0 +1,15 @@
+SUMMARY = "The libirecovery library allows communication with iBoot/iBSS of iOS devices via USB"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "\
+    file://COPYING;md5=23c2a5e0106b99d75238986559bb5fc6 \
+"
+
+HOMEPAGE = "http://www.libimobiledevice.org/"
+
+DEPENDS = "libimobiledevice-glue libusb1"
+
+SRCREV = "e19094594552b7bed60418ffe6f46f455e6bb78f"
+SRC_URI = "git://github.com/libimobiledevice/libirecovery;protocol=https;branch=master"
+
+S = "${WORKDIR}/git"
+inherit autotools pkgconfig
-- 
2.17.1

[meta-oe][PATCH v2 4/4] idevicerestore: add recipe

[Potin Lai]

A command-line application to restore firmware files to iOS devices.

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
 .../idevicerestore/idevicerestore_git.bb          | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta-oe/recipes-support/idevicerestore/idevicerestore_git.bb

diff --git a/meta-oe/recipes-support/idevicerestore/idevicerestore_git.bb b/meta-oe/recipes-support/idevicerestore/idevicerestore_git.bb
new file mode 100644
index 000000000..8fedb6447
--- /dev/null
+++ b/meta-oe/recipes-support/idevicerestore/idevicerestore_git.bb
@@ -0,0 +1,15 @@
+SUMMARY = "A command-line application to restore firmware files to iOS devices"
+LICENSE = "LGPL-3.0"
+LIC_FILES_CHKSUM = "\
+    file://COPYING;md5=e6a600fd5e1d9cbde2d983680233ad02 \
+"
+
+HOMEPAGE = "http://www.libimobiledevice.org/"
+
+DEPENDS = "libirecovery libimobiledevice libzip curl"
+
+SRCREV = "280575bb95977241e240ed081a2602d68746443e"
+SRC_URI = "git://github.com/libimobiledevice/idevicerestore;protocol=https;branch=master"
+
+S = "${WORKDIR}/git"
+inherit autotools pkgconfig
-- 
2.17.1

Re: [meta-oe][PATCH v2 1/4] libimobiledevice-glue: add recipe

[Khem Raj]

On Wed, Mar 30, 2022 at 7:17 PM Potin Lai <potin.lai@quantatw.com> wrote:
>
> libimobiledevice-glue is the library with common code used by the
> libraries and tools around the libimobiledevice project.
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
>  .../libimobiledevice-glue_git.bb                  | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
>
> diff --git a/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb b/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
> new file mode 100644
> index 000000000..28303d082
> --- /dev/null
> +++ b/meta-oe/recipes-connectivity/libimobiledevice-glue/libimobiledevice-glue_git.bb
> @@ -0,0 +1,15 @@
> +SUMMARY = "Library with common code used by the libraries and tools around the libimobiledevice project"
> +LICENSE = "LGPL-2.1"

can we use SPDX notation here please this would be LGPL-2.1-or-later

> +LIC_FILES_CHKSUM = "\
> +    file://COPYING;md5=6ab17b41640564434dda85c06b7124f7 \
> +"
> +
> +HOMEPAGE = "http://www.libimobiledevice.org/"
> +
> +DEPENDS = "libplist"
> +
> +SRCREV = "ecb0996fd2a3b0539153dd3ef901d137bf498ffe"
> +SRC_URI = "git://github.com/libimobiledevice/libimobiledevice-glue;protocol=https;branch=master"
> +
> +S = "${WORKDIR}/git"
> +inherit autotools pkgconfig

I also set PV to something definitive I see that its using 1.0.0 in AC_INIT see
https://github.com/libimobiledevice/libimobiledevice-glue/blob/master/configure.ac#L5

so perhaps use

PV = "1.0.0+git${SRCPV}"

> --
> 2.17.1
>