* [Buildroot] [PATCH v2] package/libcamera-apps: fix X11 preview compile (conversion from Window to EGLNativeWindowType)
@ 2022-03-31 20:12 Peter Seiderer
2022-04-04 17:39 ` Arnout Vandecappelle
2022-04-07 19:54 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Peter Seiderer @ 2022-03-31 20:12 UTC (permalink / raw)
To: buildroot
- add 002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
Fixes:
.../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
| ^~~~~~~
| |
| Window {aka long unsigned int}
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
- add patch with proper type cast instead of '-fpermissive' compiler
command line option (suggested by Arnout Vandecappelle)
---
...preview-compile-conversion-from-Wind.patch | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
diff --git a/package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch b/package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
new file mode 100644
index 0000000000..cc9069aa86
--- /dev/null
+++ b/package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
@@ -0,0 +1,39 @@
+From 60715769cd5368a63b2bdc2e6d6bb6df0030a54d Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Thu, 31 Mar 2022 21:44:22 +0200
+Subject: [PATCH] preview: fix egl_preview compile (conversion from Window to
+ EGLNativeWindowType)
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes:
+
+ .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
+ 329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
+ | ^~~~~~~
+ | |
+ | Window {aka long unsigned int}
+
+[Upstream: https://github.com/raspberrypi/libcamera-apps/pull/283]
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ preview/egl_preview.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/preview/egl_preview.cpp b/preview/egl_preview.cpp
+index b936e57..593583d 100644
+--- a/preview/egl_preview.cpp
++++ b/preview/egl_preview.cpp
+@@ -326,7 +326,7 @@ void EglPreview::makeWindow(char const *name)
+ wm_delete_window_ = XInternAtom(display_, "WM_DELETE_WINDOW", False);
+ XSetWMProtocols(display_, window_, &wm_delete_window_, 1);
+
+- egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
++ egl_surface_ = eglCreateWindowSurface(egl_display_, config, reinterpret_cast<EGLNativeWindowType>(window_), NULL);
+ if (!egl_surface_)
+ throw std::runtime_error("eglCreateWindowSurface failed");
+
+--
+2.35.1
+
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libcamera-apps: fix X11 preview compile (conversion from Window to EGLNativeWindowType)
2022-03-31 20:12 [Buildroot] [PATCH v2] package/libcamera-apps: fix X11 preview compile (conversion from Window to EGLNativeWindowType) Peter Seiderer
@ 2022-04-04 17:39 ` Arnout Vandecappelle
2022-04-07 19:54 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2022-04-04 17:39 UTC (permalink / raw)
To: Peter Seiderer, buildroot
On 31/03/2022 22:12, Peter Seiderer wrote:
> - add 002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
>
> Fixes:
>
> .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
> 329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
> | ^~~~~~~
> | |
> | Window {aka long unsigned int}
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
> - add patch with proper type cast instead of '-fpermissive' compiler
> command line option (suggested by Arnout Vandecappelle)
Thanks for the work!
Applied to master, thanks.
Regards,
Arnout
> ---
> ...preview-compile-conversion-from-Wind.patch | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
>
> diff --git a/package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch b/package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
> new file mode 100644
> index 0000000000..cc9069aa86
> --- /dev/null
> +++ b/package/libcamera-apps/0002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
> @@ -0,0 +1,39 @@
> +From 60715769cd5368a63b2bdc2e6d6bb6df0030a54d Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Thu, 31 Mar 2022 21:44:22 +0200
> +Subject: [PATCH] preview: fix egl_preview compile (conversion from Window to
> + EGLNativeWindowType)
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Fixes:
> +
> + .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
> + 329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
> + | ^~~~~~~
> + | |
> + | Window {aka long unsigned int}
> +
> +[Upstream: https://github.com/raspberrypi/libcamera-apps/pull/283]
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + preview/egl_preview.cpp | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/preview/egl_preview.cpp b/preview/egl_preview.cpp
> +index b936e57..593583d 100644
> +--- a/preview/egl_preview.cpp
> ++++ b/preview/egl_preview.cpp
> +@@ -326,7 +326,7 @@ void EglPreview::makeWindow(char const *name)
> + wm_delete_window_ = XInternAtom(display_, "WM_DELETE_WINDOW", False);
> + XSetWMProtocols(display_, window_, &wm_delete_window_, 1);
> +
> +- egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
> ++ egl_surface_ = eglCreateWindowSurface(egl_display_, config, reinterpret_cast<EGLNativeWindowType>(window_), NULL);
> + if (!egl_surface_)
> + throw std::runtime_error("eglCreateWindowSurface failed");
> +
> +--
> +2.35.1
> +
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2] package/libcamera-apps: fix X11 preview compile (conversion from Window to EGLNativeWindowType)
2022-03-31 20:12 [Buildroot] [PATCH v2] package/libcamera-apps: fix X11 preview compile (conversion from Window to EGLNativeWindowType) Peter Seiderer
2022-04-04 17:39 ` Arnout Vandecappelle
@ 2022-04-07 19:54 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-04-07 19:54 UTC (permalink / raw)
To: Peter Seiderer; +Cc: buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> - add 002-preview-fix-egl_preview-compile-conversion-from-Wind.patch
> Fixes:
> .../build/libcamera-apps-2d1009e3badcc8047361ff81149ad6cba3b911b5/preview/egl_preview.cpp:329:69: error: invalid conversion from ‘Window’ {aka ‘long unsigned int’} to ‘EGLNativeWindowType’ {aka ‘fbdev_window*’} [-fpermissive]
> 329 | egl_surface_ = eglCreateWindowSurface(egl_display_, config, window_, NULL);
> | ^~~~~~~
> | |
> | Window
> | {aka long unsigned int}
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
> - add patch with proper type cast instead of '-fpermissive' compiler
> command line option (suggested by Arnout Vandecappelle)
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-07 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 20:12 [Buildroot] [PATCH v2] package/libcamera-apps: fix X11 preview compile (conversion from Window to EGLNativeWindowType) Peter Seiderer
2022-04-04 17:39 ` Arnout Vandecappelle
2022-04-07 19:54 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.