All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable
@ 2022-03-31 22:35 ` Jakob Koschel
  0 siblings, 0 replies; 4+ messages in thread
From: Jakob Koschel @ 2022-03-31 22:35 UTC (permalink / raw)
  To: Helge Deller
  Cc: linux-fbdev, dri-devel, linux-kernel, Mike Rapoport,
	Brian Johannesmeyer, Cristiano Giuffrida, Bos, H.J.,
	Jakob Koschel

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
---
 drivers/video/fbdev/mmp/core.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/core.c
index 154127256a2c..03707461eced 100644
--- a/drivers/video/fbdev/mmp/core.c
+++ b/drivers/video/fbdev/mmp/core.c
@@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
  */
 struct mmp_path *mmp_get_path(const char *name)
 {
-	struct mmp_path *path;
-	int found = 0;
+	struct mmp_path *path = NULL, *iter;
 
 	mutex_lock(&disp_lock);
-	list_for_each_entry(path, &path_list, node) {
-		if (!strcmp(name, path->name)) {
-			found = 1;
+	list_for_each_entry(iter, &path_list, node) {
+		if (!strcmp(name, iter->name)) {
+			path = iter;
 			break;
 		}
 	}
 	mutex_unlock(&disp_lock);
 
-	return found ? path : NULL;
+	return path;
 }
 EXPORT_SYMBOL_GPL(mmp_get_path);
 

base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable
@ 2022-03-31 22:35 ` Jakob Koschel
  0 siblings, 0 replies; 4+ messages in thread
From: Jakob Koschel @ 2022-03-31 22:35 UTC (permalink / raw)
  To: Helge Deller
  Cc: linux-fbdev, linux-kernel, dri-devel, Brian Johannesmeyer,
	Cristiano Giuffrida, Bos, H.J.,
	Mike Rapoport, Jakob Koschel

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
---
 drivers/video/fbdev/mmp/core.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/core.c
index 154127256a2c..03707461eced 100644
--- a/drivers/video/fbdev/mmp/core.c
+++ b/drivers/video/fbdev/mmp/core.c
@@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
  */
 struct mmp_path *mmp_get_path(const char *name)
 {
-	struct mmp_path *path;
-	int found = 0;
+	struct mmp_path *path = NULL, *iter;
 
 	mutex_lock(&disp_lock);
-	list_for_each_entry(path, &path_list, node) {
-		if (!strcmp(name, path->name)) {
-			found = 1;
+	list_for_each_entry(iter, &path_list, node) {
+		if (!strcmp(name, iter->name)) {
+			path = iter;
 			break;
 		}
 	}
 	mutex_unlock(&disp_lock);
 
-	return found ? path : NULL;
+	return path;
 }
 EXPORT_SYMBOL_GPL(mmp_get_path);
 

base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable
  2022-03-31 22:35 ` Jakob Koschel
@ 2022-04-12 20:06   ` Helge Deller
  -1 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2022-04-12 20:06 UTC (permalink / raw)
  To: Jakob Koschel
  Cc: linux-fbdev, linux-kernel, dri-devel, Brian Johannesmeyer,
	Cristiano Giuffrida, Bos, H.J.,
	Mike Rapoport

On 4/1/22 00:35, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/mmp/core.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/core.c
> index 154127256a2c..03707461eced 100644
> --- a/drivers/video/fbdev/mmp/core.c
> +++ b/drivers/video/fbdev/mmp/core.c
> @@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
>   */
>  struct mmp_path *mmp_get_path(const char *name)
>  {
> -	struct mmp_path *path;
> -	int found = 0;
> +	struct mmp_path *path = NULL, *iter;
>
>  	mutex_lock(&disp_lock);
> -	list_for_each_entry(path, &path_list, node) {
> -		if (!strcmp(name, path->name)) {
> -			found = 1;
> +	list_for_each_entry(iter, &path_list, node) {
> +		if (!strcmp(name, iter->name)) {
> +			path = iter;
>  			break;
>  		}
>  	}
>  	mutex_unlock(&disp_lock);
>
> -	return found ? path : NULL;
> +	return path;
>  }
>  EXPORT_SYMBOL_GPL(mmp_get_path);
>
>
> base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable
@ 2022-04-12 20:06   ` Helge Deller
  0 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2022-04-12 20:06 UTC (permalink / raw)
  To: Jakob Koschel
  Cc: linux-fbdev, dri-devel, linux-kernel, Mike Rapoport,
	Brian Johannesmeyer, Cristiano Giuffrida, Bos, H.J.

On 4/1/22 00:35, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/mmp/core.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/core.c
> index 154127256a2c..03707461eced 100644
> --- a/drivers/video/fbdev/mmp/core.c
> +++ b/drivers/video/fbdev/mmp/core.c
> @@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
>   */
>  struct mmp_path *mmp_get_path(const char *name)
>  {
> -	struct mmp_path *path;
> -	int found = 0;
> +	struct mmp_path *path = NULL, *iter;
>
>  	mutex_lock(&disp_lock);
> -	list_for_each_entry(path, &path_list, node) {
> -		if (!strcmp(name, path->name)) {
> -			found = 1;
> +	list_for_each_entry(iter, &path_list, node) {
> +		if (!strcmp(name, iter->name)) {
> +			path = iter;
>  			break;
>  		}
>  	}
>  	mutex_unlock(&disp_lock);
>
> -	return found ? path : NULL;
> +	return path;
>  }
>  EXPORT_SYMBOL_GPL(mmp_get_path);
>
>
> base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-12 20:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 22:35 [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable Jakob Koschel
2022-03-31 22:35 ` Jakob Koschel
2022-04-12 20:06 ` Helge Deller
2022-04-12 20:06   ` Helge Deller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.