[linux-next:master 14693/14948] mm/secretmem.c:173:31: sparse: sparse: symbol 'secretmem_iops' was not declared. Should it be static?

[linux-next:master 14693/14948] mm/secretmem.c:173:31: sparse: sparse: symbol 'secretmem_iops' was not declared. Should it be static?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   fdcbcd1348f4ef713668bae1b0fa9774e1811205
commit: 24209f2f4d623891c9a7541a24bcdeab22670821 [14693/14948] mm/secretmem: fix panic when growing a memfd_secret
config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220401/202204010033.oeIla4qb-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=24209f2f4d623891c9a7541a24bcdeab22670821
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 24209f2f4d623891c9a7541a24bcdeab22670821
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> mm/secretmem.c:173:31: sparse: sparse: symbol 'secretmem_iops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

[RFC PATCH linux-next] mm/secretmem: secretmem_iops can be static

[kernel test robot]

mm/secretmem.c:173:31: warning: symbol 'secretmem_iops' was not declared. Should it be static?

Fixes: 24209f2f4d62 ("mm/secretmem: fix panic when growing a memfd_secret")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 mm/secretmem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/secretmem.c b/mm/secretmem.c
index a83e98aa3a7b3..ddf45c0435be7 100644
--- a/mm/secretmem.c
+++ b/mm/secretmem.c
@@ -170,7 +170,7 @@ static int secretmem_setattr(struct user_namespace *mnt_userns,
 	return simple_setattr(mnt_userns, dentry, iattr);
 }
 
-const struct inode_operations secretmem_iops = {
+static const struct inode_operations secretmem_iops = {
 	.setattr = secretmem_setattr,
 };
 

Re: [RFC PATCH linux-next] mm/secretmem: secretmem_iops can be static

[Axel Rasmussen]

Thanks kernel test robot, it should indeed be static. I'll send a v2
with this fix.

On Thu, Mar 31, 2022 at 9:55 AM kernel test robot <lkp@intel.com> wrote:
>
> mm/secretmem.c:173:31: warning: symbol 'secretmem_iops' was not declared. Should it be static?
>
> Fixes: 24209f2f4d62 ("mm/secretmem: fix panic when growing a memfd_secret")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  mm/secretmem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index a83e98aa3a7b3..ddf45c0435be7 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -170,7 +170,7 @@ static int secretmem_setattr(struct user_namespace *mnt_userns,
>         return simple_setattr(mnt_userns, dentry, iattr);
>  }
>
> -const struct inode_operations secretmem_iops = {
> +static const struct inode_operations secretmem_iops = {
>         .setattr = secretmem_setattr,
>  };
>

Re: [RFC PATCH linux-next] mm/secretmem: secretmem_iops can be static

[Axel Rasmussen]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

Thanks kernel test robot, it should indeed be static. I'll send a v2
with this fix.

On Thu, Mar 31, 2022 at 9:55 AM kernel test robot <lkp@intel.com> wrote:
>
> mm/secretmem.c:173:31: warning: symbol 'secretmem_iops' was not declared. Should it be static?
>
> Fixes: 24209f2f4d62 ("mm/secretmem: fix panic when growing a memfd_secret")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>  mm/secretmem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index a83e98aa3a7b3..ddf45c0435be7 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -170,7 +170,7 @@ static int secretmem_setattr(struct user_namespace *mnt_userns,
>         return simple_setattr(mnt_userns, dentry, iattr);
>  }
>
> -const struct inode_operations secretmem_iops = {
> +static const struct inode_operations secretmem_iops = {
>         .setattr = secretmem_setattr,
>  };
>