From: Victor Toso <victortoso@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: jsnow@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 10/9] qapi: Fix calc-dirty-rate example
Date: Fri, 1 Apr 2022 13:00:29 +0200 [thread overview]
Message-ID: <20220401110029.b25kbjcldwnhzo2y@tapioca> (raw)
In-Reply-To: <20220401082028.3583296-1-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On Fri, Apr 01, 2022 at 10:20:28AM +0200, Markus Armbruster wrote:
> The example shows {"command": ...}, which is wrong. Fix it to
> {"execute": ...}.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/migration.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index f74777608a..27d7b28158 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1845,7 +1845,7 @@
> # Since: 5.2
> #
> # Example:
> -# {"command": "calc-dirty-rate", "arguments": {"calc-time": 1,
> +# {"execute": "calc-dirty-rate", "arguments": {"calc-time": 1,
> # 'sample-pages': 512} }
> #
> ##
> --
> 2.35.1
Reviewed-by: Victor Toso <victortoso@redhat.com>
Cheers,
Victor
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-01 11:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 19:06 [PATCH v1 0/9] Fix some qapi examples Victor Toso
2022-03-31 19:06 ` [PATCH v1 1/9] qapi: fix example of netdev_add command Victor Toso
2022-04-01 7:56 ` Markus Armbruster
2022-04-01 10:59 ` Victor Toso
2022-04-01 11:07 ` [PATCH v1.1 " Victor Toso
2022-04-04 6:14 ` Markus Armbruster
2022-04-04 8:27 ` Victor Toso
2022-03-31 19:06 ` [PATCH v1 2/9] qapi: fix examples: replay-break and replay-seek Victor Toso
2022-04-01 8:01 ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 3/9] qapi: fix example of query-named-block-nodes command Victor Toso
2022-04-01 8:02 ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 4/9] qapi: fix example of query-spice command Victor Toso
2022-04-01 8:03 ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 5/9] qapi: fix example of query-vnc command Victor Toso
2022-04-01 8:03 ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 6/9] qapi: fix example of query-colo-status command Victor Toso
2022-04-01 8:04 ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 7/9] qapi: fix example of trace-event-get-state command Victor Toso
2022-04-01 8:07 ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 8/9] qapi: fix example of query-cpus-fast command Victor Toso
2022-04-01 8:08 ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 9/9] qapi: fix example of query-memdev command Victor Toso
2022-04-01 8:09 ` Markus Armbruster
2022-04-01 8:20 ` [PATCH 10/9] qapi: Fix calc-dirty-rate example Markus Armbruster
2022-04-01 11:00 ` Victor Toso [this message]
2022-04-04 9:51 ` [PATCH v1 0/9] Fix some qapi examples Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401110029.b25kbjcldwnhzo2y@tapioca \
--to=victortoso@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.