All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Victor Toso <victortoso@redhat.com>
Cc: John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v1 1/9] qapi: fix example of netdev_add command
Date: Fri, 01 Apr 2022 09:56:40 +0200	[thread overview]
Message-ID: <87tubdb5jb.fsf@pond.sub.org> (raw)
In-Reply-To: <20220331190633.121077-2-victortoso@redhat.com> (Victor Toso's message of "Thu, 31 Mar 2022 21:06:25 +0200")

Victor Toso <victortoso@redhat.com> writes:

> Example output has the optional member @dnssearch as string type. It
> should be an array of strings instead. Fix it.
>
> For reference, see NetdevUserOptions.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  qapi/net.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/net.json b/qapi/net.json
> index 0d4578bd07..efc0bae170 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -51,7 +51,7 @@
>  #
>  # -> { "execute": "netdev_add",
>  #      "arguments": { "type": "user", "id": "netdev1",
> -#                     "dnssearch": "example.org" } }
> +#                     "dnssearch": [ "example.org" ] } }
>  # <- { "return": {} }
>  #
>  ##

Uh, @dnssearch is ['String']...  shouldn't this be something like

   #                     "dnssearch": [ { "str": "example.org" } ] } }

?



  reply	other threads:[~2022-04-01  8:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 19:06 [PATCH v1 0/9] Fix some qapi examples Victor Toso
2022-03-31 19:06 ` [PATCH v1 1/9] qapi: fix example of netdev_add command Victor Toso
2022-04-01  7:56   ` Markus Armbruster [this message]
2022-04-01 10:59     ` Victor Toso
2022-04-01 11:07   ` [PATCH v1.1 " Victor Toso
2022-04-04  6:14     ` Markus Armbruster
2022-04-04  8:27       ` Victor Toso
2022-03-31 19:06 ` [PATCH v1 2/9] qapi: fix examples: replay-break and replay-seek Victor Toso
2022-04-01  8:01   ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 3/9] qapi: fix example of query-named-block-nodes command Victor Toso
2022-04-01  8:02   ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 4/9] qapi: fix example of query-spice command Victor Toso
2022-04-01  8:03   ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 5/9] qapi: fix example of query-vnc command Victor Toso
2022-04-01  8:03   ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 6/9] qapi: fix example of query-colo-status command Victor Toso
2022-04-01  8:04   ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 7/9] qapi: fix example of trace-event-get-state command Victor Toso
2022-04-01  8:07   ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 8/9] qapi: fix example of query-cpus-fast command Victor Toso
2022-04-01  8:08   ` Markus Armbruster
2022-03-31 19:06 ` [PATCH v1 9/9] qapi: fix example of query-memdev command Victor Toso
2022-04-01  8:09   ` Markus Armbruster
2022-04-01  8:20 ` [PATCH 10/9] qapi: Fix calc-dirty-rate example Markus Armbruster
2022-04-01 11:00   ` Victor Toso
2022-04-04  9:51 ` [PATCH v1 0/9] Fix some qapi examples Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tubdb5jb.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=victortoso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.