* [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing
@ 2021-09-23 7:55 Francesco Dolcini
2021-09-23 11:36 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Francesco Dolcini @ 2021-09-23 7:55 UTC (permalink / raw)
To: u-boot
Cc: Francesco Dolcini, Fabio Estevam, NXP i.MX U-Boot Team,
Stefano Babic, Tom Rini
colibri-imx6ull ethernet device is fec2, while the optional secondary
ethernet is fec1, update the ethernet aliases in the .dts file so that
ethaddr is set to fec2 and eth1addr to fec1.
Without this change the ethernet interfaces have a different
mac address between Linux and U-Boot.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
arch/arm/dts/imx6ull-colibri.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/dts/imx6ull-colibri.dtsi b/arch/arm/dts/imx6ull-colibri.dtsi
index b7bf79f28c..104207be97 100644
--- a/arch/arm/dts/imx6ull-colibri.dtsi
+++ b/arch/arm/dts/imx6ull-colibri.dtsi
@@ -8,6 +8,12 @@
#include "imx6ull.dtsi"
/ {
+ /* Ethernet aliases to ensure correct MAC addresses */
+ aliases {
+ ethernet0 = &fec2;
+ ethernet1 = &fec1;
+ };
+
chosen {
stdout-path = &uart1;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2021-09-23 7:55 [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing Francesco Dolcini @ 2021-09-23 11:36 ` Tom Rini 2021-09-23 11:50 ` Francesco Dolcini 2022-02-04 17:55 ` Fabio Estevam 2022-04-01 14:28 ` Tom Rini 2 siblings, 1 reply; 13+ messages in thread From: Tom Rini @ 2021-09-23 11:36 UTC (permalink / raw) To: Francesco Dolcini Cc: u-boot, Fabio Estevam, NXP i.MX U-Boot Team, Stefano Babic [-- Attachment #1: Type: text/plain, Size: 1163 bytes --] On Thu, Sep 23, 2021 at 09:55:21AM +0200, Francesco Dolcini wrote: > colibri-imx6ull ethernet device is fec2, while the optional secondary > ethernet is fec1, update the ethernet aliases in the .dts file so that > ethaddr is set to fec2 and eth1addr to fec1. > > Without this change the ethernet interfaces have a different > mac address between Linux and U-Boot. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > arch/arm/dts/imx6ull-colibri.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/imx6ull-colibri.dtsi b/arch/arm/dts/imx6ull-colibri.dtsi > index b7bf79f28c..104207be97 100644 > --- a/arch/arm/dts/imx6ull-colibri.dtsi > +++ b/arch/arm/dts/imx6ull-colibri.dtsi > @@ -8,6 +8,12 @@ > #include "imx6ull.dtsi" > > / { > + /* Ethernet aliases to ensure correct MAC addresses */ > + aliases { > + ethernet0 = &fec2; > + ethernet1 = &fec1; > + }; > + > chosen { > stdout-path = &uart1; > }; The main dts* files aren't supposed to change between U-Boot and Linux. Is this re-syncing the file with current upstream then? Thanks. -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2021-09-23 11:36 ` Tom Rini @ 2021-09-23 11:50 ` Francesco Dolcini 2021-09-23 11:57 ` Tom Rini 0 siblings, 1 reply; 13+ messages in thread From: Francesco Dolcini @ 2021-09-23 11:50 UTC (permalink / raw) To: Tom Rini Cc: Francesco Dolcini, u-boot, Fabio Estevam, NXP i.MX U-Boot Team, Stefano Babic On Thu, Sep 23, 2021 at 07:36:34AM -0400, Tom Rini wrote: > On Thu, Sep 23, 2021 at 09:55:21AM +0200, Francesco Dolcini wrote: > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > ethaddr is set to fec2 and eth1addr to fec1. > > > > Without this change the ethernet interfaces have a different > > mac address between Linux and U-Boot. > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > --- > > > > arch/arm/dts/imx6ull-colibri.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/dts/imx6ull-colibri.dtsi b/arch/arm/dts/imx6ull-colibri.dtsi > > index b7bf79f28c..104207be97 100644 > > --- a/arch/arm/dts/imx6ull-colibri.dtsi > > +++ b/arch/arm/dts/imx6ull-colibri.dtsi > > @@ -8,6 +8,12 @@ > > #include "imx6ull.dtsi" > > > > / { > > + /* Ethernet aliases to ensure correct MAC addresses */ > > + aliases { > > + ethernet0 = &fec2; > > + ethernet1 = &fec1; > > + }; > > + > > chosen { > > stdout-path = &uart1; > > }; > > The main dts* files aren't supposed to change between U-Boot and Linux. > Is this re-syncing the file with current upstream then? Thanks. Currently they are out of sync, correct, and because of this difference on the ethernet aliases we have the situation in which the MAC address assigned to the ethernet interfaces is different between Linux an U-Boot. There are other differences that this patchset is not trying to address and that are not causing any known issues. Francesco ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2021-09-23 11:50 ` Francesco Dolcini @ 2021-09-23 11:57 ` Tom Rini 2022-02-04 17:41 ` Marcel Ziswiler 0 siblings, 1 reply; 13+ messages in thread From: Tom Rini @ 2021-09-23 11:57 UTC (permalink / raw) To: Francesco Dolcini Cc: u-boot, Fabio Estevam, NXP i.MX U-Boot Team, Stefano Babic [-- Attachment #1: Type: text/plain, Size: 1957 bytes --] On Thu, Sep 23, 2021 at 01:50:41PM +0200, Francesco Dolcini wrote: > On Thu, Sep 23, 2021 at 07:36:34AM -0400, Tom Rini wrote: > > On Thu, Sep 23, 2021 at 09:55:21AM +0200, Francesco Dolcini wrote: > > > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > > ethaddr is set to fec2 and eth1addr to fec1. > > > > > > Without this change the ethernet interfaces have a different > > > mac address between Linux and U-Boot. > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > --- > > > > > > arch/arm/dts/imx6ull-colibri.dtsi | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/arch/arm/dts/imx6ull-colibri.dtsi b/arch/arm/dts/imx6ull-colibri.dtsi > > > index b7bf79f28c..104207be97 100644 > > > --- a/arch/arm/dts/imx6ull-colibri.dtsi > > > +++ b/arch/arm/dts/imx6ull-colibri.dtsi > > > @@ -8,6 +8,12 @@ > > > #include "imx6ull.dtsi" > > > > > > / { > > > + /* Ethernet aliases to ensure correct MAC addresses */ > > > + aliases { > > > + ethernet0 = &fec2; > > > + ethernet1 = &fec1; > > > + }; > > > + > > > chosen { > > > stdout-path = &uart1; > > > }; > > > > The main dts* files aren't supposed to change between U-Boot and Linux. > > Is this re-syncing the file with current upstream then? Thanks. > > Currently they are out of sync, correct, and because of this difference on the > ethernet aliases we have the situation in which the MAC address assigned to the > ethernet interfaces is different between Linux an U-Boot. OK, we can take this now as an important bugfix. > There are other differences that this patchset is not trying to address and > that are not causing any known issues. Please plan to sync the trees up for the next merge window, they are not supposed to stay out of sync. Thanks. -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2021-09-23 11:57 ` Tom Rini @ 2022-02-04 17:41 ` Marcel Ziswiler 0 siblings, 0 replies; 13+ messages in thread From: Marcel Ziswiler @ 2022-02-04 17:41 UTC (permalink / raw) To: u-boot; +Cc: festevam, trini, uboot-imx, sbabic, Francesco Dolcini Hi guys On Thu, 2021-09-23 at 07:57 -0400, Tom Rini wrote: > On Thu, Sep 23, 2021 at 01:50:41PM +0200, Francesco Dolcini wrote: > > On Thu, Sep 23, 2021 at 07:36:34AM -0400, Tom Rini wrote: > > > On Thu, Sep 23, 2021 at 09:55:21AM +0200, Francesco Dolcini wrote: > > > > > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > > > ethaddr is set to fec2 and eth1addr to fec1. > > > > > > > > Without this change the ethernet interfaces have a different > > > > mac address between Linux and U-Boot. > > > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > --- > > > > > > > > arch/arm/dts/imx6ull-colibri.dtsi | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/arch/arm/dts/imx6ull-colibri.dtsi b/arch/arm/dts/imx6ull-colibri.dtsi > > > > index b7bf79f28c..104207be97 100644 > > > > --- a/arch/arm/dts/imx6ull-colibri.dtsi > > > > +++ b/arch/arm/dts/imx6ull-colibri.dtsi > > > > @@ -8,6 +8,12 @@ > > > > #include "imx6ull.dtsi" > > > > > > > > / { > > > > + /* Ethernet aliases to ensure correct MAC addresses */ > > > > + aliases { > > > > + ethernet0 = &fec2; > > > > + ethernet1 = &fec1; > > > > + }; > > > > + > > > > chosen { > > > > stdout-path = &uart1; > > > > }; > > > > > > The main dts* files aren't supposed to change between U-Boot and Linux. > > > Is this re-syncing the file with current upstream then? Thanks. > > > > Currently they are out of sync, correct, and because of this difference on the > > ethernet aliases we have the situation in which the MAC address assigned to the > > ethernet interfaces is different between Linux an U-Boot. > > OK, we can take this now as an important bugfix. Any progress in applying this patch? I just applied it again on today's master and it still cleanly applies. > > There are other differences that this patchset is not trying to address and > > that are not causing any known issues. > > Please plan to sync the trees up for the next merge window, they are not > supposed to stay out of sync. Thanks. Yes, we are in the process of doing that. Thanks! Cheers Marcel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2021-09-23 7:55 [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing Francesco Dolcini 2021-09-23 11:36 ` Tom Rini @ 2022-02-04 17:55 ` Fabio Estevam 2022-04-01 12:57 ` Marcel Ziswiler 2022-04-01 14:28 ` Tom Rini 2 siblings, 1 reply; 13+ messages in thread From: Fabio Estevam @ 2022-02-04 17:55 UTC (permalink / raw) To: Francesco Dolcini Cc: U-Boot-Denx, NXP i.MX U-Boot Team, Stefano Babic, Tom Rini On Thu, Sep 23, 2021 at 4:55 AM Francesco Dolcini <francesco.dolcini@toradex.com> wrote: > > colibri-imx6ull ethernet device is fec2, while the optional secondary > ethernet is fec1, update the ethernet aliases in the .dts file so that > ethaddr is set to fec2 and eth1addr to fec1. > > Without this change the ethernet interfaces have a different > mac address between Linux and U-Boot. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> Reviewed-by: Fabio Estevam <festevam@gmail.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2022-02-04 17:55 ` Fabio Estevam @ 2022-04-01 12:57 ` Marcel Ziswiler 2022-04-01 13:43 ` Tom Rini 0 siblings, 1 reply; 13+ messages in thread From: Marcel Ziswiler @ 2022-04-01 12:57 UTC (permalink / raw) To: festevam, Francesco Dolcini; +Cc: u-boot, uboot-imx, sbabic, trini May I inquire about the status of this one? Thanks! On Fri, 2022-02-04 at 14:55 -0300, Fabio Estevam wrote: > On Thu, Sep 23, 2021 at 4:55 AM Francesco Dolcini > <francesco.dolcini@toradex.com> wrote: > > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > ethaddr is set to fec2 and eth1addr to fec1. > > > > Without this change the ethernet interfaces have a different > > mac address between Linux and U-Boot. > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > Reviewed-by: Fabio Estevam <festevam@gmail.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2022-04-01 12:57 ` Marcel Ziswiler @ 2022-04-01 13:43 ` Tom Rini 2022-04-01 14:01 ` Marcel Ziswiler 0 siblings, 1 reply; 13+ messages in thread From: Tom Rini @ 2022-04-01 13:43 UTC (permalink / raw) To: Marcel Ziswiler; +Cc: festevam, Francesco Dolcini, u-boot, uboot-imx, sbabic [-- Attachment #1: Type: text/plain, Size: 812 bytes --] On Fri, Apr 01, 2022 at 12:57:40PM +0000, Marcel Ziswiler wrote: > May I inquire about the status of this one? Thanks! Should I take it for this release? > > On Fri, 2022-02-04 at 14:55 -0300, Fabio Estevam wrote: > > On Thu, Sep 23, 2021 at 4:55 AM Francesco Dolcini > > <francesco.dolcini@toradex.com> wrote: > > > > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > > ethaddr is set to fec2 and eth1addr to fec1. > > > > > > Without this change the ethernet interfaces have a different > > > mac address between Linux and U-Boot. > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Reviewed-by: Fabio Estevam <festevam@gmail.com> -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2022-04-01 13:43 ` Tom Rini @ 2022-04-01 14:01 ` Marcel Ziswiler 2022-04-01 14:02 ` Tom Rini 2022-04-01 14:04 ` Tom Rini 0 siblings, 2 replies; 13+ messages in thread From: Marcel Ziswiler @ 2022-04-01 14:01 UTC (permalink / raw) To: trini; +Cc: festevam, u-boot, uboot-imx, sbabic, Francesco Dolcini On Fri, 2022-04-01 at 09:43 -0400, Tom Rini wrote: > On Fri, Apr 01, 2022 at 12:57:40PM +0000, Marcel Ziswiler wrote: > > > May I inquire about the status of this one? Thanks! > > Should I take it for this release? Yes, please. Thanks! > > On Fri, 2022-02-04 at 14:55 -0300, Fabio Estevam wrote: > > > On Thu, Sep 23, 2021 at 4:55 AM Francesco Dolcini > > > <francesco.dolcini@toradex.com> wrote: > > > > > > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > > > ethaddr is set to fec2 and eth1addr to fec1. > > > > > > > > Without this change the ethernet interfaces have a different > > > > mac address between Linux and U-Boot. > > > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > Reviewed-by: Fabio Estevam <festevam@gmail.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2022-04-01 14:01 ` Marcel Ziswiler @ 2022-04-01 14:02 ` Tom Rini 2022-04-01 14:04 ` Tom Rini 1 sibling, 0 replies; 13+ messages in thread From: Tom Rini @ 2022-04-01 14:02 UTC (permalink / raw) To: Marcel Ziswiler; +Cc: festevam, u-boot, uboot-imx, sbabic, Francesco Dolcini [-- Attachment #1: Type: text/plain, Size: 1083 bytes --] On Fri, Apr 01, 2022 at 02:01:25PM +0000, Marcel Ziswiler wrote: > On Fri, 2022-04-01 at 09:43 -0400, Tom Rini wrote: > > On Fri, Apr 01, 2022 at 12:57:40PM +0000, Marcel Ziswiler wrote: > > > > > May I inquire about the status of this one? Thanks! > > > > Should I take it for this release? > > Yes, please. Thanks! Will do. Any other toradex platform fixes? > > > > On Fri, 2022-02-04 at 14:55 -0300, Fabio Estevam wrote: > > > > On Thu, Sep 23, 2021 at 4:55 AM Francesco Dolcini > > > > <francesco.dolcini@toradex.com> wrote: > > > > > > > > > > colibri-imx6ull ethernet device is fec2, while the optional secondary > > > > > ethernet is fec1, update the ethernet aliases in the .dts file so that > > > > > ethaddr is set to fec2 and eth1addr to fec1. > > > > > > > > > > Without this change the ethernet interfaces have a different > > > > > mac address between Linux and U-Boot. > > > > > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > Reviewed-by: Fabio Estevam <festevam@gmail.com> -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2022-04-01 14:01 ` Marcel Ziswiler 2022-04-01 14:02 ` Tom Rini @ 2022-04-01 14:04 ` Tom Rini 2022-04-01 14:05 ` Francesco Dolcini 1 sibling, 1 reply; 13+ messages in thread From: Tom Rini @ 2022-04-01 14:04 UTC (permalink / raw) To: Marcel Ziswiler; +Cc: festevam, u-boot, uboot-imx, sbabic, Francesco Dolcini [-- Attachment #1: Type: text/plain, Size: 468 bytes --] On Fri, Apr 01, 2022 at 02:01:25PM +0000, Marcel Ziswiler wrote: > On Fri, 2022-04-01 at 09:43 -0400, Tom Rini wrote: > > On Fri, Apr 01, 2022 at 12:57:40PM +0000, Marcel Ziswiler wrote: > > > > > May I inquire about the status of this one? Thanks! > > > > Should I take it for this release? > > Yes, please. Thanks! And, re-reading the whole thread in patchwork, I'm going to assume / hope for a full dts resync for the next merge window. -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2022-04-01 14:04 ` Tom Rini @ 2022-04-01 14:05 ` Francesco Dolcini 0 siblings, 0 replies; 13+ messages in thread From: Francesco Dolcini @ 2022-04-01 14:05 UTC (permalink / raw) To: Tom Rini Cc: Marcel Ziswiler, festevam, u-boot, uboot-imx, sbabic, Francesco Dolcini On Fri, Apr 01, 2022 at 10:04:04AM -0400, Tom Rini wrote: > On Fri, Apr 01, 2022 at 02:01:25PM +0000, Marcel Ziswiler wrote: > > On Fri, 2022-04-01 at 09:43 -0400, Tom Rini wrote: > > > On Fri, Apr 01, 2022 at 12:57:40PM +0000, Marcel Ziswiler wrote: > > > > > > > May I inquire about the status of this one? Thanks! > > > > > > Should I take it for this release? > > > > Yes, please. Thanks! > > And, re-reading the whole thread in patchwork, I'm going to assume / > hope for a full dts resync for the next merge window. We are in process to update the Linux kernel DTS files now, as soon as this is done we will do the sync. Doing it now would not make sense. Francesco ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing 2021-09-23 7:55 [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing Francesco Dolcini 2021-09-23 11:36 ` Tom Rini 2022-02-04 17:55 ` Fabio Estevam @ 2022-04-01 14:28 ` Tom Rini 2 siblings, 0 replies; 13+ messages in thread From: Tom Rini @ 2022-04-01 14:28 UTC (permalink / raw) To: Francesco Dolcini Cc: u-boot, Fabio Estevam, NXP i.MX U-Boot Team, Stefano Babic [-- Attachment #1: Type: text/plain, Size: 546 bytes --] On Thu, Sep 23, 2021 at 09:55:21AM +0200, Francesco Dolcini wrote: > colibri-imx6ull ethernet device is fec2, while the optional secondary > ethernet is fec1, update the ethernet aliases in the .dts file so that > ethaddr is set to fec2 and eth1addr to fec1. > > Without this change the ethernet interfaces have a different > mac address between Linux and U-Boot. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot/master, thanks! -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-04-01 14:28 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-09-23 7:55 [PATCH] ARM: dts: colibri-imx6ull: fix mac address passing Francesco Dolcini 2021-09-23 11:36 ` Tom Rini 2021-09-23 11:50 ` Francesco Dolcini 2021-09-23 11:57 ` Tom Rini 2022-02-04 17:41 ` Marcel Ziswiler 2022-02-04 17:55 ` Fabio Estevam 2022-04-01 12:57 ` Marcel Ziswiler 2022-04-01 13:43 ` Tom Rini 2022-04-01 14:01 ` Marcel Ziswiler 2022-04-01 14:02 ` Tom Rini 2022-04-01 14:04 ` Tom Rini 2022-04-01 14:05 ` Francesco Dolcini 2022-04-01 14:28 ` Tom Rini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.