[PATCH] ARM: imx: Enable instruction cache early on on i.MX8M

[PATCH] ARM: imx: Enable instruction cache early on on i.MX8M

[Marek Vasut]

Enable instruction cache early on to speed up the boot process on i.MX8M.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
---
 arch/arm/mach-imx/imx8m/soc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
index a41afc5b4f8..6fd4377f1c2 100644
--- a/arch/arm/mach-imx/imx8m/soc.c
+++ b/arch/arm/mach-imx/imx8m/soc.c
@@ -514,6 +514,9 @@ int arch_cpu_init_dm(void)
 int arch_cpu_init(void)
 {
 	struct ocotp_regs *ocotp = (struct ocotp_regs *)OCOTP_BASE_ADDR;
+
+	icache_enable();
+
 	/*
 	 * ROM might disable clock for SCTR,
 	 * enable the clock before timer_init.
-- 
2.35.1

Re: [PATCH] ARM: imx: Enable instruction cache early on on i.MX8M

[Stefano Babic]

Hi Marek,

On 03.04.22 23:24, Marek Vasut wrote:
> Enable instruction cache early on to speed up the boot process on i.MX8M.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>   arch/arm/mach-imx/imx8m/soc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
> index a41afc5b4f8..6fd4377f1c2 100644
> --- a/arch/arm/mach-imx/imx8m/soc.c
> +++ b/arch/arm/mach-imx/imx8m/soc.c
> @@ -514,6 +514,9 @@ int arch_cpu_init_dm(void)
>   int arch_cpu_init(void)
>   {
>   	struct ocotp_regs *ocotp = (struct ocotp_regs *)OCOTP_BASE_ADDR;
> +
> +	icache_enable();
> +
>   	/*
>   	 * ROM might disable clock for SCTR,
>   	 * enable the clock before timer_init.

This does not seem enough because many boards do not find icache_enable, 
for example imx8mp_rsb3720a1_4G (but there are many others). Can you 
check it and repost ? Thanks !


+====================================================
+aarch64-linux-ld.bfd: arch/arm/mach-imx/imx8m/soc.o: in function 
`arch_cpu_init':
+arch/arm/mach-imx/imx8m/soc.c:554: undefined reference to `icache_enable'
+make[2]: *** [scripts/Makefile.spl:512: spl/u-boot-spl] Error 1
+make[1]: *** [Makefile:2105: spl/u-boot-spl] Error 2
+make: *** [Makefile:177: sub-make] Error 2


Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================