* Re: [PATCH] dt-bindings: net: snps: remove duplicate name [not found] <CGME20220404022313epcms1p6767800dd9ff1f238f2ff0b560a495316@epcms1p6> @ 2022-04-04 2:23 ` Dong-Jin Yang 0 siblings, 0 replies; 6+ messages in thread From: Dong-Jin Yang @ 2022-04-04 2:23 UTC (permalink / raw) To: davem, kuba, pabeni, robh+dt, krzk+dt, netdev, devicetree, linux-kernel, Krzysztof Kozlowski, Dong-Jin Yang, Moon-Ki Jun > On 01/04/2022 05:08, 양동진 wrote: > snps,dwmac has duplicated name for loongson,ls2k-dwmac and > loongson,ls7a-dwmac. > > Your "From" name seems to be different than Signed-off-by. These should > be the same, so can you fix the commit author to be the same as SoB? > Sorry, my email client put "From" as local language. Let me resend it. >> >> Signed-off-by: Dongjin Yang <dj76.yang@samsung.com> > > Fixes: 68277749a013 ("dt-bindings: dwmac: Add bindings for new Loongson > SoC and bridge chip") > >> --- >> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index 2d5248f..36c85eb 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -53,20 +53,18 @@ properties: >> - allwinner,sun8i-r40-gmac >> - allwinner,sun8i-v3s-emac >> - allwinner,sun50i-a64-emac >> - - loongson,ls2k-dwmac >> - - loongson,ls7a-dwmac >> - amlogic,meson6-dwmac >> - amlogic,meson8b-dwmac >> - amlogic,meson8m2-dwmac >> - amlogic,meson-gxbb-dwmac >> - amlogic,meson-axg-dwmac >> - - loongson,ls2k-dwmac >> - - loongson,ls7a-dwmac >> - ingenic,jz4775-mac >> - ingenic,x1000-mac >> - ingenic,x1600-mac >> - ingenic,x1830-mac >> - ingenic,x2000-mac >> + - loongson,ls2k-dwmac >> + - loongson,ls7a-dwmac >> - rockchip,px30-gmac >> - rockchip,rk3128-gmac >> - rockchip,rk3228-gmac > > > Best regards, > Krzysztof Best regards, DongJin ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20220404022857epcms1p6e6af1a6a86569f339e50c318abde7d3c@epcms1p6>]
* [PATCH] dt-bindings: net: snps: remove duplicate name [not found] <CGME20220404022857epcms1p6e6af1a6a86569f339e50c318abde7d3c@epcms1p6> @ 2022-04-04 2:28 ` Dongjin Yang 2022-04-04 6:08 ` Krzysztof Kozlowski 2022-04-06 17:37 ` Rob Herring 0 siblings, 2 replies; 6+ messages in thread From: Dongjin Yang @ 2022-04-04 2:28 UTC (permalink / raw) To: davem, kuba, pabeni, robh+dt, krzk+dt, netdev, devicetree, linux-kernel, Krzysztof Kozlowski Cc: Moon-Ki Jun, Dongjin Yang snps,dwmac has duplicated name for loongson,ls2k-dwmac and loongson,ls7a-dwmac. Signed-off-by: Dongjin Yang <dj76.yang@samsung.com> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 2d5248f..36c85eb 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -53,20 +53,18 @@ properties: - allwinner,sun8i-r40-gmac - allwinner,sun8i-v3s-emac - allwinner,sun50i-a64-emac - - loongson,ls2k-dwmac - - loongson,ls7a-dwmac - amlogic,meson6-dwmac - amlogic,meson8b-dwmac - amlogic,meson8m2-dwmac - amlogic,meson-gxbb-dwmac - amlogic,meson-axg-dwmac - - loongson,ls2k-dwmac - - loongson,ls7a-dwmac - ingenic,jz4775-mac - ingenic,x1000-mac - ingenic,x1600-mac - ingenic,x1830-mac - ingenic,x2000-mac + - loongson,ls2k-dwmac + - loongson,ls7a-dwmac - rockchip,px30-gmac - rockchip,rk3128-gmac - rockchip,rk3228-gmac -- 2.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: snps: remove duplicate name 2022-04-04 2:28 ` Dongjin Yang @ 2022-04-04 6:08 ` Krzysztof Kozlowski 2022-04-06 17:37 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-04-04 6:08 UTC (permalink / raw) To: dj76.yang, davem, kuba, pabeni, robh+dt, krzk+dt, netdev, devicetree, linux-kernel Cc: Moon-Ki Jun On 04/04/2022 04:28, Dongjin Yang wrote: > snps,dwmac has duplicated name for loongson,ls2k-dwmac and > loongson,ls7a-dwmac. > > Signed-off-by: Dongjin Yang <dj76.yang@samsung.com> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) This is a v2, so please version in the subject + some changelog under ---. You missed my comment about fixes tag, please add it, do not ignore. Fixes: 68277749a013 ("dt-bindings: dwmac: Add bindings for new Loongson SoC and bridge chip") Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: snps: remove duplicate name 2022-04-04 2:28 ` Dongjin Yang 2022-04-04 6:08 ` Krzysztof Kozlowski @ 2022-04-06 17:37 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2022-04-06 17:37 UTC (permalink / raw) To: Dongjin Yang Cc: Moon-Ki Jun, krzk+dt, linux-kernel, davem, netdev, Krzysztof Kozlowski, pabeni, robh+dt, kuba, devicetree On Mon, 04 Apr 2022 11:28:57 +0900, Dongjin Yang wrote: > snps,dwmac has duplicated name for loongson,ls2k-dwmac and > loongson,ls7a-dwmac. > > Signed-off-by: Dongjin Yang <dj76.yang@samsung.com> > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Applied, thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20220401030847epcms1p8cf7a8e1d8cd7d325dacf30f78da36328@epcms1p8>]
* [PATCH] dt-bindings: net: snps: remove duplicate name [not found] <CGME20220401030847epcms1p8cf7a8e1d8cd7d325dacf30f78da36328@epcms1p8> @ 2022-04-01 3:08 ` 양동진 2022-04-01 7:48 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: 양동진 @ 2022-04-01 3:08 UTC (permalink / raw) To: davem, kuba, pabeni, robh+dt, krzk+dt Cc: netdev, devicetree, linux-kernel, 양동진, 전문기 snps,dwmac has duplicated name for loongson,ls2k-dwmac and loongson,ls7a-dwmac. Signed-off-by: Dongjin Yang <dj76.yang@samsung.com> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 2d5248f..36c85eb 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -53,20 +53,18 @@ properties: - allwinner,sun8i-r40-gmac - allwinner,sun8i-v3s-emac - allwinner,sun50i-a64-emac - - loongson,ls2k-dwmac - - loongson,ls7a-dwmac - amlogic,meson6-dwmac - amlogic,meson8b-dwmac - amlogic,meson8m2-dwmac - amlogic,meson-gxbb-dwmac - amlogic,meson-axg-dwmac - - loongson,ls2k-dwmac - - loongson,ls7a-dwmac - ingenic,jz4775-mac - ingenic,x1000-mac - ingenic,x1600-mac - ingenic,x1830-mac - ingenic,x2000-mac + - loongson,ls2k-dwmac + - loongson,ls7a-dwmac - rockchip,px30-gmac - rockchip,rk3128-gmac - rockchip,rk3228-gmac -- 2.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: net: snps: remove duplicate name 2022-04-01 3:08 ` 양동진 @ 2022-04-01 7:48 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-04-01 7:48 UTC (permalink / raw) To: dj76.yang, davem, kuba, pabeni, robh+dt, krzk+dt Cc: netdev, devicetree, linux-kernel, 전문기 On 01/04/2022 05:08, 양동진 wrote: > snps,dwmac has duplicated name for loongson,ls2k-dwmac and > loongson,ls7a-dwmac. Your "From" name seems to be different than Signed-off-by. These should be the same, so can you fix the commit author to be the same as SoB? > > Signed-off-by: Dongjin Yang <dj76.yang@samsung.com> Fixes: 68277749a013 ("dt-bindings: dwmac: Add bindings for new Loongson SoC and bridge chip") > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 2d5248f..36c85eb 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -53,20 +53,18 @@ properties: > - allwinner,sun8i-r40-gmac > - allwinner,sun8i-v3s-emac > - allwinner,sun50i-a64-emac > - - loongson,ls2k-dwmac > - - loongson,ls7a-dwmac > - amlogic,meson6-dwmac > - amlogic,meson8b-dwmac > - amlogic,meson8m2-dwmac > - amlogic,meson-gxbb-dwmac > - amlogic,meson-axg-dwmac > - - loongson,ls2k-dwmac > - - loongson,ls7a-dwmac > - ingenic,jz4775-mac > - ingenic,x1000-mac > - ingenic,x1600-mac > - ingenic,x1830-mac > - ingenic,x2000-mac > + - loongson,ls2k-dwmac > + - loongson,ls7a-dwmac > - rockchip,px30-gmac > - rockchip,rk3128-gmac > - rockchip,rk3228-gmac Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-06 19:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220404022313epcms1p6767800dd9ff1f238f2ff0b560a495316@epcms1p6>
2022-04-04 2:23 ` [PATCH] dt-bindings: net: snps: remove duplicate name Dong-Jin Yang
[not found] <CGME20220404022857epcms1p6e6af1a6a86569f339e50c318abde7d3c@epcms1p6>
2022-04-04 2:28 ` Dongjin Yang
2022-04-04 6:08 ` Krzysztof Kozlowski
2022-04-06 17:37 ` Rob Herring
[not found] <CGME20220401030847epcms1p8cf7a8e1d8cd7d325dacf30f78da36328@epcms1p8>
2022-04-01 3:08 ` 양동진
2022-04-01 7:48 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.