* [PATCH BlueZ 1/2] monitor: Add support for LE BIG Info Adverting Report
@ 2022-04-05 0:42 Luiz Augusto von Dentz
2022-04-05 0:42 ` [PATCH BlueZ 2/2] btdev: Add support for sending LE BIG Info Adv Reports Luiz Augusto von Dentz
2022-04-05 4:55 ` [BlueZ,1/2] monitor: Add support for LE BIG Info Adverting Report bluez.test.bot
0 siblings, 2 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2022-04-05 0:42 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds support for LE BIG Info Advertising Report.
---
monitor/bt.h | 17 +++++++++++++++++
monitor/packet.c | 23 +++++++++++++++++++++++
2 files changed, 40 insertions(+)
diff --git a/monitor/bt.h b/monitor/bt.h
index 704c70fba..e9f72de36 100644
--- a/monitor/bt.h
+++ b/monitor/bt.h
@@ -3653,6 +3653,23 @@ struct bt_hci_evt_le_req_peer_sca_complete {
uint8_t sca;
} __attribute__ ((packed));
+#define BT_HCI_EVT_LE_BIG_INFO_ADV_REPORT 0x22
+struct bt_hci_evt_le_big_info_adv_report {
+ uint16_t sync_handle;
+ uint8_t num_bis;
+ uint8_t nse;
+ uint16_t iso_interval;
+ uint8_t bn;
+ uint8_t pto;
+ uint8_t irc;
+ uint16_t max_pdu;
+ uint8_t sdu_interval[3];
+ uint16_t max_sdu;
+ uint8_t phy;
+ uint8_t framing;
+ uint8_t encryption;
+} __attribute__ ((packed));
+
#define BT_HCI_ERR_SUCCESS 0x00
#define BT_HCI_ERR_UNKNOWN_COMMAND 0x01
#define BT_HCI_ERR_UNKNOWN_CONN_ID 0x02
diff --git a/monitor/packet.c b/monitor/packet.c
index 1f04063d3..6ef2fba3b 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -10887,6 +10887,25 @@ static void le_req_sca_complete_evt(const void *data, uint8_t size)
print_sca(evt->sca);
}
+static void le_big_info_evt(const void *data, uint8_t size)
+{
+ const struct bt_hci_evt_le_big_info_adv_report *evt = data;
+
+ print_field("Sync Handle: 0x%4.4x", evt->sync_handle);
+ print_field("Number BIS: %u", evt->num_bis);
+ print_field("NSE: %u", evt->nse);
+ print_slot_125("ISO Interval", evt->iso_interval);
+ print_field("BN: %u", evt->bn);
+ print_field("PTO: %u", evt->bn);
+ print_field("IRC: %u", evt->irc);
+ print_field("Maximum PDU: %u", evt->max_pdu);
+ print_usec_interval("SDU Interval", evt->sdu_interval);
+ print_field("Maximum SDU: %u", evt->max_sdu);
+ print_le_phy("PHY", evt->phy);
+ print_framing(evt->framing);
+ print_field("Encryption: 0x%02x", evt->encryption);
+}
+
struct subevent_data {
uint8_t subevent;
const char *str;
@@ -11005,6 +11024,10 @@ static const struct subevent_data le_meta_event_table[] = {
le_req_sca_complete_evt,
sizeof(
struct bt_hci_evt_le_req_peer_sca_complete)},
+ { BT_HCI_EVT_LE_BIG_INFO_ADV_REPORT,
+ "LE Broadcast Isochronous Group Info Advertising Report",
+ le_big_info_evt,
+ sizeof(struct bt_hci_evt_le_big_info_adv_report) },
{ }
};
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH BlueZ 2/2] btdev: Add support for sending LE BIG Info Adv Reports
2022-04-05 0:42 [PATCH BlueZ 1/2] monitor: Add support for LE BIG Info Adverting Report Luiz Augusto von Dentz
@ 2022-04-05 0:42 ` Luiz Augusto von Dentz
2022-04-05 4:55 ` [BlueZ,1/2] monitor: Add support for LE BIG Info Adverting Report bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2022-04-05 0:42 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds support for sending LE BIG Info Adv Reports if LE Create BIG
has been called.
---
emulator/btdev.c | 40 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/emulator/btdev.c b/emulator/btdev.c
index 9dc7b1e90..2ee39ab0b 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -1139,7 +1139,8 @@ static struct btdev_conn *conn_add_bis(struct btdev *dev, uint16_t handle,
return conn;
}
-static struct btdev_conn *find_bis_index(struct btdev *remote, uint8_t index)
+static struct btdev_conn *find_bis_index(const struct btdev *remote,
+ uint8_t index)
{
struct btdev_conn *conn;
const struct queue_entry *entry;
@@ -5105,6 +5106,40 @@ static int cmd_set_pa_data(struct btdev *dev, const void *data,
return 0;
}
+static void send_biginfo(struct btdev *dev, const struct btdev *remote)
+{
+ struct bt_hci_evt_le_big_info_adv_report ev;
+ const struct btdev_conn *conn;
+ struct bt_hci_bis *bis;
+
+ conn = find_bis_index(remote, 0);
+ if (!conn)
+ return;
+
+ bis = conn->data;
+
+ memset(&ev, 0, sizeof(ev));
+ ev.sync_handle = cpu_to_le16(dev->le_pa_sync_handle);
+ ev.num_bis = 1;
+
+ while (find_bis_index(remote, ev.num_bis))
+ ev.num_bis++;
+
+ ev.nse = 0x01;
+ ev.iso_interval = bis->latency;
+ ev.bn = 0x01;
+ ev.pto = 0x00;
+ ev.irc = 0x01;
+ ev.max_pdu = bis->sdu;
+ memcpy(ev.sdu_interval, bis->sdu_interval, sizeof(ev.sdu_interval));
+ ev.max_sdu = bis->sdu;
+ ev.phy = bis->phy;
+ ev.framing = bis->framing;
+ ev.encryption = bis->encryption;
+
+ le_meta_event(dev, BT_HCI_EVT_LE_BIG_INFO_ADV_REPORT, &ev, sizeof(ev));
+}
+
static void send_pa(struct btdev *dev, const struct btdev *remote,
uint8_t offset)
{
@@ -5135,7 +5170,10 @@ static void send_pa(struct btdev *dev, const struct btdev *remote,
if (pdu.ev.data_status == 0x01) {
offset += pdu.ev.data_len;
send_pa(dev, remote, offset);
+ return;
}
+
+ send_biginfo(dev, remote);
}
static void le_pa_sync_estabilished(struct btdev *dev, struct btdev *remote,
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [BlueZ,1/2] monitor: Add support for LE BIG Info Adverting Report
2022-04-05 0:42 [PATCH BlueZ 1/2] monitor: Add support for LE BIG Info Adverting Report Luiz Augusto von Dentz
2022-04-05 0:42 ` [PATCH BlueZ 2/2] btdev: Add support for sending LE BIG Info Adv Reports Luiz Augusto von Dentz
@ 2022-04-05 4:55 ` bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-04-05 4:55 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=628953
---Test result---
Test Summary:
CheckPatch FAIL 3.02 seconds
GitLint PASS 2.09 seconds
Prep - Setup ELL PASS 51.63 seconds
Build - Prep PASS 0.77 seconds
Build - Configure PASS 10.29 seconds
Build - Make PASS 1483.78 seconds
Make Check PASS 13.09 seconds
Make Check w/Valgrind PASS 529.48 seconds
Make Distcheck PASS 275.18 seconds
Build w/ext ELL - Configure PASS 10.25 seconds
Build w/ext ELL - Make PASS 1465.21 seconds
Incremental Build with patchesPASS 3019.77 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,1/2] monitor: Add support for LE BIG Info Adverting Report
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#110: FILE: monitor/bt.h:3671:
+} __attribute__ ((packed));
/github/workspace/src/12800993.patch total: 0 errors, 1 warnings, 58 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12800993.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-05 4:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 0:42 [PATCH BlueZ 1/2] monitor: Add support for LE BIG Info Adverting Report Luiz Augusto von Dentz
2022-04-05 0:42 ` [PATCH BlueZ 2/2] btdev: Add support for sending LE BIG Info Adv Reports Luiz Augusto von Dentz
2022-04-05 4:55 ` [BlueZ,1/2] monitor: Add support for LE BIG Info Adverting Report bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.