All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/intel-ci/fast-feedback: Move gem_lmem_swapping
@ 2022-04-05 21:19 Lucas De Marchi
  2022-04-05 22:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
  2022-04-06  7:36 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
  0 siblings, 2 replies; 4+ messages in thread
From: Lucas De Marchi @ 2022-04-05 21:19 UTC (permalink / raw)
  To: igt-dev; +Cc: thomas.hellstrom, Lucas De Marchi, petri.latvala, nirmoy.das

Since commit 37ec3b8ffd2c ("tests/gem_lmem_swapping: limit lmem to 4G")
we load the driver with limited 4GB of lmem for test execution. However
this means we also have to 1) reload the driver with that param set and
2) unload it after we are done. However tests/intel-ci/fast-feedback.testlist
has a dedicated section for tests that rely on module (un|re)loading so
not to impact other tests.

Move all gem_lmem_swapping to that section, after the coment:

	# All tests that do module unloading and reloading are executed last.
	# They will sometimes reveal issues of earlier tests leaving the
	# driver in a broken state that is not otherwise noticed in that test.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index c1014558..e24d2fa4 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -34,10 +34,6 @@ igt@gem_flink_basic@double-flink
 igt@gem_flink_basic@flink-lifetime
 igt@gem_huc_copy@huc-copy
 igt@gem_linear_blits@basic
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
 igt@gem_mmap@basic
 igt@gem_mmap_gtt@basic
 igt@gem_render_linear_blits@basic
@@ -170,6 +166,10 @@ igt@vgem_basic@sysfs
 # They will sometimes reveal issues of earlier tests leaving the
 # driver in a broken state that is not otherwise noticed in that test.
 
+igt@gem_lmem_swapping@basic
+igt@gem_lmem_swapping@parallel-random-engines
+igt@gem_lmem_swapping@random-engines
+igt@gem_lmem_swapping@verify-random
 igt@core_hotunplug@unbind-rebind
 igt@vgem_basic@unload
 igt@i915_module_load@reload
-- 
2.35.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for tests/intel-ci/fast-feedback: Move gem_lmem_swapping
  2022-04-05 21:19 [igt-dev] [PATCH i-g-t] tests/intel-ci/fast-feedback: Move gem_lmem_swapping Lucas De Marchi
@ 2022-04-05 22:17 ` Patchwork
  2022-04-06  7:36 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-04-05 22:17 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 11715 bytes --]

== Series Details ==

Series: tests/intel-ci/fast-feedback: Move gem_lmem_swapping
URL   : https://patchwork.freedesktop.org/series/102225/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6411 -> IGTPW_6880
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6880 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6880, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/index.html

Participating hosts (37 -> 34)
------------------------------

  Missing    (3): fi-bxt-dsi fi-bsw-cyan fi-bdw-samus 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6880:

### IGT changes ###

#### Possible regressions ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-rkl-guc:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-rkl-guc/igt@core_hotunplug@unbind-rebind.html
    - fi-bsw-n3050:       [PASS][3] -> [DMESG-WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-bsw-n3050/igt@core_hotunplug@unbind-rebind.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-bsw-n3050/igt@core_hotunplug@unbind-rebind.html
    - fi-tgl-1115g4:      [PASS][5] -> [DMESG-WARN][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-tgl-1115g4/igt@core_hotunplug@unbind-rebind.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-tgl-1115g4/igt@core_hotunplug@unbind-rebind.html
    - fi-adl-ddr5:        [PASS][7] -> [DMESG-WARN][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-adl-ddr5/igt@core_hotunplug@unbind-rebind.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-adl-ddr5/igt@core_hotunplug@unbind-rebind.html
    - fi-bsw-nick:        [PASS][9] -> [DMESG-WARN][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-bsw-nick/igt@core_hotunplug@unbind-rebind.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-bsw-nick/igt@core_hotunplug@unbind-rebind.html
    - fi-kbl-7567u:       [PASS][11] -> [DMESG-WARN][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-kbl-7567u/igt@core_hotunplug@unbind-rebind.html
    - fi-bsw-kefka:       [PASS][13] -> [DMESG-WARN][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-bsw-kefka/igt@core_hotunplug@unbind-rebind.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-bsw-kefka/igt@core_hotunplug@unbind-rebind.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@core_hotunplug@unbind-rebind:
    - {fi-ehl-2}:         [PASS][15] -> [DMESG-WARN][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-ehl-2/igt@core_hotunplug@unbind-rebind.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-ehl-2/igt@core_hotunplug@unbind-rebind.html
    - {fi-jsl-1}:         [PASS][17] -> [DMESG-WARN][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-jsl-1/igt@core_hotunplug@unbind-rebind.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-jsl-1/igt@core_hotunplug@unbind-rebind.html

  
Known issues
------------

  Here are the changes found in IGTPW_6880 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-skl-6700k2:      [PASS][19] -> [DMESG-WARN][20] ([i915#5437])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-skl-6700k2/igt@core_hotunplug@unbind-rebind.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-skl-6700k2/igt@core_hotunplug@unbind-rebind.html
    - fi-cfl-guc:         [PASS][21] -> [DMESG-WARN][22] ([i915#5437])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-cfl-guc/igt@core_hotunplug@unbind-rebind.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-cfl-guc/igt@core_hotunplug@unbind-rebind.html
    - fi-kbl-soraka:      [PASS][23] -> [DMESG-WARN][24] ([i915#1982] / [i915#5437])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-kbl-soraka/igt@core_hotunplug@unbind-rebind.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-kbl-soraka/igt@core_hotunplug@unbind-rebind.html
    - fi-cfl-8700k:       [PASS][25] -> [DMESG-WARN][26] ([i915#5437])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-cfl-8700k/igt@core_hotunplug@unbind-rebind.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-cfl-8700k/igt@core_hotunplug@unbind-rebind.html
    - fi-glk-j4005:       [PASS][27] -> [DMESG-WARN][28] ([i915#5437])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-glk-j4005/igt@core_hotunplug@unbind-rebind.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-glk-j4005/igt@core_hotunplug@unbind-rebind.html
    - fi-kbl-7500u:       [PASS][29] -> [DMESG-WARN][30] ([i915#5437])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html
    - fi-cfl-8109u:       [PASS][31] -> [DMESG-WARN][32] ([i915#5437])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-cfl-8109u/igt@core_hotunplug@unbind-rebind.html
    - fi-skl-guc:         [PASS][33] -> [DMESG-WARN][34] ([i915#5437])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-skl-guc/igt@core_hotunplug@unbind-rebind.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-skl-guc/igt@core_hotunplug@unbind-rebind.html

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-rkl-11600:       [PASS][35] -> [INCOMPLETE][36] ([i915#5127])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@hangcheck:
    - fi-hsw-4770:        [PASS][37] -> [INCOMPLETE][38] ([i915#4785])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html

  * igt@kms_flip@basic-flip-vs-dpms@a-edp1:
    - fi-tgl-u2:          [PASS][39] -> [DMESG-WARN][40] ([i915#402])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-tgl-u2/igt@kms_flip@basic-flip-vs-dpms@a-edp1.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-tgl-u2/igt@kms_flip@basic-flip-vs-dpms@a-edp1.html

  * igt@runner@aborted:
    - fi-bsw-kefka:       NOTRUN -> [FAIL][41] ([i915#4312])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-bsw-kefka/igt@runner@aborted.html
    - fi-cfl-8700k:       NOTRUN -> [FAIL][42] ([i915#4312] / [i915#5257])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-cfl-8700k/igt@runner@aborted.html
    - fi-cfl-8109u:       NOTRUN -> [FAIL][43] ([i915#4312] / [i915#5257])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-cfl-8109u/igt@runner@aborted.html
    - fi-bsw-nick:        NOTRUN -> [FAIL][44] ([i915#4312])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-bsw-nick/igt@runner@aborted.html
    - fi-kbl-soraka:      NOTRUN -> [FAIL][45] ([i915#4312] / [i915#5257])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-kbl-soraka/igt@runner@aborted.html
    - fi-hsw-4770:        NOTRUN -> [FAIL][46] ([fdo#109271] / [i915#2722] / [i915#4312])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-hsw-4770/igt@runner@aborted.html
    - fi-kbl-7500u:       NOTRUN -> [FAIL][47] ([i915#4312] / [i915#5257])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-kbl-7500u/igt@runner@aborted.html
    - fi-rkl-guc:         NOTRUN -> [FAIL][48] ([i915#4312])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-rkl-guc/igt@runner@aborted.html
    - fi-adl-ddr5:        NOTRUN -> [FAIL][49] ([i915#4312])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-adl-ddr5/igt@runner@aborted.html
    - fi-tgl-1115g4:      NOTRUN -> [FAIL][50] ([i915#4312] / [i915#5257])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-tgl-1115g4/igt@runner@aborted.html
    - fi-cfl-guc:         NOTRUN -> [FAIL][51] ([i915#4312] / [i915#5257])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-cfl-guc/igt@runner@aborted.html
    - fi-glk-j4005:       NOTRUN -> [FAIL][52] ([i915#4312] / [i915#5257] / [k.org#202321])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-glk-j4005/igt@runner@aborted.html
    - fi-kbl-7567u:       NOTRUN -> [FAIL][53] ([i915#4312] / [i915#5257])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-kbl-7567u/igt@runner@aborted.html
    - fi-skl-guc:         NOTRUN -> [FAIL][54] ([i915#4312] / [i915#5257])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-skl-guc/igt@runner@aborted.html
    - fi-skl-6700k2:      NOTRUN -> [FAIL][55] ([i915#4312] / [i915#5257])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-skl-6700k2/igt@runner@aborted.html
    - fi-bsw-n3050:       NOTRUN -> [FAIL][56] ([i915#4312])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-bsw-n3050/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@i915_pm_rps@basic-api:
    - {fi-jsl-1}:         [DMESG-WARN][57] ([i915#5482]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6411/fi-jsl-1/igt@i915_pm_rps@basic-api.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/fi-jsl-1/igt@i915_pm_rps@basic-api.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
  [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
  [i915#5437]: https://gitlab.freedesktop.org/drm/intel/issues/5437
  [i915#5482]: https://gitlab.freedesktop.org/drm/intel/issues/5482
  [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6411 -> IGTPW_6880

  CI-20190529: 20190529
  CI_DRM_11458: 7b4967c734a7c99ff69154d062a071181021e49d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6880: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/index.html
  IGT_6411: 987678ecf2d6930981af93f719e4575c91886959 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6880/index.html

[-- Attachment #2: Type: text/html, Size: 14972 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/intel-ci/fast-feedback: Move gem_lmem_swapping
  2022-04-05 21:19 [igt-dev] [PATCH i-g-t] tests/intel-ci/fast-feedback: Move gem_lmem_swapping Lucas De Marchi
  2022-04-05 22:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2022-04-06  7:36 ` Petri Latvala
  2022-04-06 14:40   ` Lucas De Marchi
  1 sibling, 1 reply; 4+ messages in thread
From: Petri Latvala @ 2022-04-06  7:36 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: igt-dev, thomas.hellstrom, nirmoy.das

On Tue, Apr 05, 2022 at 02:19:13PM -0700, Lucas De Marchi wrote:
> Since commit 37ec3b8ffd2c ("tests/gem_lmem_swapping: limit lmem to 4G")
> we load the driver with limited 4GB of lmem for test execution. However
> this means we also have to 1) reload the driver with that param set and
> 2) unload it after we are done. However tests/intel-ci/fast-feedback.testlist
> has a dedicated section for tests that rely on module (un|re)loading so
> not to impact other tests.
> 
> Move all gem_lmem_swapping to that section, after the coment:
> 
> 	# All tests that do module unloading and reloading are executed last.
> 	# They will sometimes reveal issues of earlier tests leaving the
> 	# driver in a broken state that is not otherwise noticed in that test.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Damn, I missed this when reviewing.

Acked-by: Petri Latvala <petri.latvala@intel.com>

> ---
>  tests/intel-ci/fast-feedback.testlist | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index c1014558..e24d2fa4 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -34,10 +34,6 @@ igt@gem_flink_basic@double-flink
>  igt@gem_flink_basic@flink-lifetime
>  igt@gem_huc_copy@huc-copy
>  igt@gem_linear_blits@basic
> -igt@gem_lmem_swapping@basic
> -igt@gem_lmem_swapping@parallel-random-engines
> -igt@gem_lmem_swapping@random-engines
> -igt@gem_lmem_swapping@verify-random
>  igt@gem_mmap@basic
>  igt@gem_mmap_gtt@basic
>  igt@gem_render_linear_blits@basic
> @@ -170,6 +166,10 @@ igt@vgem_basic@sysfs
>  # They will sometimes reveal issues of earlier tests leaving the
>  # driver in a broken state that is not otherwise noticed in that test.
>  
> +igt@gem_lmem_swapping@basic
> +igt@gem_lmem_swapping@parallel-random-engines
> +igt@gem_lmem_swapping@random-engines
> +igt@gem_lmem_swapping@verify-random
>  igt@core_hotunplug@unbind-rebind
>  igt@vgem_basic@unload
>  igt@i915_module_load@reload
> -- 
> 2.35.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/intel-ci/fast-feedback: Move gem_lmem_swapping
  2022-04-06  7:36 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2022-04-06 14:40   ` Lucas De Marchi
  0 siblings, 0 replies; 4+ messages in thread
From: Lucas De Marchi @ 2022-04-06 14:40 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev, thomas.hellstrom, nirmoy.das

On Wed, Apr 06, 2022 at 10:36:08AM +0300, Petri Latvala wrote:
>On Tue, Apr 05, 2022 at 02:19:13PM -0700, Lucas De Marchi wrote:
>> Since commit 37ec3b8ffd2c ("tests/gem_lmem_swapping: limit lmem to 4G")
>> we load the driver with limited 4GB of lmem for test execution. However
>> this means we also have to 1) reload the driver with that param set and
>> 2) unload it after we are done. However tests/intel-ci/fast-feedback.testlist
>> has a dedicated section for tests that rely on module (un|re)loading so
>> not to impact other tests.
>>
>> Move all gem_lmem_swapping to that section, after the coment:
>>
>> 	# All tests that do module unloading and reloading are executed last.
>> 	# They will sometimes reveal issues of earlier tests leaving the
>> 	# driver in a broken state that is not otherwise noticed in that test.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Damn, I missed this when reviewing.
>
>Acked-by: Petri Latvala <petri.latvala@intel.com>

thanks, pushed.

Lucas De Marchi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-06 14:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 21:19 [igt-dev] [PATCH i-g-t] tests/intel-ci/fast-feedback: Move gem_lmem_swapping Lucas De Marchi
2022-04-05 22:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2022-04-06  7:36 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2022-04-06 14:40   ` Lucas De Marchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.