All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-ti][dunfell][PATCH] Rename the am62xx-evm platform to am62xx-sk
@ 2022-04-05 17:04 Ryan Eatmon
  2022-04-05 17:36 ` Nishanth Menon
  0 siblings, 1 reply; 3+ messages in thread
From: Ryan Eatmon @ 2022-04-05 17:04 UTC (permalink / raw)
  To: Yogesh Siraswar, Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 10 +++++-----
 recipes-bsp/u-boot/u-boot-ti.inc       |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
index 099473b4..8ff822bf 100644
--- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
+++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
@@ -6,7 +6,7 @@ DEPENDS_append_j7200-hs-evm-k3r5 = " virtual/bootloader"
 DEPENDS_append_j721s2-evm-k3r5 = " virtual/bootloader"
 DEPENDS_append_am64xx-evm-k3r5 = " virtual/bootloader"
 DEPENDS_append_am64xx-hs-evm-k3r5 = " virtual/bootloader"
-DEPENDS_append_am62xx-evm-k3r5 = " virtual/bootloader"
+DEPENDS_append_am62xx-sk-k3r5 = " virtual/bootloader"
 
 CLEANBROKEN = "1"
 PR = "${INC_PR}.2"
@@ -30,7 +30,7 @@ SYSFW_PREFIX_j7-hs-evm-k3r5-sr1-1 = "ti-fs-firmware"
 SYSFW_PREFIX_j7200-evm-k3r5 = "ti-fs-firmware"
 SYSFW_PREFIX_j7200-hs-evm-k3r5 = "ti-fs-firmware"
 SYSFW_PREFIX_j721s2-evm-k3r5 = "ti-fs-firmware"
-SYSFW_PREFIX_am62xx-evm-k3r5 = "ti-fs-firmware"
+SYSFW_PREFIX_am62xx-sk-k3r5 = "ti-fs-firmware"
 
 SYSFW_SUFFIX ?= "unknown"
 
@@ -65,7 +65,7 @@ EXTRA_OEMAKE_append_j7200-hs-evm-k3r5 = " SBL="${STAGING_DIR_HOST}/boot/u-boot-s
 EXTRA_OEMAKE_append_j721s2-evm-k3r5 = " SBL="${STAGING_DIR_HOST}/boot/u-boot-spl.bin""
 EXTRA_OEMAKE_append_am64xx-evm-k3r5 = " SBL="${STAGING_DIR_HOST}/boot/u-boot-spl.bin""
 EXTRA_OEMAKE_append_am64xx-hs-evm-k3r5 = " SBL="${STAGING_DIR_HOST}/boot/u-boot-spl.bin""
-EXTRA_OEMAKE_append_am62xx-evm-k3r5 = " SBL="${STAGING_DIR_HOST}/boot/u-boot-spl.bin""
+EXTRA_OEMAKE_append_am62xx-sk-k3r5 = " SBL="${STAGING_DIR_HOST}/boot/u-boot-spl.bin""
 
 do_compile() {
 	cd ${WORKDIR}/imggen/
@@ -173,14 +173,14 @@ do_deploy_am64xx-hs-evm-k3r5() {
         install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/
 }
 
-do_install_am62xx-evm-k3r5() {
+do_install_am62xx-sk-k3r5() {
 	install -d ${D}/boot
 	install -m 644 ${WORKDIR}/imggen/${UBOOT_BINARY} ${D}/boot/${UBOOT_IMAGE}
 	ln -sf ${UBOOT_IMAGE} ${D}/boot/${UBOOT_SYMLINK}
 	ln -sf ${UBOOT_IMAGE} ${D}/boot/${UBOOT_BINARY}
 }
 
-do_deploy_am62xx-evm-k3r5() {
+do_deploy_am62xx-sk-k3r5() {
 	install -d ${DEPLOYDIR}
 	install -m 644 ${WORKDIR}/imggen/${UBOOT_BINARY} ${DEPLOYDIR}/${UBOOT_IMAGE}
 	ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK}
diff --git a/recipes-bsp/u-boot/u-boot-ti.inc b/recipes-bsp/u-boot/u-boot-ti.inc
index 231b7647..c9a11045 100644
--- a/recipes-bsp/u-boot/u-boot-ti.inc
+++ b/recipes-bsp/u-boot/u-boot-ti.inc
@@ -70,7 +70,7 @@ SPL_UART_BINARY_j7200-hs-evm-k3r5 = "u-boot-spl.bin"
 SPL_UART_BINARY_j721s2-evm-k3r5 = "u-boot-spl.bin"
 SPL_UART_BINARY_am64xx-evm-k3r5 = "u-boot-spl.bin"
 SPL_UART_BINARY_am64xx-hs-evm-k3r5 = "u-boot-spl.bin"
-SPL_UART_BINARY_am62xx-evm-k3r5 = "u-boot-spl.bin"
+SPL_UART_BINARY_am62xx-sk-k3r5 = "u-boot-spl.bin"
 
 SPL_UART_IMAGE ?= "${SPL_UART_BINARY}-${MACHINE}-${PV}-${PR}"
 SPL_UART_SYMLINK ?= "${SPL_UART_BINARY}-${MACHINE}"
@@ -421,7 +421,7 @@ do_deploy_append_am64xx-hs-evm-k3r5 () {
 	mv ${DEPLOYDIR}/u-boot-spl.bin ${DEPLOYDIR}/u-boot-spl-r5spl.bin || true
 }
 
-do_deploy_append_am62xx-evm-k3r5 () {
+do_deploy_append_am62xx-sk-k3r5 () {
 	mv ${DEPLOYDIR}/tiboot3.bin ${DEPLOYDIR}/tiboot3-r5spl.bin || true
 	mv ${DEPLOYDIR}/u-boot-spl.bin ${DEPLOYDIR}/u-boot-spl-r5spl.bin || true
 }
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-ti][dunfell][PATCH] Rename the am62xx-evm platform to am62xx-sk
  2022-04-05 17:04 [meta-ti][dunfell][PATCH] Rename the am62xx-evm platform to am62xx-sk Ryan Eatmon
@ 2022-04-05 17:36 ` Nishanth Menon
  2022-04-05 21:50   ` Denys Dmytriyenko
  0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2022-04-05 17:36 UTC (permalink / raw)
  To: reatmon; +Cc: Yogesh Siraswar, Praneeth Bajjuri, Denys Dmytriyenko, meta-ti

On 12:04-20220405, Ryan Eatmon via lists.yoctoproject.org wrote:
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>


Could we please add a commit message explaining reasoning?

This is overall, IMHO a bad idea. sk is ONE of the boards we will
support with the same build. See am335x, 437x etc.. if we start spawning
off per board builds, there is never an end to the confusion this will
create.

So two choices:
a) stick with evm as default (all encompasing builds) and exceptions as
specific boards
OR
b) start building ever board as a separate yocto machine.

I strongly discourage (b), it just creates confusion!

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-ti][dunfell][PATCH] Rename the am62xx-evm platform to am62xx-sk
  2022-04-05 17:36 ` Nishanth Menon
@ 2022-04-05 21:50   ` Denys Dmytriyenko
  0 siblings, 0 replies; 3+ messages in thread
From: Denys Dmytriyenko @ 2022-04-05 21:50 UTC (permalink / raw)
  To: nm; +Cc: reatmon, Yogesh Siraswar, Praneeth Bajjuri, meta-ti

On Tue, Apr 05, 2022 at 12:36:28PM -0500, Nishanth Menon via lists.yoctoproject.org wrote:
> On 12:04-20220405, Ryan Eatmon via lists.yoctoproject.org wrote:
> > Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> 
> 
> Could we please add a commit message explaining reasoning?
> 
> This is overall, IMHO a bad idea. sk is ONE of the boards we will
> support with the same build. See am335x, 437x etc.. if we start spawning
> off per board builds, there is never an end to the confusion this will
> create.
> 
> So two choices:
> a) stick with evm as default (all encompasing builds) and exceptions as
> specific boards
> OR
> b) start building ever board as a separate yocto machine.
> 
> I strongly discourage (b), it just creates confusion!

I agree here. Historically, we've had SK (Starter Kit) boards in other SoC 
families in the past. But we tried to have a super-set platform in meta-ti to 
support as many of the board variants, as possible, usually named EVMs. I 
don't remember exactly, but I do believe there were one or two instances where 
SK or IDK or even a community board came before the EVM, but we still tried 
to keep the super-set under the EVM umbrella.

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-06 16:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 17:04 [meta-ti][dunfell][PATCH] Rename the am62xx-evm platform to am62xx-sk Ryan Eatmon
2022-04-05 17:36 ` Nishanth Menon
2022-04-05 21:50   ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.