All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/postgresql: fix build without NPTL
@ 2022-04-05 21:57 Fabrice Fontaine
  2022-04-12 18:32 ` Arnout Vandecappelle
  2022-04-13  7:48 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-04-05 21:57 UTC (permalink / raw)
  To: buildroot; +Cc: Peter Seiderer, Fabrice Fontaine

Fix the following build failure without NPTL raised since bump to
version 14.1 in commit c9bd02911565819789120370178e82da5dfbacc0 and
https://github.com/postgres/postgres/commit/44bf3d5083e151d772c5d6f656e3e162f573dced:

In file included from pthread_barrier_wait.c:16:
../../src/include/port/pg_pthread.h:31:3: error: conflicting types for 'pthread_barrier_t'
   31 | } pthread_barrier_t;
      |   ^~~~~~~~~~~~~~~~~
In file included from /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/bits/uClibc_stdio.h:114,
                 from /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/stdio.h:71,
                 from ../../src/include/c.h:59,
                 from pthread_barrier_wait.c:14:
/home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/bits/pthreadtypes.h:135:3: note: previous declaration of 'pthread_barrier_t' was here
  135 | } pthread_barrier_t;
      |   ^~~~~~~~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/70acbe121236ef0905c4466d4f7a0839723d2c49

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/postgresql/postgresql.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
index c389246f80..1dfb20b58d 100644
--- a/package/postgresql/postgresql.mk
+++ b/package/postgresql/postgresql.mk
@@ -38,7 +38,7 @@ ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 POSTGRESQL_CONF_ENV += pgac_cv_type_locale_t=no
 endif
 
-ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),y)
 POSTGRESQL_CONF_OPTS += --disable-thread-safety
 endif
 
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/postgresql: fix build without NPTL
  2022-04-05 21:57 [Buildroot] [PATCH 1/1] package/postgresql: fix build without NPTL Fabrice Fontaine
@ 2022-04-12 18:32 ` Arnout Vandecappelle
  2022-04-13  7:48 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2022-04-12 18:32 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: Peter Seiderer



On 05/04/2022 23:57, Fabrice Fontaine wrote:
> Fix the following build failure without NPTL raised since bump to
> version 14.1 in commit c9bd02911565819789120370178e82da5dfbacc0 and
> https://github.com/postgres/postgres/commit/44bf3d5083e151d772c5d6f656e3e162f573dced:
> 
> In file included from pthread_barrier_wait.c:16:
> ../../src/include/port/pg_pthread.h:31:3: error: conflicting types for 'pthread_barrier_t'
>     31 | } pthread_barrier_t;
>        |   ^~~~~~~~~~~~~~~~~
> In file included from /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/bits/uClibc_stdio.h:114,
>                   from /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/stdio.h:71,
>                   from ../../src/include/c.h:59,
>                   from pthread_barrier_wait.c:14:
> /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/bits/pthreadtypes.h:135:3: note: previous declaration of 'pthread_barrier_t' was here
>    135 | } pthread_barrier_t;
>        |   ^~~~~~~~~~~~~~~~~
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/70acbe121236ef0905c4466d4f7a0839723d2c49
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/postgresql/postgresql.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
> index c389246f80..1dfb20b58d 100644
> --- a/package/postgresql/postgresql.mk
> +++ b/package/postgresql/postgresql.mk
> @@ -38,7 +38,7 @@ ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
>   POSTGRESQL_CONF_ENV += pgac_cv_type_locale_t=no
>   endif
>   
> -ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),y)
>   POSTGRESQL_CONF_OPTS += --disable-thread-safety
>   endif
>   
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/postgresql: fix build without NPTL
  2022-04-05 21:57 [Buildroot] [PATCH 1/1] package/postgresql: fix build without NPTL Fabrice Fontaine
  2022-04-12 18:32 ` Arnout Vandecappelle
@ 2022-04-13  7:48 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-04-13  7:48 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Peter Seiderer, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure without NPTL raised since bump to
 > version 14.1 in commit c9bd02911565819789120370178e82da5dfbacc0 and
 > https://github.com/postgres/postgres/commit/44bf3d5083e151d772c5d6f656e3e162f573dced:

 > In file included from pthread_barrier_wait.c:16:
 > ../../src/include/port/pg_pthread.h:31:3: error: conflicting types for 'pthread_barrier_t'
 >    31 | } pthread_barrier_t;
 >       |   ^~~~~~~~~~~~~~~~~
 > In file included from /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/bits/uClibc_stdio.h:114,
 >                  from /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/stdio.h:71,
 >                  from ../../src/include/c.h:59,
 >                  from pthread_barrier_wait.c:14:
 > /home/autobuild/autobuild/instance-11/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/include/bits/pthreadtypes.h:135:3: note: previous declaration of 'pthread_barrier_t' was here
 >   135 | } pthread_barrier_t;
 >       |   ^~~~~~~~~~~~~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/70acbe121236ef0905c4466d4f7a0839723d2c49

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

> ---
 >  package/postgresql/postgresql.mk | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
 > index c389246f80..1dfb20b58d 100644
 > --- a/package/postgresql/postgresql.mk
 > +++ b/package/postgresql/postgresql.mk
 > @@ -38,7 +38,7 @@ ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 >  POSTGRESQL_CONF_ENV += pgac_cv_type_locale_t=no
 >  endif
 
 > -ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
 > +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),y)
 >  POSTGRESQL_CONF_OPTS += --disable-thread-safety
 >  endif
 
 > -- 

 > 2.35.1

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-13  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 21:57 [Buildroot] [PATCH 1/1] package/postgresql: fix build without NPTL Fabrice Fontaine
2022-04-12 18:32 ` Arnout Vandecappelle
2022-04-13  7:48 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.