All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Robin van der Gracht <robin@protonic.nl>,
	David Airlie <airlied@linux.ie>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	David Jander <david@protonic.nl>, Sam Ravnborg <sam@ravnborg.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum
Date: Wed, 6 Apr 2022 09:23:48 +0800	[thread overview]
Message-ID: <20220406012348.GE129381@dragon> (raw)
In-Reply-To: <20220221095312.3692669-1-o.rempel@pengutronix.de>

On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote:
> From: David Jander <david@protonic.nl>
> 
> Recover default behavior of the device and set maximal brightness
> 
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6dl-victgo.dts   | 2 +-
>  arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts
> index 227c952543d4..e6134efbfabd 100644
> --- a/arch/arm/boot/dts/imx6dl-victgo.dts
> +++ b/arch/arm/boot/dts/imx6dl-victgo.dts
> @@ -28,7 +28,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;

Please take a look at the documentation of the property.

  default-brightness-level:
    description:
      The default brightness level (index into the array defined by the
      "brightness-levels" property).

Shawn

>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> index 1ac7e13249d2..c1d06bc28c67 100644
> --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> @@ -23,7 +23,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;
>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> -- 
> 2.30.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>, David Jander <david@protonic.nl>,
	devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Robin van der Gracht <robin@protonic.nl>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum
Date: Wed, 6 Apr 2022 09:23:48 +0800	[thread overview]
Message-ID: <20220406012348.GE129381@dragon> (raw)
In-Reply-To: <20220221095312.3692669-1-o.rempel@pengutronix.de>

On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote:
> From: David Jander <david@protonic.nl>
> 
> Recover default behavior of the device and set maximal brightness
> 
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6dl-victgo.dts   | 2 +-
>  arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts
> index 227c952543d4..e6134efbfabd 100644
> --- a/arch/arm/boot/dts/imx6dl-victgo.dts
> +++ b/arch/arm/boot/dts/imx6dl-victgo.dts
> @@ -28,7 +28,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;

Please take a look at the documentation of the property.

  default-brightness-level:
    description:
      The default brightness level (index into the array defined by the
      "brightness-levels" property).

Shawn

>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> index 1ac7e13249d2..c1d06bc28c67 100644
> --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> @@ -23,7 +23,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;
>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> -- 
> 2.30.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>, David Jander <david@protonic.nl>,
	devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Robin van der Gracht <robin@protonic.nl>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum
Date: Wed, 6 Apr 2022 09:23:48 +0800	[thread overview]
Message-ID: <20220406012348.GE129381@dragon> (raw)
In-Reply-To: <20220221095312.3692669-1-o.rempel@pengutronix.de>

On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote:
> From: David Jander <david@protonic.nl>
> 
> Recover default behavior of the device and set maximal brightness
> 
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6dl-victgo.dts   | 2 +-
>  arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts
> index 227c952543d4..e6134efbfabd 100644
> --- a/arch/arm/boot/dts/imx6dl-victgo.dts
> +++ b/arch/arm/boot/dts/imx6dl-victgo.dts
> @@ -28,7 +28,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;

Please take a look at the documentation of the property.

  default-brightness-level:
    description:
      The default brightness level (index into the array defined by the
      "brightness-levels" property).

Shawn

>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> index 1ac7e13249d2..c1d06bc28c67 100644
> --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> @@ -23,7 +23,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;
>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> -- 
> 2.30.2
> 

  parent reply	other threads:[~2022-04-06  1:24 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21  9:53 [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum Oleksij Rempel
2022-02-21  9:53 ` Oleksij Rempel
2022-02-21  9:53 ` Oleksij Rempel
2022-02-21  9:53 ` [PATCH v1 2/8] ARM: dts: imx6qdl-vicut1/vicutgo: Rename backlight to backlight_lcd Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-04-06  2:14   ` Shawn Guo
2022-04-06  2:14     ` Shawn Guo
2022-04-06  2:14     ` Shawn Guo
2022-02-21  9:53 ` [PATCH v1 3/8] ARM: dts: imx6qdl-vicut1/vicutgo: Add backlight_led node Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-04-06  2:15   ` Shawn Guo
2022-04-06  2:15     ` Shawn Guo
2022-04-06  2:15     ` Shawn Guo
2022-02-21  9:53 ` [PATCH v1 4/8] ARM: dts: imx6qdl-vicut1: update gpio-line-names for some GPIOs Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-04-06  2:15   ` Shawn Guo
2022-04-06  2:15     ` Shawn Guo
2022-04-06  2:15     ` Shawn Guo
2022-02-21  9:53 ` [PATCH v1 5/8] ARM: dts: imx6qdl-vicut1/vicutgo: The sgtl5000 uses i2s not ac97 Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-04-06  2:05   ` Shawn Guo
2022-04-06  2:05     ` Shawn Guo
2022-04-06  2:05     ` Shawn Guo
2022-02-21  9:53 ` [PATCH v1 6/8] ARM: dts: imx6dl-victgo: Add interrupt-counter nodes Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-04-06  2:15   ` Shawn Guo
2022-04-06  2:15     ` Shawn Guo
2022-04-06  2:15     ` Shawn Guo
2022-02-21  9:53 ` [PATCH v1 7/8] ARM: dts: imx6dl-victgo: The TGO uses a lg, lb070wv8 compatible 7" display Oleksij Rempel
2022-02-21  9:53   ` [PATCH v1 7/8] ARM: dts: imx6dl-victgo: The TGO uses a lg,lb070wv8 " Oleksij Rempel
2022-02-21  9:53   ` [PATCH v1 7/8] ARM: dts: imx6dl-victgo: The TGO uses a lg, lb070wv8 " Oleksij Rempel
2022-04-06  2:16   ` [PATCH v1 7/8] ARM: dts: imx6dl-victgo: The TGO uses a lg,lb070wv8 " Shawn Guo
2022-04-06  2:16     ` Shawn Guo
2022-04-06  2:16     ` Shawn Guo
2022-02-21  9:53 ` [PATCH v1 8/8] ARM: dts: imx6qdl-victgo: add CAN termination support Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-02-21  9:53   ` Oleksij Rempel
2022-04-06  2:18   ` Shawn Guo
2022-04-06  2:18     ` Shawn Guo
2022-04-06  2:18     ` Shawn Guo
2022-04-06  1:23 ` Shawn Guo [this message]
2022-04-06  1:23   ` [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum Shawn Guo
2022-04-06  1:23   ` Shawn Guo
2022-04-06  1:59   ` Shawn Guo
2022-04-06  1:59     ` Shawn Guo
2022-04-06  1:59     ` Shawn Guo
2022-04-06  2:14 ` Shawn Guo
2022-04-06  2:14   ` Shawn Guo
2022-04-06  2:14   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220406012348.GE129381@dragon \
    --to=shawnguo@kernel.org \
    --cc=airlied@linux.ie \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    --cc=s.hauer@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.