* [PATCH v2] configure: Fix default -O2 being added when CFLAGS not set
@ 2022-03-28 17:56 Glenn Washburn
2022-04-06 15:23 ` Daniel Kiper
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Washburn @ 2022-03-28 17:56 UTC (permalink / raw)
To: grub-devel, Daniel Kiper; +Cc: Glenn Washburn, Robbie Harwood, Paul Menzel
Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS
was defaulted to "" early in configure to prevent this. A recent commit
ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new
autotools warnings") added AC_USE_SYSTEM_EXTENSIONS, which pulls in the
autoconf CFLAGS check, before we default CFLAGS and thus setting the
autoconf default for CFLAGS. Move the default setting of CFLAGS to before
AC_USE_SYSTEM_EXTENSIONS so that autoconf will see CFLAGS as set and not
give it a default.
Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
configure.ac | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3ffbc7c57b..c1e50c9d75 100644
--- a/configure.ac
+++ b/configure.ac
@@ -36,12 +36,12 @@ dnl description of the relationships between them.
AC_INIT([GRUB],[2.11],[bug-grub@gnu.org])
-AC_USE_SYSTEM_EXTENSIONS
-AC_CONFIG_AUX_DIR([build-aux])
-
# We don't want -g -O2 by default in CFLAGS
: ${CFLAGS=""}
+AC_USE_SYSTEM_EXTENSIONS
+AC_CONFIG_AUX_DIR([build-aux])
+
# Checks for build, host and target systems.
AC_CANONICAL_BUILD
AC_CANONICAL_HOST
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] configure: Fix default -O2 being added when CFLAGS not set
2022-03-28 17:56 [PATCH v2] configure: Fix default -O2 being added when CFLAGS not set Glenn Washburn
@ 2022-04-06 15:23 ` Daniel Kiper
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kiper @ 2022-04-06 15:23 UTC (permalink / raw)
To: Glenn Washburn; +Cc: grub-devel, Robbie Harwood, Paul Menzel
On Mon, Mar 28, 2022 at 12:56:22PM -0500, Glenn Washburn wrote:
> Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS
> was defaulted to "" early in configure to prevent this. A recent commit
> ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new
> autotools warnings") added AC_USE_SYSTEM_EXTENSIONS, which pulls in the
> autoconf CFLAGS check, before we default CFLAGS and thus setting the
> autoconf default for CFLAGS. Move the default setting of CFLAGS to before
> AC_USE_SYSTEM_EXTENSIONS so that autoconf will see CFLAGS as set and not
> give it a default.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> Reviewed-by: Robbie Harwood <rharwood@redhat.com>
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> configure.ac | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3ffbc7c57b..c1e50c9d75 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -36,12 +36,12 @@ dnl description of the relationships between them.
>
> AC_INIT([GRUB],[2.11],[bug-grub@gnu.org])
>
> -AC_USE_SYSTEM_EXTENSIONS
> -AC_CONFIG_AUX_DIR([build-aux])
> -
> # We don't want -g -O2 by default in CFLAGS
> : ${CFLAGS=""}
>
> +AC_USE_SYSTEM_EXTENSIONS
> +AC_CONFIG_AUX_DIR([build-aux])
I am OK with this change but I think AC_CONFIG_AUX_DIR macro move also
requires at least one sentence explanation in the commit message.
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 17:56 [PATCH v2] configure: Fix default -O2 being added when CFLAGS not set Glenn Washburn
2022-04-06 15:23 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.