[igt-dev] [PATCH i-g-t 0/3] Improvements in plane scaling

[igt-dev] [PATCH i-g-t 0/3] Improvements in plane scaling

[Swati Sharma]

Currently, plane scaling tests timesout in CI since they
take large amount of time to loop through all pixel-formats per
class for each modifier or rotation.
So, to reduce execution time we are looping through either format
or modifier or rotation keeping other two variants constant.

TODO: How to validate combination of format, modifier
and rotation which executes in CI's time limits.

Swati Sharma (3):
  tests/kms_plane_scaling: Fix modifier
  tests/kms_plane_scaling: Fix modifier and format
  tests/kms_plane_scaling: Tests to validate modifiers

 tests/kms_plane_scaling.c | 177 +++++++++++++++++++++-----------------
 1 file changed, 98 insertions(+), 79 deletions(-)

-- 
2.25.1

[igt-dev] [PATCH i-g-t 1/3] tests/kms_plane_scaling: Fix modifier

[Swati Sharma]

The current test takes around 500.454s/connector/pipe on DG2
to complete. CI per test execution timeout is 120s.
In this test, we have fixed modifier as LINEAR and looped
through all the pixel formats which is the sole purpose of
this test. With this change, execution time has reduced to
340.297s.
To validate scaling with modifiers separate tests will be
introduced.

Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 45 ++++++++++++++++-----------------------
 1 file changed, 18 insertions(+), 27 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index b91039b0..435b2f61 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -327,17 +327,11 @@ static void test_scaler_with_rotation_pipe(data_t *d,
 	}
 }
 
-static const uint64_t modifiers[] = {
-	DRM_FORMAT_MOD_LINEAR,
-	I915_FORMAT_MOD_X_TILED,
-	I915_FORMAT_MOD_Y_TILED,
-	I915_FORMAT_MOD_Yf_TILED
-};
-
 static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height, bool is_upscale,
 					       enum pipe pipe, igt_output_t *output)
 {
 	igt_display_t *display = &d->display;
+	uint64_t modifier = DRM_FORMAT_MOD_LINEAR;
 	igt_plane_t *plane;
 
 	cleanup_crtc(d);
@@ -345,33 +339,30 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, int width, int height,
 	igt_output_set_pipe(output, pipe);
 
 	for_each_plane_on_pipe(display, pipe, plane) {
+		struct igt_vec tested_formats;
+
 		if (plane->type == DRM_PLANE_TYPE_CURSOR)
 			continue;
 
-		for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
-			uint64_t modifier = modifiers[i];
-			struct igt_vec tested_formats;
+		igt_vec_init(&tested_formats, sizeof(uint32_t));
 
-			igt_vec_init(&tested_formats, sizeof(uint32_t));
-
-			for (int j = 0; j < plane->drm_plane->count_formats; j++) {
-				uint32_t format = plane->drm_plane->formats[j];
-
-				if (!test_pipe_iteration(d, pipe, j))
-					continue;
+		for (int j = 0; j < plane->drm_plane->count_formats; j++) {
+			uint32_t format = plane->drm_plane->formats[j];
 
-				if (test_format(d, &tested_formats, format) &&
-				    igt_plane_has_format_mod(plane, format, modifier) &&
-				    can_scale(d, format))
-					check_scaling_pipe_plane_rot(d, plane,
-								     format, modifier,
-								     width, height,
-								     is_upscale,
-								     pipe, output, IGT_ROTATION_0);
-			}
+			if (!test_pipe_iteration(d, pipe, j))
+				continue;
 
-			igt_vec_fini(&tested_formats);
+			if (test_format(d, &tested_formats, format) &&
+			    igt_plane_has_format_mod(plane, format, modifier) &&
+			    can_scale(d, format))
+			    check_scaling_pipe_plane_rot(d, plane,
+							 format, modifier,
+							 width, height,
+							 is_upscale,
+							 pipe, output, IGT_ROTATION_0);
 		}
+
+		igt_vec_fini(&tested_formats);
 	}
 }
 
-- 
2.25.1

[igt-dev] [PATCH i-g-t 2/3] tests/kms_plane_scaling: Fix modifier and format

[Swati Sharma]

Again, these tests timeouts in CI. Here fixed modifier and
format and looped only for rotations to validate scaling with
different rotations.
---
 tests/kms_plane_scaling.c | 60 ++++++---------------------------------
 1 file changed, 8 insertions(+), 52 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 435b2f61..ab1e20ea 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -196,35 +196,6 @@ static const igt_rotation_t rotations[] = {
 	IGT_ROTATION_270,
 };
 
-static bool can_rotate(data_t *d, unsigned format, uint64_t modifier,
-		       igt_rotation_t rot)
-{
-	if (!is_i915_device(d->drm_fd))
-		return true;
-
-	switch (format) {
-	case DRM_FORMAT_RGB565:
-		if (intel_display_ver(d->devid) >= 11)
-			break;
-		/* fall through */
-	case DRM_FORMAT_C8:
-	case DRM_FORMAT_XRGB16161616F:
-	case DRM_FORMAT_XBGR16161616F:
-	case DRM_FORMAT_ARGB16161616F:
-	case DRM_FORMAT_ABGR16161616F:
-	case DRM_FORMAT_Y210:
-	case DRM_FORMAT_Y212:
-	case DRM_FORMAT_Y216:
-	case DRM_FORMAT_XVYU12_16161616:
-	case DRM_FORMAT_XVYU16161616:
-		return false;
-	default:
-		break;
-	}
-
-	return true;
-}
-
 static bool can_scale(data_t *d, unsigned format)
 {
 	if (!is_i915_device(d->drm_fd))
@@ -286,6 +257,7 @@ static void test_scaler_with_rotation_pipe(data_t *d,
 					   igt_output_t *output)
 {
 	igt_display_t *display = &d->display;
+	unsigned format = DRM_FORMAT_XRGB8888;
 	uint64_t modifier = DRM_FORMAT_MOD_LINEAR;
 	igt_plane_t *plane;
 
@@ -299,30 +271,14 @@ static void test_scaler_with_rotation_pipe(data_t *d,
 
 		for (int i = 0; i < ARRAY_SIZE(rotations); i++) {
 			igt_rotation_t rot = rotations[i];
-			struct igt_vec tested_formats;
-
-			igt_vec_init(&tested_formats, sizeof(uint32_t));
-
-			for (int j = 0; j < plane->drm_plane->count_formats; j++) {
-				unsigned format = plane->drm_plane->formats[j];
 
-				if (!test_pipe_iteration(d, pipe, j))
-					continue;
-
-				if (test_format(d, &tested_formats, format) &&
-				    igt_plane_has_format_mod(plane, format, modifier) &&
-				    igt_plane_has_rotation(plane, rot) &&
-				    can_rotate(d, format, modifier, rot) &&
-				    can_scale(d, format))
+				if (igt_plane_has_rotation(plane, rot))
 					check_scaling_pipe_plane_rot(d, plane,
 								     format, modifier,
 								     width, height,
 								     is_upscale,
 								     pipe, output,
 								     rot);
-			}
-
-			igt_vec_fini(&tested_formats);
 		}
 	}
 }
@@ -750,14 +706,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			}
 		}
 
-		igt_describe("Tests upscaling with tiling rotation, from 20x20 fb.");
+		igt_describe("Tests upscaling with rotation, from 20x20 fb.");
 		igt_subtest_with_dynamic("upscale-with-rotation-20x20") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
 				igt_dynamic_f("pipe-%s-%s-upscale-with-rotation", kmstest_pipe_name(pipe), igt_output_name(output))
 					test_scaler_with_rotation_pipe(&data, 20, 20, true, pipe, output);
 		}
 
-		igt_describe("Tests upscaling with tiling rotation for 0.25 scaling factor.");
+		igt_describe("Tests upscaling with rotation for 0.25 scaling factor.");
 		igt_subtest_with_dynamic("upscale-with-rotation-factor-0-25") {
 			for_each_pipe_with_single_output(&data.display, pipe, output) {
 				drmModeModeInfo *mode;
@@ -770,7 +726,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			}
 		}
 
-		igt_describe("Tests downscaling with tiling rotation for 0.25 scaling factor.");
+		igt_describe("Tests downscaling with rotation for 0.25 scaling factor.");
 		igt_subtest_with_dynamic("downscale-with-rotation-factor-0-25") {
 			for_each_pipe_with_single_output(&data.display, pipe, output) {
 				drmModeModeInfo *mode;
@@ -783,7 +739,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			}
 		}
 
-		igt_describe("Tests downscaling with tiling rotation for 0.5 scaling factor.");
+		igt_describe("Tests downscaling with rotation for 0.5 scaling factor.");
 		igt_subtest_with_dynamic("downscale-with-rotation-factor-0-5") {
 			for_each_pipe_with_single_output(&data.display, pipe, output) {
 				drmModeModeInfo *mode;
@@ -796,7 +752,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			}
 		}
 
-		igt_describe("Tests downscaling with tiling rotation for 0.75 scaling factor.");
+		igt_describe("Tests downscaling with rotation for 0.75 scaling factor.");
 		igt_subtest_with_dynamic("downscale-with-rotation-factor-0-75") {
 			for_each_pipe_with_single_output(&data.display, pipe, output) {
 				drmModeModeInfo *mode;
@@ -809,7 +765,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			}
 		}
 
-		igt_describe("Tests scaling with tiling rotation, unity scaling.");
+		igt_describe("Tests scaling with rotation, unity scaling.");
 		igt_subtest_with_dynamic("scaler-with-rotation-unity-scaling") {
 			for_each_pipe_with_single_output(&data.display, pipe, output) {
 				drmModeModeInfo *mode;
-- 
2.25.1

[igt-dev] [PATCH i-g-t 3/3] tests/kms_plane_scaling: Tests to validate modifiers

[Swati Sharma]

In this patch, various scaling(upscale/downscale/unity)
is tested with various modifiers.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 72 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index ab1e20ea..a5ea7d03 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -778,6 +778,78 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			}
 		}
 
+		igt_describe("Tests upscaling with modifiers, from 20x20 fb.");
+		igt_subtest_with_dynamic("upscale-with-modifiers-20x20") {
+			for_each_pipe_with_single_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-upscale-with-modifier", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
+		}
+
+		igt_describe("Tests upscaling with modifiers for 0.25 scaling factor.");
+		igt_subtest_with_dynamic("upscale-with-modifiers-factor-0-25") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-upscale-with-modifiers", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_pixel_format_pipe(&data, 0.25 * mode->hdisplay,
+							0.25 * mode->vdisplay, true, pipe, output);
+			}
+		}
+
+		igt_describe("Tests downscaling with modifiers for 0.25 scaling factor.");
+		igt_subtest_with_dynamic("downscale-with-modifiers-factor-0-25") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-downscale-with-modifiers", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_pixel_format_pipe(&data, 0.25 * mode->hdisplay,
+							0.25 * mode->vdisplay, false, pipe, output);
+			}
+		}
+
+		igt_describe("Tests downscaling with modifiers for 0.5 scaling factor.");
+		igt_subtest_with_dynamic("downscale-with-modifiers-factor-0-5") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-downscale-with-modifiers", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_pixel_format_pipe(&data, 0.5 * mode->hdisplay,
+							0.5 * mode->vdisplay, false, pipe, output);
+			}
+		}
+
+		igt_describe("Tests downscaling with modifiers for 0.75 scaling factor.");
+		igt_subtest_with_dynamic("downscale-with-modifiers-factor-0-75") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-downscale-with-pixel-format", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
+							0.75 * mode->vdisplay, false, pipe, output);
+			}
+		}
+
+		igt_describe("Tests scaling with modifiers, unity scaling.");
+		igt_subtest_with_dynamic("scaler-with-modifiers-unity-scaling") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-scaler-with-modifiers", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifiers_pipe(&data, mode->hdisplay,
+							mode->vdisplay, true, pipe, output);
+			}
+		}
+
 		igt_describe("Tests scaling with clipping and clamping.");
 		igt_subtest_with_dynamic("scaler-with-clipping-clamping") {
 			for_each_pipe_with_single_output(&data.display, pipe, output) {
-- 
2.25.1

[igt-dev] ✗ Fi.CI.BUILD: failure for Improvements in plane scaling

[Patchwork]

== Series Details ==

Series: Improvements in plane scaling
URL   : https://patchwork.freedesktop.org/series/102280/
State : failure

== Summary ==

IGT patchset build failed on latest successful build
7506029428b3740395ce086daf86b9498fbbeb77 tests/intel-ci/fast-feedback: Move gem_lmem_swapping

[47/395] Linking target tests/kms_3d
[48/395] Linking target tests/fbdev
[49/395] Linking target tests/drm_read
[50/395] Linking target tests/feature_discovery
[51/395] Linking target tests/kms_addfb_basic
[52/395] Linking target tests/kms_async_flips
[53/395] Linking target tests/kms_atomic
[54/395] Linking target tests/kms_atomic_interruptible
[55/395] Linking target tests/kms_atomic_transition
[56/395] Linking target tests/kms_bw
[57/395] Linking target tests/kms_concurrent
[58/395] Linking target tests/kms_content_protection
[59/395] Linking target tests/kms_cursor_edge_walk
[60/395] Linking target tests/kms_cursor_crc
[61/395] Linking target tests/kms_display_modes
[62/395] Linking target tests/kms_cursor_legacy
[63/395] Linking target tests/kms_dither
[64/395] Linking target tests/kms_dp_aux_dev
[65/395] Linking target tests/kms_flip
[66/395] Linking target tests/kms_dp_tiled_display
[67/395] Linking target tests/kms_flip_event_leak
[68/395] Linking target tests/kms_force_connector_basic
[69/395] Linking target tests/kms_getfb
[70/395] Linking target tests/kms_hdmi_inject
[71/395] Linking target tests/kms_hdr
[72/395] Linking target tests/kms_plane_alpha_blend
[73/395] Linking target tests/kms_invalid_mode
[74/395] Linking target tests/kms_lease
[75/395] Linking target tests/kms_multipipe_modeset
[76/395] Linking target tests/kms_cdclk
[77/395] Linking target tests/kms_ccs
[78/395] Linking target tests/kms_pipe_crc_basic
[79/395] Linking target tests/kms_plane
[80/395] Linking target tests/kms_plane_cursor
[81/395] Compiling C object tests/kms_plane_scaling.p/kms_plane_scaling.c.o
FAILED: tests/kms_plane_scaling.p/kms_plane_scaling.c.o 
ccache cc -Itests/kms_plane_scaling.p -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I.. -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/alsa -I/usr/include -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ tests/kms_plane_scaling.p/kms_plane_scaling.c.o -MF tests/kms_plane_scaling.p/kms_plane_scaling.c.o.d -o tests/kms_plane_scaling.p/kms_plane_scaling.c.o -c ../tests/kms_plane_scaling.c
../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
      test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      test_scaler_with_rotation_pipe
../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
      test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      test_scaler_with_rotation_pipe
../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.

[igt-dev] ✗ GitLab.Pipeline: warning for Improvements in plane scaling

[Patchwork]

== Series Details ==

Series: Improvements in plane scaling
URL   : https://patchwork.freedesktop.org/series/102280/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/552205 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800140):
  cc -Itests/59830eb@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread  -MD -MQ 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268620:step_script
  section_start:1649268620:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268621:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800143):
  /usr/bin/aarch64-linux-gnu-gcc -Itests/59830eb@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/aarch64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread  -MD -MQ 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268633:step_script
  section_start:1649268633:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268633:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800142):
  /usr/bin/arm-linux-gnueabihf-gcc -Itests/59830eb@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/arm-linux-gnueabihf -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread  -MD -MQ 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268633:step_script
  section_start:1649268633:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268634:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800144):
  /usr/bin/mips-linux-gnu-gcc -Itests/59830eb@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/mips-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread  -MD -MQ 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
        test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268650:step_script
  section_start:1649268650:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268651:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800135):
  cc -Itests/59830eb@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    785 |      test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    835 |      test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268610:step_script
  section_start:1649268610:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268613:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800139):
  static void test_scaler_with_rotation_pipe(data_t *d,
              ^
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function 'test_scaler_with_modifiers_pipe' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                          test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
                                          ^
  ../tests/kms_plane_scaling.c:835:6: note: did you mean 'test_scaler_with_rotation_pipe'?
  ../tests/kms_plane_scaling.c:253:13: note: 'test_scaler_with_rotation_pipe' declared here
  static void test_scaler_with_rotation_pipe(data_t *d,
              ^
  ../tests/kms_plane_scaling.c:848:6: error: implicit declaration of function 'test_scaler_with_modifiers_pipe' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                          test_scaler_with_modifiers_pipe(&data, mode->hdisplay,
                                          ^
  3 errors generated.
  ninja: build stopped: subcommand failed.
  section_end:1649268616:step_script
  section_start:1649268616:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268618:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-no-libdrm-nouveau has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800138):
  cc -Itests/59830eb@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    785 |      test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    835 |      test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268624:step_script
  section_start:1649268624:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268625:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800136):
  cc -Itests/59830eb@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/libunwind -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/59830eb@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    785 |      test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    835 |      test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268625:step_script
  section_start:1649268625:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268626:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20800137):
  cc -Itests/tests@@kms_plane_scaling@exe -Itests -I../tests -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread  -MD -MQ 'tests/tests@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -MF 'tests/tests@@kms_plane_scaling@exe/kms_plane_scaling.c.o.d' -o 'tests/tests@@kms_plane_scaling@exe/kms_plane_scaling.c.o' -c ../tests/kms_plane_scaling.c
  ../tests/kms_plane_scaling.c: In function ‘__igt_unique____real_main622’:
  ../tests/kms_plane_scaling.c:785:6: error: implicit declaration of function ‘test_scaler_with_modifier_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    785 |      test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:785:6: warning: nested extern declaration of ‘test_scaler_with_modifier_pipe’ [-Wnested-externs]
  ../tests/kms_plane_scaling.c:835:6: error: implicit declaration of function ‘test_scaler_with_modifiers_pipe’; did you mean ‘test_scaler_with_rotation_pipe’? [-Werror=implicit-function-declaration]
    835 |      test_scaler_with_modifiers_pipe(&data, 0.75 * mode->hdisplay,
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |      test_scaler_with_rotation_pipe
  ../tests/kms_plane_scaling.c:835:6: warning: nested extern declaration of ‘test_scaler_with_modifiers_pipe’ [-Wnested-externs]
  cc1: some warnings being treated as errors
  ninja: build stopped: subcommand failed.
  section_end:1649268623:step_script
  section_start:1649268623:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1649268624:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/552205

Re: [igt-dev] [PATCH i-g-t 0/3] Improvements in plane scaling

[Jessica Zhang]

On 4/6/2022 9:29 AM, Swati Sharma wrote:
> Currently, plane scaling tests timesout in CI since they
> take large amount of time to loop through all pixel-formats per
> class for each modifier or rotation.
> So, to reduce execution time we are looping through either format
> or modifier or rotation keeping other two variants constant.
> 
> TODO: How to validate combination of format, modifier
> and rotation which executes in CI's time limits.
> 
> Swati Sharma (3):
>    tests/kms_plane_scaling: Fix modifier
>    tests/kms_plane_scaling: Fix modifier and format
>    tests/kms_plane_scaling: Tests to validate modifiers
> 
>   tests/kms_plane_scaling.c | 177 +++++++++++++++++++++-----------------
>   1 file changed, 98 insertions(+), 79 deletions(-)

Tested-by: Jessica Zhang <quic_jesszhan@quicinc.com> # Lazor Chromebook 
(Trogdor)
> 
> -- 
> 2.25.1
> 

[igt-dev] [PATCH i-g-t 3/3] tests/kms_plane_scaling: Tests to validate modifiers

[Swati Sharma]

In this patch, scaling(upscale/downscale/unity)
is tested with various modifiers.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 112 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 112 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index ab1e20ea..301cf4e0 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -250,6 +250,46 @@ static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
 	return true;
 }
 
+static const uint64_t modifiers[] = {
+	DRM_FORMAT_MOD_LINEAR,
+	I915_FORMAT_MOD_X_TILED,
+	I915_FORMAT_MOD_Y_TILED,
+	I915_FORMAT_MOD_Yf_TILED,
+	I915_FORMAT_MOD_4_TILED
+};
+
+static void test_scaler_with_modifier_pipe(data_t *d,
+					   int width, int height,
+					   bool is_upscale,
+					   enum pipe pipe,
+					   igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	unsigned format = DRM_FORMAT_XRGB8888;
+	igt_plane_t *plane;
+
+	cleanup_crtc(d);
+
+	igt_output_set_pipe(output, pipe);
+
+	for_each_plane_on_pipe(display, pipe, plane) {
+		if (plane->type == DRM_PLANE_TYPE_CURSOR)
+			continue;
+
+		for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
+			uint64_t modifier = modifiers[i];
+
+				if (igt_plane_has_format_mod(plane, format, modifier))
+					check_scaling_pipe_plane_rot(d, plane,
+								     format, modifier,
+								     width, height,
+								     is_upscale,
+								     pipe, output,
+								     IGT_ROTATION_0);
+		}
+	}
+}
+
 static void test_scaler_with_rotation_pipe(data_t *d,
 					   int width, int height,
 					   bool is_upscale,
@@ -778,6 +818,78 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			}
 		}
 
+		igt_describe("Tests upscaling with modifiers, from 20x20 fb.");
+		igt_subtest_with_dynamic("upscale-with-modifier-20x20") {
+			for_each_pipe_with_single_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-upscale-with-modifier", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifier_pipe(&data, 20, 20, true, pipe, output);
+		}
+
+		igt_describe("Tests upscaling with modifiers for 0.25 scaling factor.");
+		igt_subtest_with_dynamic("upscale-with-modifier-factor-0-25") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-upscale-with-modifier", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifier_pipe(&data, 0.25 * mode->hdisplay,
+							0.25 * mode->vdisplay, true, pipe, output);
+			}
+		}
+
+		igt_describe("Tests downscaling with modifiers for 0.25 scaling factor.");
+		igt_subtest_with_dynamic("downscale-with-modifier-factor-0-25") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-downscale-with-modifier", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifier_pipe(&data, 0.25 * mode->hdisplay,
+							0.25 * mode->vdisplay, false, pipe, output);
+			}
+		}
+
+		igt_describe("Tests downscaling with modifiers for 0.5 scaling factor.");
+		igt_subtest_with_dynamic("downscale-with-modifier-factor-0-5") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-downscale-with-modifier", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifier_pipe(&data, 0.5 * mode->hdisplay,
+							0.5 * mode->vdisplay, false, pipe, output);
+			}
+		}
+
+		igt_describe("Tests downscaling with modifiers for 0.75 scaling factor.");
+		igt_subtest_with_dynamic("downscale-with-modifier-factor-0-75") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-downscale-with-modifier", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifier_pipe(&data, 0.75 * mode->hdisplay,
+							0.75 * mode->vdisplay, false, pipe, output);
+			}
+		}
+
+		igt_describe("Tests scaling with modifiers, unity scaling.");
+		igt_subtest_with_dynamic("scaler-with-modifier-unity-scaling") {
+			for_each_pipe_with_single_output(&data.display, pipe, output) {
+				drmModeModeInfo *mode;
+
+				mode = igt_output_get_mode(output);
+
+				igt_dynamic_f("pipe-%s-%s-scaler-with-modifier", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_scaler_with_modifier_pipe(&data, mode->hdisplay,
+							mode->vdisplay, true, pipe, output);
+			}
+		}
+
 		igt_describe("Tests scaling with clipping and clamping.");
 		igt_subtest_with_dynamic("scaler-with-clipping-clamping") {
 			for_each_pipe_with_single_output(&data.display, pipe, output) {
-- 
2.25.1