* [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero
@ 2022-04-05 18:53 Marco Pagani
2022-04-06 14:18 ` Tom Rix
2022-04-20 4:24 ` Moritz Fischer
0 siblings, 2 replies; 5+ messages in thread
From: Marco Pagani @ 2022-04-05 18:53 UTC (permalink / raw)
To: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix
Cc: Marco Pagani, linux-fpga, linux-kernel
Fix the "comparison with less than zero" warning reported by
cppcheck for the unsigned (size_t) parameter "count" of the
"alt_pr_fpga_write()" function.
Signed-off-by: Marco Pagani <marpagan@redhat.com>
---
drivers/fpga/altera-pr-ip-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
index be0667968d33..2ff3d8e46a0c 100644
--- a/drivers/fpga/altera-pr-ip-core.c
+++ b/drivers/fpga/altera-pr-ip-core.c
@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
u32 *buffer_32 = (u32 *)buf;
size_t i = 0;
- if (count <= 0)
+ if (count == 0)
return -EINVAL;
/* Write out the complete 32-bit chunks */
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero
2022-04-05 18:53 [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero Marco Pagani
@ 2022-04-06 14:18 ` Tom Rix
2022-04-07 2:09 ` Xu Yilun
2022-04-20 4:24 ` Moritz Fischer
1 sibling, 1 reply; 5+ messages in thread
From: Tom Rix @ 2022-04-06 14:18 UTC (permalink / raw)
To: Marco Pagani, Moritz Fischer, Wu Hao, Xu Yilun; +Cc: linux-fpga, linux-kernel
On 4/5/22 11:53 AM, Marco Pagani wrote:
> Fix the "comparison with less than zero" warning reported by
> cppcheck for the unsigned (size_t) parameter "count" of the
> "alt_pr_fpga_write()" function.
>
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> ---
> drivers/fpga/altera-pr-ip-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> index be0667968d33..2ff3d8e46a0c 100644
> --- a/drivers/fpga/altera-pr-ip-core.c
> +++ b/drivers/fpga/altera-pr-ip-core.c
> @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
> u32 *buffer_32 = (u32 *)buf;
> size_t i = 0;
>
> - if (count <= 0)
> + if (count == 0)
> return -EINVAL;
Reviewed-by: Tom Rix <trix@redhat.com>
>
> /* Write out the complete 32-bit chunks */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero
2022-04-06 14:18 ` Tom Rix
@ 2022-04-07 2:09 ` Xu Yilun
0 siblings, 0 replies; 5+ messages in thread
From: Xu Yilun @ 2022-04-07 2:09 UTC (permalink / raw)
To: Tom Rix; +Cc: Marco Pagani, Moritz Fischer, Wu Hao, linux-fpga, linux-kernel
On Wed, Apr 06, 2022 at 07:18:21AM -0700, Tom Rix wrote:
>
> On 4/5/22 11:53 AM, Marco Pagani wrote:
> > Fix the "comparison with less than zero" warning reported by
> > cppcheck for the unsigned (size_t) parameter "count" of the
> > "alt_pr_fpga_write()" function.
> >
> > Signed-off-by: Marco Pagani <marpagan@redhat.com>
> > ---
> > drivers/fpga/altera-pr-ip-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> > index be0667968d33..2ff3d8e46a0c 100644
> > --- a/drivers/fpga/altera-pr-ip-core.c
> > +++ b/drivers/fpga/altera-pr-ip-core.c
> > @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
> > u32 *buffer_32 = (u32 *)buf;
> > size_t i = 0;
> > - if (count <= 0)
> > + if (count == 0)
> > return -EINVAL;
>
> Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
>
> > /* Write out the complete 32-bit chunks */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero
2022-04-05 18:53 [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero Marco Pagani
2022-04-06 14:18 ` Tom Rix
@ 2022-04-20 4:24 ` Moritz Fischer
2022-04-22 15:47 ` Marco Pagani
1 sibling, 1 reply; 5+ messages in thread
From: Moritz Fischer @ 2022-04-20 4:24 UTC (permalink / raw)
To: Marco Pagani
Cc: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix, linux-fpga, linux-kernel
Marco,
On Tue, Apr 05, 2022 at 08:53:49PM +0200, Marco Pagani wrote:
> Fix the "comparison with less than zero" warning reported by
> cppcheck for the unsigned (size_t) parameter "count" of the
> "alt_pr_fpga_write()" function.
>
Should this have a Reported-by: tag?
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> ---
> drivers/fpga/altera-pr-ip-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> index be0667968d33..2ff3d8e46a0c 100644
> --- a/drivers/fpga/altera-pr-ip-core.c
> +++ b/drivers/fpga/altera-pr-ip-core.c
> @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
> u32 *buffer_32 = (u32 *)buf;
> size_t i = 0;
>
> - if (count <= 0)
> + if (count == 0)
> return -EINVAL;
if (!count)
return -EINVAL?
>
> /* Write out the complete 32-bit chunks */
> --
> 2.35.1
Cheers,
Moritz
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero
2022-04-20 4:24 ` Moritz Fischer
@ 2022-04-22 15:47 ` Marco Pagani
0 siblings, 0 replies; 5+ messages in thread
From: Marco Pagani @ 2022-04-22 15:47 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Wu Hao, Xu Yilun, Tom Rix, linux-fpga, linux-kernel
On 2022-04-20 06:24, Moritz Fischer wrote:
> Marco,
>
> On Tue, Apr 05, 2022 at 08:53:49PM +0200, Marco Pagani wrote:
>> Fix the "comparison with less than zero" warning reported by
>> cppcheck for the unsigned (size_t) parameter "count" of the
>> "alt_pr_fpga_write()" function.
>>
> Should this have a Reported-by: tag?
I found this problem using the "cppcheck" tool, as reported in the
commit log. I did not find any previous report of this. Am I missing
something?
>> Signed-off-by: Marco Pagani <marpagan@redhat.com>
>> ---
>> drivers/fpga/altera-pr-ip-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
>> index be0667968d33..2ff3d8e46a0c 100644
>> --- a/drivers/fpga/altera-pr-ip-core.c
>> +++ b/drivers/fpga/altera-pr-ip-core.c
>> @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
>> u32 *buffer_32 = (u32 *)buf;
>> size_t i = 0;
>>
>> - if (count <= 0)
>> + if (count == 0)
>> return -EINVAL;
>
> if (!count)
> return -EINVAL?
Ok, I'll change that in v2.
>>
>> /* Write out the complete 32-bit chunks */
>> --
>> 2.35.1
>
> Cheers,
> Moritz
>>
>
Cheers,
Marco
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-22 15:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 18:53 [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero Marco Pagani
2022-04-06 14:18 ` Tom Rix
2022-04-07 2:09 ` Xu Yilun
2022-04-20 4:24 ` Moritz Fischer
2022-04-22 15:47 ` Marco Pagani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.