[PATCH] dbus-util: fix fixed-array file descriptor check

[PATCH] dbus-util: fix fixed-array file descriptor check

[John Keeping]

The code does not match the comment here since 'n' is the type code for
a signed 16-bit integer.  Change to use the correct type code for file
descriptors to match the intent expressed by the comment.
---
 ell/dbus-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ell/dbus-util.c b/ell/dbus-util.c
index cd8ba7f..b6220d2 100644
--- a/ell/dbus-util.c
+++ b/ell/dbus-util.c
@@ -716,7 +716,7 @@ bool _dbus1_iter_get_fixed_array(struct l_dbus_message_iter *iter,
 	size = get_basic_size(type);
 
 	/* Fail if the array is not a fixed size or contains file descriptors */
-	if (!size || type == 'n')
+	if (!size || type == 'h')
 		return false;
 
 	/*
-- 
2.35.1

Re: [PATCH] dbus-util: fix fixed-array file descriptor check

[Denis Kenzior]

Hi John,

On 4/7/22 06:22, John Keeping wrote:
> The code does not match the comment here since 'n' is the type code for
> a signed 16-bit integer.  Change to use the correct type code for file
> descriptors to match the intent expressed by the comment.
> ---
>   ell/dbus-util.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Nice catch.  Applied, thanks.

Regards,
-Denis