All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Usyskin <alexander.usyskin@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	Vitaly Lubart <vitaly.lubart@intel.com>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Subject: [PATCH 03/20] mei: gsc: setup char driver alive in spite of firmware handshake failure
Date: Thu,  7 Apr 2022 15:58:22 +0300	[thread overview]
Message-ID: <20220407125839.1479249-4-alexander.usyskin@intel.com> (raw)
In-Reply-To: <20220407125839.1479249-1-alexander.usyskin@intel.com>

Setup char device in spite of firmware handshake failure.
In order to provide host access to the firmware status registers and other
information required for the manufacturing process.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/misc/mei/gsc-me.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
index 64b02adf3149..58e39c00f150 100644
--- a/drivers/misc/mei/gsc-me.c
+++ b/drivers/misc/mei/gsc-me.c
@@ -79,11 +79,12 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
 	pm_runtime_set_active(device);
 	pm_runtime_enable(device);
 
-	if (mei_start(dev)) {
-		dev_err(device, "init hw failure.\n");
-		ret = -ENODEV;
-		goto irq_err;
-	}
+	/* Continue to char device setup in spite of firmware handshake failure.
+	 * In order to provide access to the firmware status registers to the user
+	 * space via sysfs.
+	 */
+	if (mei_start(dev))
+		dev_warn(device, "init hw failure.\n");
 
 	pm_runtime_set_autosuspend_delay(device, MEI_GSC_RPM_TIMEOUT);
 	pm_runtime_use_autosuspend(device);
@@ -97,7 +98,6 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
 
 register_err:
 	mei_stop(dev);
-irq_err:
 	devm_free_irq(device, hw->irq, dev);
 
 err:
-- 
2.32.0


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Usyskin <alexander.usyskin@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-kernel@vger.kernel.org,
	Tomas Winkler <tomas.winkler@intel.com>,
	Vitaly Lubart <vitaly.lubart@intel.com>
Subject: [Intel-gfx] [PATCH 03/20] mei: gsc: setup char driver alive in spite of firmware handshake failure
Date: Thu,  7 Apr 2022 15:58:22 +0300	[thread overview]
Message-ID: <20220407125839.1479249-4-alexander.usyskin@intel.com> (raw)
In-Reply-To: <20220407125839.1479249-1-alexander.usyskin@intel.com>

Setup char device in spite of firmware handshake failure.
In order to provide host access to the firmware status registers and other
information required for the manufacturing process.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/misc/mei/gsc-me.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
index 64b02adf3149..58e39c00f150 100644
--- a/drivers/misc/mei/gsc-me.c
+++ b/drivers/misc/mei/gsc-me.c
@@ -79,11 +79,12 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
 	pm_runtime_set_active(device);
 	pm_runtime_enable(device);
 
-	if (mei_start(dev)) {
-		dev_err(device, "init hw failure.\n");
-		ret = -ENODEV;
-		goto irq_err;
-	}
+	/* Continue to char device setup in spite of firmware handshake failure.
+	 * In order to provide access to the firmware status registers to the user
+	 * space via sysfs.
+	 */
+	if (mei_start(dev))
+		dev_warn(device, "init hw failure.\n");
 
 	pm_runtime_set_autosuspend_delay(device, MEI_GSC_RPM_TIMEOUT);
 	pm_runtime_use_autosuspend(device);
@@ -97,7 +98,6 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
 
 register_err:
 	mei_stop(dev);
-irq_err:
 	devm_free_irq(device, hw->irq, dev);
 
 err:
-- 
2.32.0


  parent reply	other threads:[~2022-04-07 12:59 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 12:58 [PATCH 00/20] GSC support for XeHP SDV and DG2 platforms Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] " Alexander Usyskin
2022-04-07 12:58 ` [PATCH 01/20] drm/i915/gsc: add gsc as a mei auxiliary device Alexander Usyskin
2022-04-07 12:58   ` [Intel-gfx] " Alexander Usyskin
2022-04-07 12:58 ` [PATCH 02/20] mei: add support for graphics system controller (gsc) devices Alexander Usyskin
2022-04-07 12:58   ` [Intel-gfx] " Alexander Usyskin
2022-04-07 12:58 ` Alexander Usyskin [this message]
2022-04-07 12:58   ` [Intel-gfx] [PATCH 03/20] mei: gsc: setup char driver alive in spite of firmware handshake failure Alexander Usyskin
2022-04-07 12:58 ` [PATCH 04/20] mei: gsc: add runtime pm handlers Alexander Usyskin
2022-04-07 12:58   ` [Intel-gfx] " Alexander Usyskin
2022-04-07 12:58 ` [PATCH 05/20] mei: gsc: retrieve the firmware version Alexander Usyskin
2022-04-07 12:58   ` [Intel-gfx] " Alexander Usyskin
2022-04-07 12:58 ` [PATCH 06/20] HAX: drm/i915: force INTEL_MEI_GSC on for CI Alexander Usyskin
2022-04-07 12:58   ` [Intel-gfx] " Alexander Usyskin
2022-04-07 12:58 ` [PATCH 07/20] drm/i915/gsc: skip irq initialization if using polling Alexander Usyskin
2022-04-07 12:58   ` [Intel-gfx] " Alexander Usyskin
2022-04-11 21:30   ` Ceraolo Spurio, Daniele
2022-04-11 21:30     ` Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device Alexander Usyskin
2022-04-07 12:58   ` [Intel-gfx] " Alexander Usyskin
2022-04-11 21:34   ` Ceraolo Spurio, Daniele
2022-04-11 21:34     ` Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [Intel-gfx] [PATCH 09/20] drm/i915/gsc: add slow_fw flag to the gsc device definition Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-11 21:36   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-11 21:36     ` Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [Intel-gfx] [PATCH 10/20] drm/i915/gsc: add GSC XeHP SDV platform definition Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 11/20] mei: gsc: use polling instead of interrupts Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 12/20] mei: gsc: wait for reset thread on stop Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 13/20] mei: extend timeouts on slow devices Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 14/20] drm/i915/dg2: add gsc with special gsc bar offsets Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-13 19:12   ` [Intel-gfx] " Ceraolo Spurio, Daniele
2022-04-13 19:12     ` Ceraolo Spurio, Daniele
2022-04-07 12:58 ` [Intel-gfx] [PATCH 15/20] mei: bus: export common mkhi definitions into a separate header Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 16/20] mei: mkhi: add memory ready command Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 17/20] mei: gsc: setup gsc extended operational memory Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 18/20] mei: gsc: add transition to PXP mode in resume flow Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 19/20] mei: debugfs: add pxp mode to devstate in debugfs Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-07 12:58 ` [Intel-gfx] [PATCH 20/20] drm/i915/gsc: allocate extended operational memory in LMEM Alexander Usyskin
2022-04-07 12:58   ` Alexander Usyskin
2022-04-08 10:54   ` [Intel-gfx] " Matthew Auld
2022-04-08 10:54     ` Matthew Auld
2022-04-07 16:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 platforms Patchwork
2022-04-07 16:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-04-07 16:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407125839.1479249-4-alexander.usyskin@intel.com \
    --to=alexander.usyskin@intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tomas.winkler@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=vitaly.lubart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.