All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/5] Tidy up symbol end fixup
@ 2022-04-07 23:04 ` Ian Rogers
  0 siblings, 0 replies; 20+ messages in thread
From: Ian Rogers @ 2022-04-07 23:04 UTC (permalink / raw)
  To: John Garry, Will Deacon, Mathieu Poirier, Leo Yan,
	Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
	James Clark, Alexandre Truong, German Gomez, Ian Rogers,
	Dave Marchevsky, Song Liu, Ravi Bangoria, Li Huafei,
	Martin Liška, William Cohen, Riccardo Mancini,
	Masami Hiramatsu, Thomas Richter, Lexi Shao, Remi Bernon,
	Michael Petlan, Denis Nikitin, linux-arm-kernel,
	linux-perf-users, linux-kernel
  Cc: Stephane Eranian

Fixing up more symbol ends as introduced in:
https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/
caused perf annotate to run into memory limits - every symbol holds
all the disassembled code in the annotation, and so making symbols
ends further away dramatically increased memory usage (40MB to
 >1GB). Modify the symbol end logic so that special kernel cases aren't
applied in the common case.

Minor fix to perf annotate to not stall when stderr is full.

Ian Rogers (5):
  perf annotate: Drop objdump stderr
  perf symbols: Always do architecture specific fixups
  perf symbols: Add is_kernel argument to fixup end
  perf symbol: By default only fix zero length symbols
  perf symbols: More specific architecture end fixing

 tools/perf/arch/arm64/util/machine.c   | 14 +++++++++-----
 tools/perf/arch/powerpc/util/machine.c | 10 +++++++---
 tools/perf/arch/s390/util/machine.c    | 12 ++++++++----
 tools/perf/util/annotate.c             |  1 +
 tools/perf/util/symbol-elf.c           |  2 +-
 tools/perf/util/symbol.c               | 14 ++++++++------
 tools/perf/util/symbol.h               |  4 ++--
 7 files changed, 36 insertions(+), 21 deletions(-)

-- 
2.35.1.1178.g4f1659d476-goog


^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-04-12  9:30 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 23:04 [PATCH 0/5] Tidy up symbol end fixup Ian Rogers
2022-04-07 23:04 ` Ian Rogers
2022-04-07 23:04 ` [PATCH 1/5] perf annotate: Drop objdump stderr Ian Rogers
2022-04-07 23:04   ` Ian Rogers
2022-04-09 15:44   ` Arnaldo Carvalho de Melo
2022-04-09 15:44     ` Arnaldo Carvalho de Melo
2022-04-07 23:05 ` [PATCH 2/5] perf symbols: Always do architecture specific fixups Ian Rogers
2022-04-07 23:05   ` Ian Rogers
2022-04-07 23:05 ` [PATCH 3/5] perf symbols: Add is_kernel argument to fixup end Ian Rogers
2022-04-07 23:05   ` Ian Rogers
2022-04-12  7:58   ` [perf symbols] 309f68878e: perf-sanity-tests.perf.make_fail kernel test robot
2022-04-12  7:58     ` kernel test robot
2022-04-07 23:05 ` [PATCH 4/5] perf symbol: By default only fix zero length symbols Ian Rogers
2022-04-07 23:05   ` Ian Rogers
2022-04-07 23:05 ` [PATCH 5/5] perf symbols: More specific architecture end fixing Ian Rogers
2022-04-07 23:05   ` Ian Rogers
2022-04-08 17:15 ` [PATCH 0/5] Tidy up symbol end fixup Namhyung Kim
2022-04-08 17:15   ` Namhyung Kim
2022-04-08 23:52   ` Ian Rogers
2022-04-08 23:52     ` Ian Rogers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.