* [PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume()
@ 2022-04-08 3:09 ` Yang Yingliang
0 siblings, 0 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-04-08 3:09 UTC (permalink / raw)
To: linux-kernel, netdev, linux-wireless, ath11k
Cc: quic_kvalo, quic_cjhuang, davem, kuba
Add the missing unlock before return from function ath11k_wow_op_resume()
in the error handling case.
Fixes: 90bf5c8d0f7e ("ath11k: purge rx pktlog when entering WoW")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/wireless/ath/ath11k/wow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/wow.c b/drivers/net/wireless/ath/ath11k/wow.c
index 6c2611f93739..9d088cebef03 100644
--- a/drivers/net/wireless/ath/ath11k/wow.c
+++ b/drivers/net/wireless/ath/ath11k/wow.c
@@ -758,7 +758,7 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
ret = ath11k_dp_rx_pktlog_start(ar->ab);
if (ret) {
ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret);
- return ret;
+ goto exit;
}
ret = ath11k_wow_wakeup(ar->ab);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume()
@ 2022-04-08 3:09 ` Yang Yingliang
0 siblings, 0 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-04-08 3:09 UTC (permalink / raw)
To: linux-kernel, netdev, linux-wireless, ath11k
Cc: quic_kvalo, quic_cjhuang, davem, kuba
Add the missing unlock before return from function ath11k_wow_op_resume()
in the error handling case.
Fixes: 90bf5c8d0f7e ("ath11k: purge rx pktlog when entering WoW")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/wireless/ath/ath11k/wow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/wow.c b/drivers/net/wireless/ath/ath11k/wow.c
index 6c2611f93739..9d088cebef03 100644
--- a/drivers/net/wireless/ath/ath11k/wow.c
+++ b/drivers/net/wireless/ath/ath11k/wow.c
@@ -758,7 +758,7 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
ret = ath11k_dp_rx_pktlog_start(ar->ab);
if (ret) {
ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret);
- return ret;
+ goto exit;
}
ret = ath11k_wow_wakeup(ar->ab);
--
2.25.1
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume()
2022-04-08 3:09 ` Yang Yingliang
@ 2022-04-23 9:28 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2022-04-23 9:28 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, netdev, linux-wireless, ath11k, quic_kvalo,
quic_cjhuang, davem, kuba
Yang Yingliang <yangyingliang@huawei.com> wrote:
> Add the missing unlock before return from function ath11k_wow_op_resume()
> in the error handling case.
>
> Fixes: 90bf5c8d0f7e ("ath11k: purge rx pktlog when entering WoW")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
605194411d73 ath11k: fix missing unlock on error in ath11k_wow_op_resume()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume()
@ 2022-04-23 9:28 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2022-04-23 9:28 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, netdev, linux-wireless, ath11k, quic_kvalo,
quic_cjhuang, davem, kuba
Yang Yingliang <yangyingliang@huawei.com> wrote:
> Add the missing unlock before return from function ath11k_wow_op_resume()
> in the error handling case.
>
> Fixes: 90bf5c8d0f7e ("ath11k: purge rx pktlog when entering WoW")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
605194411d73 ath11k: fix missing unlock on error in ath11k_wow_op_resume()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220408030912.3087293-1-yangyingliang@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-23 9:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 3:09 [PATCH -next] ath11k: fix missing unlock on error in ath11k_wow_op_resume() Yang Yingliang
2022-04-08 3:09 ` Yang Yingliang
2022-04-23 9:28 ` Kalle Valo
2022-04-23 9:28 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.