[PATCH] net: fix irqf_oneshot.cocci warnings

[PATCH] net: fix irqf_oneshot.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-arm-kernel(a)lists.infradead.org
TO: Russell King <rmk+kernel@armlinux.org.uk>
CC: Andrew Lunn <andrew@lunn.ch>
CC: Heiner Kallweit <hkallweit1@gmail.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Paolo Abeni <pabeni@redhat.com>
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/net/phy/qsfp.c:1750:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

CC: Russell King <rmk+kernel@armlinux.org.uk>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git cex7
head:   d4b5e6687e034b7408f75fcbeccda90fd424b853
commit: 15b70689e8853e6983ab01bad883aca045d7b4ae [143/148] net: add qsfp support                              [*experimental*]
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/net/phy/qsfp.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/net/phy/qsfp.c
+++ b/drivers/net/phy/qsfp.c
@@ -1748,7 +1748,8 @@ static int qsfp_probe(struct platform_de
 		}
 
 		err = devm_request_threaded_irq(qsfp->dev, qsfp->gpio_irq[i],
-						NULL, irq_handler, irq_flags,
+						NULL, irq_handler,
+						irq_flags | IRQF_ONESHOT,
 						dev_name(qsfp->dev), qsfp);
 		if (err) {
 			qsfp->gpio_irq[i] = 0;

[arm:cex7 143/148] drivers/net/phy/qsfp.c:1750:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-arm-kernel(a)lists.infradead.org
TO: Russell King <rmk+kernel@armlinux.org.uk>

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git cex7
head:   d4b5e6687e034b7408f75fcbeccda90fd424b853
commit: 15b70689e8853e6983ab01bad883aca045d7b4ae [143/148] net: add qsfp support                              [*experimental*]
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago
config: microblaze-randconfig-c024-20220408 (https://download.01.org/0day-ci/archive/20220408/202204081109.2CqiF4YR-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/net/phy/qsfp.c:1750:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp