* [PATCH] bus: imx-weim: Mark weim_of_notifier static
@ 2022-04-11 2:56 Shawn Guo
2022-04-11 7:45 ` Ivan Bornyakov
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2022-04-11 2:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Ivan Bornyakov, Shawn Guo, kernel test robot
Mark weim_of_notifier static to fix the sparse warning below.
drivers/bus/imx-weim.c:373:23: sparse: sparse: symbol 'weim_of_notifier'
was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Fixes: e6cb5408289f ("bus: imx-weim: add DT overlay support for WEIM bus")
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 60fbd42041dd..d10c9f1031b6 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -370,7 +370,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
return ret;
}
-struct notifier_block weim_of_notifier = {
+static struct notifier_block weim_of_notifier = {
.notifier_call = of_weim_notify,
};
#endif /* IS_ENABLED(CONFIG_OF_DYNAMIC) */
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: Mark weim_of_notifier static
2022-04-11 2:56 [PATCH] bus: imx-weim: Mark weim_of_notifier static Shawn Guo
@ 2022-04-11 7:45 ` Ivan Bornyakov
2022-04-11 8:06 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Bornyakov @ 2022-04-11 7:45 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, kernel test robot, weiyongjun1
Hi, Shawn!
On Mon, Apr 11, 2022 at 10:56:18AM +0800, Shawn Guo wrote:
> Mark weim_of_notifier static to fix the sparse warning below.
>
> drivers/bus/imx-weim.c:373:23: sparse: sparse: symbol 'weim_of_notifier'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: e6cb5408289f ("bus: imx-weim: add DT overlay support for WEIM bus")
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> ---
> drivers/bus/imx-weim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42041dd..d10c9f1031b6 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -370,7 +370,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
> return ret;
> }
>
> -struct notifier_block weim_of_notifier = {
> +static struct notifier_block weim_of_notifier = {
> .notifier_call = of_weim_notify,
> };
> #endif /* IS_ENABLED(CONFIG_OF_DYNAMIC) */
> --
> 2.25.1
>
There was a similar patch already.
See: https://lore.kernel.org/all/20220226094333.3269016-1-weiyongjun1@huawei.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: Mark weim_of_notifier static
2022-04-11 7:45 ` Ivan Bornyakov
@ 2022-04-11 8:06 ` Shawn Guo
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-04-11 8:06 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: linux-arm-kernel, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, kernel test robot, weiyongjun1
On Mon, Apr 11, 2022 at 10:45:25AM +0300, Ivan Bornyakov wrote:
> Hi, Shawn!
>
> On Mon, Apr 11, 2022 at 10:56:18AM +0800, Shawn Guo wrote:
> > Mark weim_of_notifier static to fix the sparse warning below.
> >
> > drivers/bus/imx-weim.c:373:23: sparse: sparse: symbol 'weim_of_notifier'
> > was not declared. Should it be static?
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: e6cb5408289f ("bus: imx-weim: add DT overlay support for WEIM bus")
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> > drivers/bus/imx-weim.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> > index 60fbd42041dd..d10c9f1031b6 100644
> > --- a/drivers/bus/imx-weim.c
> > +++ b/drivers/bus/imx-weim.c
> > @@ -370,7 +370,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
> > return ret;
> > }
> >
> > -struct notifier_block weim_of_notifier = {
> > +static struct notifier_block weim_of_notifier = {
> > .notifier_call = of_weim_notify,
> > };
> > #endif /* IS_ENABLED(CONFIG_OF_DYNAMIC) */
> > --
> > 2.25.1
> >
>
> There was a similar patch already.
> See: https://lore.kernel.org/all/20220226094333.3269016-1-weiyongjun1@huawei.com/
Ah, for some reason, the patch did not appear in my mailbox. Thanks for
point it to me! Applied that instead.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-11 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 2:56 [PATCH] bus: imx-weim: Mark weim_of_notifier static Shawn Guo
2022-04-11 7:45 ` Ivan Bornyakov
2022-04-11 8:06 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.