[PATCH] pthread_atfork.3: Remove a confusing reference to the current thread

[PATCH] pthread_atfork.3: Remove a confusing reference to the current thread

[Arjun Shankar]

The reference to "this thread" in the DESCRIPTION of pthread_atfork(3)
could be incorrectly interpreted to mean that only handlers registered
by the thread calling fork(2) are executed.  Therefore, remove the
reference.

Signed-off-by: Arjun Shankar <arjun@redhat.com>
---
 man3/pthread_atfork.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/pthread_atfork.3 b/man3/pthread_atfork.3
index b727cb48e..db5e210d4 100644
--- a/man3/pthread_atfork.3
+++ b/man3/pthread_atfork.3
@@ -39,7 +39,7 @@ The
 .BR pthread_atfork ()
 function registers fork handlers that are to be executed when
 .BR fork (2)
-is called by this thread.
+is called.
 The handlers are executed in the context of the thread that calls
 .BR fork (2).
 .PP
-- 
2.34.1

Re: [PATCH] pthread_atfork.3: Remove a confusing reference to the current thread

[Florian Weimer]

* Arjun Shankar:

> The reference to "this thread" in the DESCRIPTION of pthread_atfork(3)
> could be incorrectly interpreted to mean that only handlers registered
> by the thread calling fork(2) are executed.  Therefore, remove the
> reference.
>
> Signed-off-by: Arjun Shankar <arjun@redhat.com>
> ---
>  man3/pthread_atfork.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/pthread_atfork.3 b/man3/pthread_atfork.3
> index b727cb48e..db5e210d4 100644
> --- a/man3/pthread_atfork.3
> +++ b/man3/pthread_atfork.3
> @@ -39,7 +39,7 @@ The
>  .BR pthread_atfork ()
>  function registers fork handlers that are to be executed when
>  .BR fork (2)
> -is called by this thread.
> +is called.
>  The handlers are executed in the context of the thread that calls
>  .BR fork (2).
>  .PP

I suspect the intent was to indicate that the handlers are called on the
thread calling fork, but that's probably clear enough from the context?

Thanks,
Florian

Re: [PATCH] pthread_atfork.3: Remove a confusing reference to the current thread

[Arjun Shankar]

> I suspect the intent was to indicate that the handlers are called on the
> thread calling fork, but that's probably clear enough from the context?

Yes, that could have been the intent. It is also mentioned separately
in the second sentence, so that information will not be lost if this
change gets applied.

Re: [PATCH] pthread_atfork.3: Remove a confusing reference to the current thread

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 1328 bytes --]

Hi Arjun,

On 4/12/22 15:55, Arjun Shankar wrote:
> The reference to "this thread" in the DESCRIPTION of pthread_atfork(3)
> could be incorrectly interpreted to mean that only handlers registered
> by the thread calling fork(2) are executed.  Therefore, remove the
> reference.
> 
> Signed-off-by: Arjun Shankar <arjun@redhat.com>

I already applied a different patch recently.  See 
<http://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/man3/pthread_atfork.3?id=f30deb08a9a0db95a3d6b4d00c0927fb43928cc4>.

If you think that can be improved, please send a patch on top of the 
main branch in that repo.

Thanks,

Alex
> ---
>   man3/pthread_atfork.3 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man3/pthread_atfork.3 b/man3/pthread_atfork.3
> index b727cb48e..db5e210d4 100644
> --- a/man3/pthread_atfork.3
> +++ b/man3/pthread_atfork.3
> @@ -39,7 +39,7 @@ The
>   .BR pthread_atfork ()
>   function registers fork handlers that are to be executed when
>   .BR fork (2)
> -is called by this thread.
> +is called.
>   The handlers are executed in the context of the thread that calls
>   .BR fork (2).
>   .PP


--
Alejandro Colomar
Linux man-pages comaintainer; http://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH] pthread_atfork.3: Remove a confusing reference to the current thread

[Arjun Shankar]

Hi Alex,

> I already applied a different patch recently.  See
> <http://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/man3/pthread_atfork.3?id=f30deb08a9a0db95a3d6b4d00c0927fb43928cc4>.

I wasn't aware of this repository and therefore missed the change.
I'll keep it in mind.

> If you think that can be improved, please send a patch on top of the
> main branch in that repo.

The commit you mentioned looks good to me. Apologies for the noise and
thanks for looking into this.

Cheers,
Arjun

Re: [PATCH] pthread_atfork.3: Remove a confusing reference to the current thread

[Alejandro Colomar]

Hi Arjun,

On 4/14/22 01:51, Arjun Shankar wrote:
> Hi Alex,
> 
>> I already applied a different patch recently.  See
>> <http://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/man3/pthread_atfork.3?id=f30deb08a9a0db95a3d6b4d00c0927fb43928cc4>.
> 
> I wasn't aware of this repository and therefore missed the change.
> I'll keep it in mind. >
>> If you think that can be improved, please send a patch on top of the
>> main branch in that repo.
> 
> The commit you mentioned looks good to me. Apologies for the noise and
> thanks for looking into this.

No problem.  It's not noise, IMO :-)
It's always nice to have more wording options to consider.

Cheers,

Alex