* [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c
@ 2022-04-12 18:57 Michael Straube
2022-04-12 18:57 ` [PATCH 1/6] staging: r8188eu: correct macro spelling mistake Michael Straube
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Michael Straube @ 2022-04-12 18:57 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
This series cleans up the block_write() function in rtw_fw.c.
I wondered if removing the part that writes 8-byte blocks makes any
notable difference. On my system it took about two seconds longer to
init the device. So I left that as is.
Tested on x86_64 with Inter-Tech DMG-02.
Michael Straube (6):
staging: r8188eu: correct macro spelling mistake
staging: r8188eu: rename parameter of block_write()
staging: r8188eu: change void parameters to u8
staging: r8188eu: reduce variables in block_write()
staging: r8188eu: remove unneeded initializations
staging: r8188eu: clean up long lines in block_write()
drivers/staging/r8188eu/core/rtw_fw.c | 73 ++++++++++++++-------------
1 file changed, 37 insertions(+), 36 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/6] staging: r8188eu: correct macro spelling mistake
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
@ 2022-04-12 18:57 ` Michael Straube
2022-04-12 18:57 ` [PATCH 2/6] staging: r8188eu: rename parameter of block_write() Michael Straube
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-04-12 18:57 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
Correct a macro spelling mistake in rtw_fw.c.
MAX_REG_BOLCK_SIZE -> MAX_REG_BLOCK_SIZE
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 7a0997b9bac5..0905384bafc7 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -4,7 +4,7 @@
#include <linux/firmware.h>
#include "../include/rtw_fw.h"
-#define MAX_REG_BOLCK_SIZE 196
+#define MAX_REG_BLOCK_SIZE 196
#define FW_8188E_START_ADDRESS 0x1000
#define MAX_PAGE_SIZE 4096
@@ -82,7 +82,7 @@ static int block_write(struct adapter *padapter, void *buffer, u32 buffSize)
u8 *bufferPtr = (u8 *)buffer;
u32 i = 0, offset = 0;
- blockSize_p1 = MAX_REG_BOLCK_SIZE;
+ blockSize_p1 = MAX_REG_BLOCK_SIZE;
/* 3 Phase #1 */
blockCount_p1 = buffSize / blockSize_p1;
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/6] staging: r8188eu: rename parameter of block_write()
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
2022-04-12 18:57 ` [PATCH 1/6] staging: r8188eu: correct macro spelling mistake Michael Straube
@ 2022-04-12 18:57 ` Michael Straube
2022-04-13 6:53 ` Greg KH
2022-04-12 18:57 ` [PATCH 3/6] staging: r8188eu: change void parameters to u8 Michael Straube
` (3 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Michael Straube @ 2022-04-12 18:57 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
Rename the parameter buffSize of block_write() to avoid camel case.
buffSize -> size
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 0905384bafc7..5f59acfd8b5d 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -71,7 +71,7 @@ static void fw_download_enable(struct adapter *padapter, bool enable)
}
}
-static int block_write(struct adapter *padapter, void *buffer, u32 buffSize)
+static int block_write(struct adapter *padapter, void *buffer, u32 size)
{
int ret = _SUCCESS;
u32 blockSize_p1 = 4; /* (Default) Phase #1 : PCI muse use 4-byte write to download FW */
@@ -85,8 +85,8 @@ static int block_write(struct adapter *padapter, void *buffer, u32 buffSize)
blockSize_p1 = MAX_REG_BLOCK_SIZE;
/* 3 Phase #1 */
- blockCount_p1 = buffSize / blockSize_p1;
- remainSize_p1 = buffSize % blockSize_p1;
+ blockCount_p1 = size / blockSize_p1;
+ remainSize_p1 = size % blockSize_p1;
for (i = 0; i < blockCount_p1; i++) {
ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * blockSize_p1), blockSize_p1, (bufferPtr + i * blockSize_p1));
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/6] staging: r8188eu: change void parameters to u8
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
2022-04-12 18:57 ` [PATCH 1/6] staging: r8188eu: correct macro spelling mistake Michael Straube
2022-04-12 18:57 ` [PATCH 2/6] staging: r8188eu: rename parameter of block_write() Michael Straube
@ 2022-04-12 18:57 ` Michael Straube
2022-04-12 18:57 ` [PATCH 4/6] staging: r8188eu: reduce variables in block_write() Michael Straube
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-04-12 18:57 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
The second parameter of write_fw(), page_write() and block_write()
is a void pointer, but we always pass an u8 pointer. We can convert
this parameter to an u8 pointer. The pointer is not changed in the
functions, so we can safely remove the local variable bufferPtr.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 5f59acfd8b5d..3cea4e41ab13 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -71,7 +71,7 @@ static void fw_download_enable(struct adapter *padapter, bool enable)
}
}
-static int block_write(struct adapter *padapter, void *buffer, u32 size)
+static int block_write(struct adapter *padapter, u8 *buffer, u32 size)
{
int ret = _SUCCESS;
u32 blockSize_p1 = 4; /* (Default) Phase #1 : PCI muse use 4-byte write to download FW */
@@ -79,7 +79,6 @@ static int block_write(struct adapter *padapter, void *buffer, u32 size)
u32 blockSize_p3 = 1; /* Phase #3 : Use 1-byte, the remnant of FW image. */
u32 blockCount_p1 = 0, blockCount_p2 = 0, blockCount_p3 = 0;
u32 remainSize_p1 = 0, remainSize_p2 = 0;
- u8 *bufferPtr = (u8 *)buffer;
u32 i = 0, offset = 0;
blockSize_p1 = MAX_REG_BLOCK_SIZE;
@@ -89,7 +88,7 @@ static int block_write(struct adapter *padapter, void *buffer, u32 size)
remainSize_p1 = size % blockSize_p1;
for (i = 0; i < blockCount_p1; i++) {
- ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * blockSize_p1), blockSize_p1, (bufferPtr + i * blockSize_p1));
+ ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * blockSize_p1), blockSize_p1, (buffer + i * blockSize_p1));
if (ret == _FAIL)
goto exit;
}
@@ -102,7 +101,7 @@ static int block_write(struct adapter *padapter, void *buffer, u32 size)
remainSize_p2 = remainSize_p1 % blockSize_p2;
for (i = 0; i < blockCount_p2; i++) {
- ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + offset + i * blockSize_p2), blockSize_p2, (bufferPtr + offset + i * blockSize_p2));
+ ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + offset + i * blockSize_p2), blockSize_p2, (buffer + offset + i * blockSize_p2));
if (ret == _FAIL)
goto exit;
@@ -116,7 +115,7 @@ static int block_write(struct adapter *padapter, void *buffer, u32 size)
blockCount_p3 = remainSize_p2 / blockSize_p3;
for (i = 0; i < blockCount_p3; i++) {
- ret = rtw_write8(padapter, (FW_8188E_START_ADDRESS + offset + i), *(bufferPtr + offset + i));
+ ret = rtw_write8(padapter, (FW_8188E_START_ADDRESS + offset + i), *(buffer + offset + i));
if (ret == _FAIL)
goto exit;
@@ -127,7 +126,7 @@ static int block_write(struct adapter *padapter, void *buffer, u32 size)
return ret;
}
-static int page_write(struct adapter *padapter, u32 page, void *buffer, u32 size)
+static int page_write(struct adapter *padapter, u32 page, u8 *buffer, u32 size)
{
u8 value8;
u8 u8Page = (u8)(page & 0x07);
@@ -138,21 +137,20 @@ static int page_write(struct adapter *padapter, u32 page, void *buffer, u32 size
return block_write(padapter, buffer, size);
}
-static int write_fw(struct adapter *padapter, void *buffer, u32 size)
+static int write_fw(struct adapter *padapter, u8 *buffer, u32 size)
{
/* Since we need dynamic decide method of dwonload fw, so we call this function to get chip version. */
/* We can remove _ReadChipVersion from ReadpadapterInfo8192C later. */
int ret = _SUCCESS;
u32 pageNums, remainSize;
u32 page, offset;
- u8 *bufferPtr = (u8 *)buffer;
pageNums = size / MAX_PAGE_SIZE;
remainSize = size % MAX_PAGE_SIZE;
for (page = 0; page < pageNums; page++) {
offset = page * MAX_PAGE_SIZE;
- ret = page_write(padapter, page, bufferPtr + offset, MAX_PAGE_SIZE);
+ ret = page_write(padapter, page, buffer + offset, MAX_PAGE_SIZE);
if (ret == _FAIL)
goto exit;
@@ -160,7 +158,7 @@ static int write_fw(struct adapter *padapter, void *buffer, u32 size)
if (remainSize) {
offset = pageNums * MAX_PAGE_SIZE;
page = pageNums;
- ret = page_write(padapter, page, bufferPtr + offset, remainSize);
+ ret = page_write(padapter, page, buffer + offset, remainSize);
if (ret == _FAIL)
goto exit;
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/6] staging: r8188eu: reduce variables in block_write()
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
` (2 preceding siblings ...)
2022-04-12 18:57 ` [PATCH 3/6] staging: r8188eu: change void parameters to u8 Michael Straube
@ 2022-04-12 18:57 ` Michael Straube
2022-04-12 18:57 ` [PATCH 5/6] staging: r8188eu: remove unneeded initializations Michael Straube
2022-04-12 18:57 ` [PATCH 6/6] staging: r8188eu: clean up long lines in block_write() Michael Straube
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-04-12 18:57 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
For cleaner code and improved readability we can reduce the number
of local variables in block_write(). Use a single variable for block
size, number of blocks and remaining size.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 43 +++++++++++----------------
1 file changed, 18 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 3cea4e41ab13..b4ab050a6f23 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -74,49 +74,42 @@ static void fw_download_enable(struct adapter *padapter, bool enable)
static int block_write(struct adapter *padapter, u8 *buffer, u32 size)
{
int ret = _SUCCESS;
- u32 blockSize_p1 = 4; /* (Default) Phase #1 : PCI muse use 4-byte write to download FW */
- u32 blockSize_p2 = 8; /* Phase #2 : Use 8-byte, if Phase#1 use big size to write FW. */
- u32 blockSize_p3 = 1; /* Phase #3 : Use 1-byte, the remnant of FW image. */
- u32 blockCount_p1 = 0, blockCount_p2 = 0, blockCount_p3 = 0;
- u32 remainSize_p1 = 0, remainSize_p2 = 0;
+ u32 blocks, block_size, remain;
u32 i = 0, offset = 0;
- blockSize_p1 = MAX_REG_BLOCK_SIZE;
+ block_size = MAX_REG_BLOCK_SIZE;
- /* 3 Phase #1 */
- blockCount_p1 = size / blockSize_p1;
- remainSize_p1 = size % blockSize_p1;
+ blocks = size / block_size;
+ remain = size % block_size;
- for (i = 0; i < blockCount_p1; i++) {
- ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * blockSize_p1), blockSize_p1, (buffer + i * blockSize_p1));
+ for (i = 0; i < blocks; i++) {
+ ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * block_size), block_size, (buffer + i * block_size));
if (ret == _FAIL)
goto exit;
}
- /* 3 Phase #2 */
- if (remainSize_p1) {
- offset = blockCount_p1 * blockSize_p1;
+ if (remain) {
+ offset = blocks * block_size;
+ block_size = 8;
- blockCount_p2 = remainSize_p1 / blockSize_p2;
- remainSize_p2 = remainSize_p1 % blockSize_p2;
-
- for (i = 0; i < blockCount_p2; i++) {
- ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + offset + i * blockSize_p2), blockSize_p2, (buffer + offset + i * blockSize_p2));
+ blocks = remain / block_size;
+ remain = remain % block_size;
+ for (i = 0; i < blocks; i++) {
+ ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + offset + i * block_size), block_size, (buffer + offset + i * block_size));
if (ret == _FAIL)
goto exit;
}
}
- /* 3 Phase #3 */
- if (remainSize_p2) {
- offset = (blockCount_p1 * blockSize_p1) + (blockCount_p2 * blockSize_p2);
+ if (remain) {
+ offset += blocks * block_size;
- blockCount_p3 = remainSize_p2 / blockSize_p3;
+ /* block size 1 */
+ blocks = remain;
- for (i = 0; i < blockCount_p3; i++) {
+ for (i = 0; i < blocks; i++) {
ret = rtw_write8(padapter, (FW_8188E_START_ADDRESS + offset + i), *(buffer + offset + i));
-
if (ret == _FAIL)
goto exit;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 5/6] staging: r8188eu: remove unneeded initializations
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
` (3 preceding siblings ...)
2022-04-12 18:57 ` [PATCH 4/6] staging: r8188eu: reduce variables in block_write() Michael Straube
@ 2022-04-12 18:57 ` Michael Straube
2022-04-12 18:57 ` [PATCH 6/6] staging: r8188eu: clean up long lines in block_write() Michael Straube
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-04-12 18:57 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
The variables i and offset in block_write() are set in the code
before they are used. Remove the unneeded initializations.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index b4ab050a6f23..1e930799a0b3 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -75,7 +75,7 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size)
{
int ret = _SUCCESS;
u32 blocks, block_size, remain;
- u32 i = 0, offset = 0;
+ u32 i, offset;
block_size = MAX_REG_BLOCK_SIZE;
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 6/6] staging: r8188eu: clean up long lines in block_write()
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
` (4 preceding siblings ...)
2022-04-12 18:57 ` [PATCH 5/6] staging: r8188eu: remove unneeded initializations Michael Straube
@ 2022-04-12 18:57 ` Michael Straube
5 siblings, 0 replies; 9+ messages in thread
From: Michael Straube @ 2022-04-12 18:57 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
Store the address and the data pointer for calls to rtw_writeN() and
rtw_write8() in local variables. This avoids long lines and improves
readability.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/core/rtw_fw.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_fw.c b/drivers/staging/r8188eu/core/rtw_fw.c
index 1e930799a0b3..8620f3c92b52 100644
--- a/drivers/staging/r8188eu/core/rtw_fw.c
+++ b/drivers/staging/r8188eu/core/rtw_fw.c
@@ -75,7 +75,8 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size)
{
int ret = _SUCCESS;
u32 blocks, block_size, remain;
- u32 i, offset;
+ u32 i, offset, addr;
+ u8 *data;
block_size = MAX_REG_BLOCK_SIZE;
@@ -83,7 +84,10 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size)
remain = size % block_size;
for (i = 0; i < blocks; i++) {
- ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + i * block_size), block_size, (buffer + i * block_size));
+ addr = FW_8188E_START_ADDRESS + i * block_size;
+ data = buffer + i * block_size;
+
+ ret = rtw_writeN(padapter, addr, block_size, data);
if (ret == _FAIL)
goto exit;
}
@@ -96,7 +100,10 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size)
remain = remain % block_size;
for (i = 0; i < blocks; i++) {
- ret = rtw_writeN(padapter, (FW_8188E_START_ADDRESS + offset + i * block_size), block_size, (buffer + offset + i * block_size));
+ addr = FW_8188E_START_ADDRESS + offset + i * block_size;
+ data = buffer + offset + i * block_size;
+
+ ret = rtw_writeN(padapter, addr, block_size, data);
if (ret == _FAIL)
goto exit;
}
@@ -109,7 +116,10 @@ static int block_write(struct adapter *padapter, u8 *buffer, u32 size)
blocks = remain;
for (i = 0; i < blocks; i++) {
- ret = rtw_write8(padapter, (FW_8188E_START_ADDRESS + offset + i), *(buffer + offset + i));
+ addr = FW_8188E_START_ADDRESS + offset + i;
+ data = buffer + offset + i;
+
+ ret = rtw_write8(padapter, addr, *data);
if (ret == _FAIL)
goto exit;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/6] staging: r8188eu: rename parameter of block_write()
2022-04-12 18:57 ` [PATCH 2/6] staging: r8188eu: rename parameter of block_write() Michael Straube
@ 2022-04-13 6:53 ` Greg KH
2022-04-13 6:54 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2022-04-13 6:53 UTC (permalink / raw)
To: Michael Straube; +Cc: Larry.Finger, phil, linux-staging, linux-kernel
On Tue, Apr 12, 2022 at 08:57:50PM +0200, Michael Straube wrote:
> Rename the parameter buffSize of block_write() to avoid camel case.
>
> buffSize -> size
How about "buffSize -> buffer_size"?
That makes more sense, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/6] staging: r8188eu: rename parameter of block_write()
2022-04-13 6:53 ` Greg KH
@ 2022-04-13 6:54 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2022-04-13 6:54 UTC (permalink / raw)
To: Michael Straube; +Cc: Larry.Finger, phil, linux-staging, linux-kernel
On Wed, Apr 13, 2022 at 08:53:44AM +0200, Greg KH wrote:
> On Tue, Apr 12, 2022 at 08:57:50PM +0200, Michael Straube wrote:
> > Rename the parameter buffSize of block_write() to avoid camel case.
> >
> > buffSize -> size
>
> How about "buffSize -> buffer_size"?
>
> That makes more sense, right?
Ah nevermind, it's fine as-is.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-04-13 6:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 18:57 [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c Michael Straube
2022-04-12 18:57 ` [PATCH 1/6] staging: r8188eu: correct macro spelling mistake Michael Straube
2022-04-12 18:57 ` [PATCH 2/6] staging: r8188eu: rename parameter of block_write() Michael Straube
2022-04-13 6:53 ` Greg KH
2022-04-13 6:54 ` Greg KH
2022-04-12 18:57 ` [PATCH 3/6] staging: r8188eu: change void parameters to u8 Michael Straube
2022-04-12 18:57 ` [PATCH 4/6] staging: r8188eu: reduce variables in block_write() Michael Straube
2022-04-12 18:57 ` [PATCH 5/6] staging: r8188eu: remove unneeded initializations Michael Straube
2022-04-12 18:57 ` [PATCH 6/6] staging: r8188eu: clean up long lines in block_write() Michael Straube
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.