[Buildroot] [PATCH 1/1] package/bpftool: needs __sync_*_4 intrisics

[Buildroot] [PATCH 1/1] package/bpftool: needs __sync_*_4 intrisics

[Fabrice Fontaine]

bpftool needs __sync_*_4 intrisics since its addition in commit
3675131e6c654d7536a184db0184fde7a97040e0 and
https://github.com/libbpf/libbpf/commit/b0c3d7133faa55fbcbc19f76f9cc9e183e178c97:

/nvmedata/autobuild/instance-26/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/10.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /nvmedata/autobuild/instance-26/output-1/build/bpftool-v6.7.0/src/libbpf/libbpf.a(libbpf.o): in function `bpf_program__attach_kprobe_opts':
libbpf.c:(.text+0xff88): undefined reference to `__sync_fetch_and_add_4'

Fixes:
 - http://autobuild.buildroot.org/results/919b8351d3783ca30a860df87ae814d5c4b9fd41

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/bpftool/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/bpftool/Config.in b/package/bpftool/Config.in
index a1ef3843e6..461be9e5b4 100644
--- a/package/bpftool/Config.in
+++ b/package/bpftool/Config.in
@@ -10,6 +10,7 @@ config BR2_PACKAGE_BPFTOOL_ARCH_SUPPORTS
 config BR2_PACKAGE_BPFTOOL
 	bool "bpftool"
 	depends on BR2_PACKAGE_BPFTOOL_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_nios2 # binutils
 	depends on BR2_USE_WCHAR # binutils, elfutils
 	depends on !BR2_STATIC_LIBS # elfutils
@@ -24,6 +25,7 @@ config BR2_PACKAGE_BPFTOOL
 
 comment "bpftool needs a uClibc or glibc toolchain w/ wchar, dynamic library, threads, headers >= 4.12"
 	depends on BR2_PACKAGE_BPFTOOL_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_nios2
 	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS \
 		|| !BR2_TOOLCHAIN_HAS_THREADS \
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/bpftool: needs __sync_*_4 intrisics

[Arnout Vandecappelle]

On 12/04/2022 22:48, Fabrice Fontaine wrote:
> bpftool needs __sync_*_4 intrisics since its addition in commit
> 3675131e6c654d7536a184db0184fde7a97040e0 and
> https://github.com/libbpf/libbpf/commit/b0c3d7133faa55fbcbc19f76f9cc9e183e178c97:
> 
> /nvmedata/autobuild/instance-26/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/10.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /nvmedata/autobuild/instance-26/output-1/build/bpftool-v6.7.0/src/libbpf/libbpf.a(libbpf.o): in function `bpf_program__attach_kprobe_opts':
> libbpf.c:(.text+0xff88): undefined reference to `__sync_fetch_and_add_4'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/919b8351d3783ca30a860df87ae814d5c4b9fd41
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/bpftool/Config.in | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/bpftool/Config.in b/package/bpftool/Config.in
> index a1ef3843e6..461be9e5b4 100644
> --- a/package/bpftool/Config.in
> +++ b/package/bpftool/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_BPFTOOL_ARCH_SUPPORTS
>   config BR2_PACKAGE_BPFTOOL
>   	bool "bpftool"
>   	depends on BR2_PACKAGE_BPFTOOL_ARCH_SUPPORTS
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>   	depends on !BR2_nios2 # binutils
>   	depends on BR2_USE_WCHAR # binutils, elfutils
>   	depends on !BR2_STATIC_LIBS # elfutils
> @@ -24,6 +25,7 @@ config BR2_PACKAGE_BPFTOOL
>   
>   comment "bpftool needs a uClibc or glibc toolchain w/ wchar, dynamic library, threads, headers >= 4.12"
>   	depends on BR2_PACKAGE_BPFTOOL_ARCH_SUPPORTS
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>   	depends on !BR2_nios2
>   	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS \
>   		|| !BR2_TOOLCHAIN_HAS_THREADS \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/bpftool: needs __sync_*_4 intrisics

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > bpftool needs __sync_*_4 intrisics since its addition in commit
 > 3675131e6c654d7536a184db0184fde7a97040e0 and
 > https://github.com/libbpf/libbpf/commit/b0c3d7133faa55fbcbc19f76f9cc9e183e178c97:

 > /nvmedata/autobuild/instance-26/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/10.3.0/../../../../sparc-buildroot-linux-uclibc/bin/ld:
 > /nvmedata/autobuild/instance-26/output-1/build/bpftool-v6.7.0/src/libbpf/libbpf.a(libbpf.o):
 > in function `bpf_program__attach_kprobe_opts':
 > libbpf.c:(.text+0xff88): undefined reference to `__sync_fetch_and_add_4'

 > Fixes:
 >  - http://autobuild.buildroot.org/results/919b8351d3783ca30a860df87ae814d5c4b9fd41

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot