* + ipc-sem-remove-redundant-assignments.patch added to -mm tree
@ 2022-04-12 22:12 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-04-12 22:12 UTC (permalink / raw)
To: mm-commits, trix, ndesaulniers, nathan, michalorzel.eng, akpm
The patch titled
Subject: ipc/sem: Remove redundant assignments
has been added to the -mm tree. Its filename is
ipc-sem-remove-redundant-assignments.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/ipc-sem-remove-redundant-assignments.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/ipc-sem-remove-redundant-assignments.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Michal Orzel <michalorzel.eng@gmail.com>
Subject: ipc/sem: Remove redundant assignments
Get rid of redundant assignments which end up in values not being
read either because they are overwritten or the function ends.
Reported by clang-tidy [deadcode.DeadStores]
Link: https://lkml.kernel.org/r/20220409101933.207157-1-michalorzel.eng@gmail.com
Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Reviewed-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/ipc/sem.c~ipc-sem-remove-redundant-assignments
+++ a/ipc/sem.c
@@ -766,7 +766,6 @@ static int perform_atomic_semop(struct s
for (sop = sops; sop < sops + nsops; sop++) {
curr = &sma->sems[sop->sem_num];
sem_op = sop->sem_op;
- result = curr->semval;
if (sop->sem_flg & SEM_UNDO) {
int undo = un->semadj[sop->sem_num] - sem_op;
@@ -1430,7 +1429,6 @@ static int semctl_main(struct ipc_namesp
if (err)
goto out_rcu_wakeup;
- err = -EACCES;
switch (cmd) {
case GETALL:
{
_
Patches currently in -mm which might be from michalorzel.eng@gmail.com are
kexec-remove-redundant-assignments.patch
ipc-sem-remove-redundant-assignments.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-12 23:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 22:12 + ipc-sem-remove-redundant-assignments.patch added to -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.