* [PATCH] wl18xx: debugfs: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-13 9:33 cgel.zte
2022-04-23 12:43 ` wl18xx: debugfs: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-13 9:33 UTC (permalink / raw)
To: kvalo
Cc: davem, kuba, pabeni, linux-wireless, netdev, linux-kernel,
Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Using pm_runtime_resume_and_get is more appropriate
for simplifing code
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/net/wireless/ti/wl18xx/debugfs.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/ti/wl18xx/debugfs.c b/drivers/net/wireless/ti/wl18xx/debugfs.c
index 2f921a44f1e2..80fbf740fe6d 100644
--- a/drivers/net/wireless/ti/wl18xx/debugfs.c
+++ b/drivers/net/wireless/ti/wl18xx/debugfs.c
@@ -264,11 +264,9 @@ static ssize_t radar_detection_write(struct file *file,
if (unlikely(wl->state != WLCORE_STATE_ON))
goto out;
- ret = pm_runtime_get_sync(wl->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(wl->dev);
+ ret = pm_runtime_resume_and_get(wl->dev);
+ if (ret < 0)
goto out;
- }
ret = wl18xx_cmd_radar_detection_debug(wl, channel);
if (ret < 0)
@@ -306,11 +304,9 @@ static ssize_t dynamic_fw_traces_write(struct file *file,
if (unlikely(wl->state != WLCORE_STATE_ON))
goto out;
- ret = pm_runtime_get_sync(wl->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(wl->dev);
+ ret = pm_runtime_resume_and_get(wl->dev);
+ if (ret < 0)
goto out;
- }
ret = wl18xx_acx_dynamic_fw_traces(wl);
if (ret < 0)
@@ -368,11 +364,9 @@ static ssize_t radar_debug_mode_write(struct file *file,
if (unlikely(wl->state != WLCORE_STATE_ON))
goto out;
- ret = pm_runtime_get_sync(wl->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(wl->dev);
+ ret = pm_runtime_resume_and_get(wl->dev);
+ if (ret < 0)
goto out;
- }
wl12xx_for_each_wlvif_ap(wl, wlvif) {
wlcore_cmd_generic_cfg(wl, wlvif,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: wl18xx: debugfs: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
2022-04-13 9:33 [PATCH] wl18xx: debugfs: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
@ 2022-04-23 12:43 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-04-23 12:43 UTC (permalink / raw)
To: cgel.zte
Cc: davem, kuba, pabeni, linux-wireless, netdev, linux-kernel,
Minghao Chi, Zeal Robot
cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Patch applied to wireless-next.git, thanks.
8e95061b5b9c wl18xx: debugfs: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220413093356.2538192-1-chi.minghao@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-23 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 9:33 [PATCH] wl18xx: debugfs: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-04-23 12:43 ` wl18xx: debugfs: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.