* [PATCH] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
@ 2022-04-13 9:35 ` Sudeep Holla
0 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2022-04-13 9:35 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Sudeep Holla, devicetree, Liviu Dudau, Lorenzo Pieralisi,
Mike Leach, Robin Murphy
The SCMI power domain ID for all the coresight components is 8 while
the previous/older SCPI domain was 0. When adding SCMI variant, couple
of instances retained SCPI domain ID by mistake.
Fix the same by using the correct SCMI power domain ID of 8.
Fixes: 96bb0954860a ("arm64: dts: juno: Add separate SCMI variants")
Reported-by: Mike Leach <Mike.Leach@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm64/boot/dts/arm/juno-r1-scmi.dts | 4 ++--
arch/arm64/boot/dts/arm/juno-r2-scmi.dts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
index 190a0fba4ad6..fd1f0d26d751 100644
--- a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
+++ b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
@@ -7,11 +7,11 @@ funnel@20130000 {
};
etf@20140000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
funnel@20150000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
};
diff --git a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
index dbf13770084f..35e6d4762c46 100644
--- a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
+++ b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
@@ -7,11 +7,11 @@ funnel@20130000 {
};
etf@20140000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
funnel@20150000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
};
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
@ 2022-04-13 9:35 ` Sudeep Holla
0 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2022-04-13 9:35 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Sudeep Holla, devicetree, Liviu Dudau, Lorenzo Pieralisi,
Mike Leach, Robin Murphy
The SCMI power domain ID for all the coresight components is 8 while
the previous/older SCPI domain was 0. When adding SCMI variant, couple
of instances retained SCPI domain ID by mistake.
Fix the same by using the correct SCMI power domain ID of 8.
Fixes: 96bb0954860a ("arm64: dts: juno: Add separate SCMI variants")
Reported-by: Mike Leach <Mike.Leach@arm.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm64/boot/dts/arm/juno-r1-scmi.dts | 4 ++--
arch/arm64/boot/dts/arm/juno-r2-scmi.dts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
index 190a0fba4ad6..fd1f0d26d751 100644
--- a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
+++ b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
@@ -7,11 +7,11 @@ funnel@20130000 {
};
etf@20140000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
funnel@20150000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
};
diff --git a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
index dbf13770084f..35e6d4762c46 100644
--- a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
+++ b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
@@ -7,11 +7,11 @@ funnel@20130000 {
};
etf@20140000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
funnel@20150000 {
- power-domains = <&scmi_devpd 0>;
+ power-domains = <&scmi_devpd 8>;
};
};
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
2022-04-13 9:35 ` Sudeep Holla
@ 2022-04-13 10:07 ` Robin Murphy
-1 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2022-04-13 10:07 UTC (permalink / raw)
To: Sudeep Holla, linux-arm-kernel
Cc: devicetree, Liviu Dudau, Lorenzo Pieralisi, Mike Leach
On 2022-04-13 10:35, Sudeep Holla wrote:
> The SCMI power domain ID for all the coresight components is 8 while
> the previous/older SCPI domain was 0. When adding SCMI variant, couple
> of instances retained SCPI domain ID by mistake.
>
> Fix the same by using the correct SCMI power domain ID of 8.
Indeed, this is my copy-paste bug (annoyingly, from doing something
inexplicable when I *did* have the correct thing as a starting point...)
Acked-by: Robin Murphy <robin.murphy@arm.com>
> Fixes: 96bb0954860a ("arm64: dts: juno: Add separate SCMI variants")
> Reported-by: Mike Leach <Mike.Leach@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm64/boot/dts/arm/juno-r1-scmi.dts | 4 ++--
> arch/arm64/boot/dts/arm/juno-r2-scmi.dts | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
> index 190a0fba4ad6..fd1f0d26d751 100644
> --- a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
> +++ b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
> @@ -7,11 +7,11 @@ funnel@20130000 {
> };
>
> etf@20140000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
>
> funnel@20150000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
> index dbf13770084f..35e6d4762c46 100644
> --- a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
> +++ b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
> @@ -7,11 +7,11 @@ funnel@20130000 {
> };
>
> etf@20140000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
>
> funnel@20150000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
@ 2022-04-13 10:07 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2022-04-13 10:07 UTC (permalink / raw)
To: Sudeep Holla, linux-arm-kernel
Cc: devicetree, Liviu Dudau, Lorenzo Pieralisi, Mike Leach
On 2022-04-13 10:35, Sudeep Holla wrote:
> The SCMI power domain ID for all the coresight components is 8 while
> the previous/older SCPI domain was 0. When adding SCMI variant, couple
> of instances retained SCPI domain ID by mistake.
>
> Fix the same by using the correct SCMI power domain ID of 8.
Indeed, this is my copy-paste bug (annoyingly, from doing something
inexplicable when I *did* have the correct thing as a starting point...)
Acked-by: Robin Murphy <robin.murphy@arm.com>
> Fixes: 96bb0954860a ("arm64: dts: juno: Add separate SCMI variants")
> Reported-by: Mike Leach <Mike.Leach@arm.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm64/boot/dts/arm/juno-r1-scmi.dts | 4 ++--
> arch/arm64/boot/dts/arm/juno-r2-scmi.dts | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
> index 190a0fba4ad6..fd1f0d26d751 100644
> --- a/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
> +++ b/arch/arm64/boot/dts/arm/juno-r1-scmi.dts
> @@ -7,11 +7,11 @@ funnel@20130000 {
> };
>
> etf@20140000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
>
> funnel@20150000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
> index dbf13770084f..35e6d4762c46 100644
> --- a/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
> +++ b/arch/arm64/boot/dts/arm/juno-r2-scmi.dts
> @@ -7,11 +7,11 @@ funnel@20130000 {
> };
>
> etf@20140000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
>
> funnel@20150000 {
> - power-domains = <&scmi_devpd 0>;
> + power-domains = <&scmi_devpd 8>;
> };
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
2022-04-13 9:35 ` Sudeep Holla
@ 2022-04-25 13:28 ` Sudeep Holla
-1 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2022-04-25 13:28 UTC (permalink / raw)
To: Sudeep Holla, linux-arm-kernel
Cc: Robin Murphy, Mike Leach, Lorenzo Pieralisi, devicetree, Liviu Dudau
On Wed, 13 Apr 2022 10:35:47 +0100, Sudeep Holla wrote:
> The SCMI power domain ID for all the coresight components is 8 while
> the previous/older SCPI domain was 0. When adding SCMI variant, couple
> of instances retained SCPI domain ID by mistake.
>
> Fix the same by using the correct SCMI power domain ID of 8.
>
>
> [...]
Applied to sudeep.holla/linux (for-next/juno), thanks!
[1/1] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
https://git.kernel.org/sudeep.holla/c/8dd3cdeaf303
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
@ 2022-04-25 13:28 ` Sudeep Holla
0 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2022-04-25 13:28 UTC (permalink / raw)
To: Sudeep Holla, linux-arm-kernel
Cc: Robin Murphy, Mike Leach, Lorenzo Pieralisi, devicetree, Liviu Dudau
On Wed, 13 Apr 2022 10:35:47 +0100, Sudeep Holla wrote:
> The SCMI power domain ID for all the coresight components is 8 while
> the previous/older SCPI domain was 0. When adding SCMI variant, couple
> of instances retained SCPI domain ID by mistake.
>
> Fix the same by using the correct SCMI power domain ID of 8.
>
>
> [...]
Applied to sudeep.holla/linux (for-next/juno), thanks!
[1/1] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel
https://git.kernel.org/sudeep.holla/c/8dd3cdeaf303
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-25 13:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 9:35 [PATCH] arm64: dts: juno: Fix SCMI power domain IDs for ETF and CS funnel Sudeep Holla
2022-04-13 9:35 ` Sudeep Holla
2022-04-13 10:07 ` Robin Murphy
2022-04-13 10:07 ` Robin Murphy
2022-04-25 13:28 ` Sudeep Holla
2022-04-25 13:28 ` Sudeep Holla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.