* [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support
@ 2022-04-13 16:08 ` Tommaso Merciai
0 siblings, 0 replies; 6+ messages in thread
From: Tommaso Merciai @ 2022-04-13 16:08 UTC (permalink / raw)
Cc: tommaso.merciai, linux-amarula, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Joakim Zhang, Richard Zhu, Tim Harvey, Li Jun,
devicetree, linux-arm-kernel, linux-kernel
Add pwm1/backlight support nodes for imx8mm_evk board.
Align with u-boot dts
References:
- https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/
Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
Changes since v1:
- Fix commit body
- Enable pwm, backlight
Changes since v2:
- Remove status okay from pwm1,backlight (enable as default)
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index 6d67df7692f1..c50d2cc3ca71 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
enable-active-high;
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm1 0 5000000>;
+ brightness-levels = <0 255>;
+ num-interpolated-steps = <255>;
+ default-brightness-level = <250>;
+ };
+
ir-receiver {
compatible = "gpio-ir-receiver";
gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
@@ -395,6 +403,11 @@ &wdog1 {
status = "okay";
};
+&pwm1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight>;
+};
+
&iomuxc {
pinctrl_fec1: fec1grp {
fsl,pins = <
@@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
>;
};
+
+ pinctrl_backlight: backlightgrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
+ >;
+ };
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support
@ 2022-04-13 16:08 ` Tommaso Merciai
0 siblings, 0 replies; 6+ messages in thread
From: Tommaso Merciai @ 2022-04-13 16:08 UTC (permalink / raw)
Cc: tommaso.merciai, linux-amarula, Rob Herring, Krzysztof Kozlowski,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Joakim Zhang, Richard Zhu, Tim Harvey, Li Jun,
devicetree, linux-arm-kernel, linux-kernel
Add pwm1/backlight support nodes for imx8mm_evk board.
Align with u-boot dts
References:
- https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/
Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
Changes since v1:
- Fix commit body
- Enable pwm, backlight
Changes since v2:
- Remove status okay from pwm1,backlight (enable as default)
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index 6d67df7692f1..c50d2cc3ca71 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
enable-active-high;
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm1 0 5000000>;
+ brightness-levels = <0 255>;
+ num-interpolated-steps = <255>;
+ default-brightness-level = <250>;
+ };
+
ir-receiver {
compatible = "gpio-ir-receiver";
gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
@@ -395,6 +403,11 @@ &wdog1 {
status = "okay";
};
+&pwm1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight>;
+};
+
&iomuxc {
pinctrl_fec1: fec1grp {
fsl,pins = <
@@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
>;
};
+
+ pinctrl_backlight: backlightgrp {
+ fsl,pins = <
+ MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
+ >;
+ };
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support
2022-04-13 16:08 ` Tommaso Merciai
@ 2022-04-13 16:31 ` Ahmad Fatoum
-1 siblings, 0 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2022-04-13 16:31 UTC (permalink / raw)
To: Tommaso Merciai
Cc: devicetree, Fabio Estevam, Richard Zhu, linux-amarula,
Sascha Hauer, Joakim Zhang, linux-kernel, Rob Herring,
NXP Linux Team, Pengutronix Kernel Team, Krzysztof Kozlowski,
Shawn Guo, Tim Harvey, linux-arm-kernel, Li Jun
Hello Tomasso,
On 13.04.22 18:08, Tommaso Merciai wrote:
> Add pwm1/backlight support nodes for imx8mm_evk board.
> Align with u-boot dts
>
> References:
> - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
> Changes since v1:
> - Fix commit body
> - Enable pwm, backlight
>
> Changes since v2:
> - Remove status okay from pwm1,backlight (enable as default)
>
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index 6d67df7692f1..c50d2cc3ca71 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> enable-active-high;
> };
>
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pwm1 0 5000000>;
> + brightness-levels = <0 255>;
> + num-interpolated-steps = <255>;
> + default-brightness-level = <250>;
> + };
> +
> ir-receiver {
> compatible = "gpio-ir-receiver";
> gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> @@ -395,6 +403,11 @@ &wdog1 {
> status = "okay";
> };
>
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_backlight>;
imx8mm.dtsi has &pwm1 { status = "disabled" };
Where is it enabled?
> +};
> +
> &iomuxc {
> pinctrl_fec1: fec1grp {
> fsl,pins = <
> @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
> MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
> >;
> };
> +
> + pinctrl_backlight: backlightgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
> + >;
> + };
> };
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support
@ 2022-04-13 16:31 ` Ahmad Fatoum
0 siblings, 0 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2022-04-13 16:31 UTC (permalink / raw)
To: Tommaso Merciai
Cc: devicetree, Fabio Estevam, Richard Zhu, linux-amarula,
Sascha Hauer, Joakim Zhang, linux-kernel, Rob Herring,
NXP Linux Team, Pengutronix Kernel Team, Krzysztof Kozlowski,
Shawn Guo, Tim Harvey, linux-arm-kernel, Li Jun
Hello Tomasso,
On 13.04.22 18:08, Tommaso Merciai wrote:
> Add pwm1/backlight support nodes for imx8mm_evk board.
> Align with u-boot dts
>
> References:
> - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
> Changes since v1:
> - Fix commit body
> - Enable pwm, backlight
>
> Changes since v2:
> - Remove status okay from pwm1,backlight (enable as default)
>
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index 6d67df7692f1..c50d2cc3ca71 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> enable-active-high;
> };
>
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pwm1 0 5000000>;
> + brightness-levels = <0 255>;
> + num-interpolated-steps = <255>;
> + default-brightness-level = <250>;
> + };
> +
> ir-receiver {
> compatible = "gpio-ir-receiver";
> gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> @@ -395,6 +403,11 @@ &wdog1 {
> status = "okay";
> };
>
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_backlight>;
imx8mm.dtsi has &pwm1 { status = "disabled" };
Where is it enabled?
> +};
> +
> &iomuxc {
> pinctrl_fec1: fec1grp {
> fsl,pins = <
> @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
> MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
> >;
> };
> +
> + pinctrl_backlight: backlightgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
> + >;
> + };
> };
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support
2022-04-13 16:31 ` Ahmad Fatoum
@ 2022-04-13 21:35 ` Tommaso Merciai
-1 siblings, 0 replies; 6+ messages in thread
From: Tommaso Merciai @ 2022-04-13 21:35 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: devicetree, Fabio Estevam, Richard Zhu, linux-amarula,
Sascha Hauer, Joakim Zhang, linux-kernel, Rob Herring,
NXP Linux Team, Pengutronix Kernel Team, Krzysztof Kozlowski,
Shawn Guo, Tim Harvey, linux-arm-kernel, Li Jun
On Wed, Apr 13, 2022 at 06:31:34PM +0200, Ahmad Fatoum wrote:
> Hello Tomasso,
>
> On 13.04.22 18:08, Tommaso Merciai wrote:
> > Add pwm1/backlight support nodes for imx8mm_evk board.
> > Align with u-boot dts
> >
> > References:
> > - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> > ---
> > Changes since v1:
> > - Fix commit body
> > - Enable pwm, backlight
> >
> > Changes since v2:
> > - Remove status okay from pwm1,backlight (enable as default)
> >
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > index 6d67df7692f1..c50d2cc3ca71 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> > enable-active-high;
> > };
> >
> > + backlight: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm1 0 5000000>;
> > + brightness-levels = <0 255>;
> > + num-interpolated-steps = <255>;
> > + default-brightness-level = <250>;
> > + };
> > +
> > ir-receiver {
> > compatible = "gpio-ir-receiver";
> > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> > @@ -395,6 +403,11 @@ &wdog1 {
> > status = "okay";
> > };
> >
> > +&pwm1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_backlight>;
>
> imx8mm.dtsi has &pwm1 { status = "disabled" };
> Where is it enabled?
Hi Ahmad,
Thanks for review, update in v4.
Tommaso
>
> > +};
> > +
> > &iomuxc {
> > pinctrl_fec1: fec1grp {
> > fsl,pins = <
> > @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
> > MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
> > >;
> > };
> > +
> > + pinctrl_backlight: backlightgrp {
> > + fsl,pins = <
> > + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
> > + >;
> > + };
> > };
>
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support
@ 2022-04-13 21:35 ` Tommaso Merciai
0 siblings, 0 replies; 6+ messages in thread
From: Tommaso Merciai @ 2022-04-13 21:35 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: devicetree, Fabio Estevam, Richard Zhu, linux-amarula,
Sascha Hauer, Joakim Zhang, linux-kernel, Rob Herring,
NXP Linux Team, Pengutronix Kernel Team, Krzysztof Kozlowski,
Shawn Guo, Tim Harvey, linux-arm-kernel, Li Jun
On Wed, Apr 13, 2022 at 06:31:34PM +0200, Ahmad Fatoum wrote:
> Hello Tomasso,
>
> On 13.04.22 18:08, Tommaso Merciai wrote:
> > Add pwm1/backlight support nodes for imx8mm_evk board.
> > Align with u-boot dts
> >
> > References:
> > - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> > ---
> > Changes since v1:
> > - Fix commit body
> > - Enable pwm, backlight
> >
> > Changes since v2:
> > - Remove status okay from pwm1,backlight (enable as default)
> >
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > index 6d67df7692f1..c50d2cc3ca71 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> > enable-active-high;
> > };
> >
> > + backlight: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm1 0 5000000>;
> > + brightness-levels = <0 255>;
> > + num-interpolated-steps = <255>;
> > + default-brightness-level = <250>;
> > + };
> > +
> > ir-receiver {
> > compatible = "gpio-ir-receiver";
> > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> > @@ -395,6 +403,11 @@ &wdog1 {
> > status = "okay";
> > };
> >
> > +&pwm1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_backlight>;
>
> imx8mm.dtsi has &pwm1 { status = "disabled" };
> Where is it enabled?
Hi Ahmad,
Thanks for review, update in v4.
Tommaso
>
> > +};
> > +
> > &iomuxc {
> > pinctrl_fec1: fec1grp {
> > fsl,pins = <
> > @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
> > MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
> > >;
> > };
> > +
> > + pinctrl_backlight: backlightgrp {
> > + fsl,pins = <
> > + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
> > + >;
> > + };
> > };
>
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-13 21:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 16:08 [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support Tommaso Merciai
2022-04-13 16:08 ` Tommaso Merciai
2022-04-13 16:31 ` Ahmad Fatoum
2022-04-13 16:31 ` Ahmad Fatoum
2022-04-13 21:35 ` Tommaso Merciai
2022-04-13 21:35 ` Tommaso Merciai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.