All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
@ 2022-04-14  8:11 ` Miles Chen
  0 siblings, 0 replies; 20+ messages in thread
From: Miles Chen @ 2022-04-14  8:11 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Matthias Brugger
  Cc: Miles Chen, alsa-devel, linux-kernel, linux-arm-kernel, linux-mediatek

We observed: 'dmasound_setup' defined but not used error with
COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.

__setup() does not work if MODULE is defined.
Fix it by warpping dmasound_setup with #ifndef MODULES.

Error(s):
sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]

Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
 sound/oss/dmasound/dmasound_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
index 9c48f3a9e3d1..a1b3e71beadf 100644
--- a/sound/oss/dmasound/dmasound_core.c
+++ b/sound/oss/dmasound/dmasound_core.c
@@ -1428,6 +1428,7 @@ void dmasound_deinit(void)
 		unregister_sound_dsp(sq_unit);
 }
 
+#ifndef MODULE
 static int dmasound_setup(char *str)
 {
 	int ints[6], size;
@@ -1470,6 +1471,7 @@ static int dmasound_setup(char *str)
 }
 
 __setup("dmasound=", dmasound_setup);
+#endif
 
     /*
      *  Conversion tables
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-04-14 23:40 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14  8:11 [PATCH -next] sound/oss/dmasound: fix 'dmasound_setup' defined but not used Miles Chen
2022-04-14  8:11 ` Miles Chen
2022-04-14  8:11 ` Miles Chen
2022-04-14  8:11 ` Miles Chen
2022-04-14  8:22 ` Takashi Iwai
2022-04-14  8:22   ` Takashi Iwai
2022-04-14  8:22   ` Takashi Iwai
2022-04-14  8:22   ` Takashi Iwai
2022-04-14  8:37   ` Miles Chen
2022-04-14  8:37     ` Miles Chen
2022-04-14  8:37     ` Miles Chen
2022-04-14  8:37     ` Miles Chen
2022-04-14 11:54 ` AngeloGioacchino Del Regno
2022-04-14 11:54   ` AngeloGioacchino Del Regno
2022-04-14 11:54   ` AngeloGioacchino Del Regno
2022-04-14 11:54   ` AngeloGioacchino Del Regno
2022-04-14 23:39   ` Miles Chen
2022-04-14 23:39     ` Miles Chen
2022-04-14 23:39     ` Miles Chen
2022-04-14 23:39     ` Miles Chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.