All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config
@ 2022-04-14 10:17 Richard Neill
  2022-04-20 18:12 ` Bruce Ashfield
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Neill @ 2022-04-14 10:17 UTC (permalink / raw)
  To: meta-virtualization; +Cc: nd

K3s (and Kubernetes) supports load balancing via IPVS, and by default reports
errors when IPVS kernel modules cannot be loaded.

This patch adds the missing reported kernel modules to the k3s recipe:

    * ip-vs
    * ip-vs-rr
    * ip-vs-wrr
    * ip-vs-sh

The modules are configured by including the ip_vs kernel feature.

Signed-off-by: Richard Neill <richard.neill@arm.com>
---
 recipes-containers/k3s/k3s_git.bb               | 4 ++++
 recipes-kernel/linux/linux-yocto/kubernetes.scc | 1 +
 2 files changed, 5 insertions(+)

diff --git a/recipes-containers/k3s/k3s_git.bb b/recipes-containers/k3s/k3s_git.bb
index 53a8677..a20092c 100644
--- a/recipes-containers/k3s/k3s_git.bb
+++ b/recipes-containers/k3s/k3s_git.bb
@@ -2704,6 +2704,10 @@ RRECOMMENDS:${PN} = "\
                      kernel-module-xt-nflog \
                      kernel-module-xt-limit \
                      kernel-module-nfnetlink-log \
+                     kernel-module-ip-vs \
+                     kernel-module-ip-vs-rr \
+                     kernel-module-ip-vs-sh \
+                     kernel-module-ip-vs-wrr \
                      "

 RCONFLICTS:${PN} = "kubectl"
diff --git a/recipes-kernel/linux/linux-yocto/kubernetes.scc b/recipes-kernel/linux/linux-yocto/kubernetes.scc
index 1e93b70..a94ae84 100644
--- a/recipes-kernel/linux/linux-yocto/kubernetes.scc
+++ b/recipes-kernel/linux/linux-yocto/kubernetes.scc
@@ -1,2 +1,3 @@
 include docker.scc
+include cgl/cfg/net/ip_vs.scc
 kconf non-hardware kubernetes.cfg
--
2.25.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config
  2022-04-14 10:17 [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config Richard Neill
@ 2022-04-20 18:12 ` Bruce Ashfield
  0 siblings, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2022-04-20 18:12 UTC (permalink / raw)
  To: Richard Neill; +Cc: meta-virtualization, nd

staged on master-next.

Bruce

In message: [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config
on 14/04/2022 Richard Neill wrote:

> K3s (and Kubernetes) supports load balancing via IPVS, and by default reports
> errors when IPVS kernel modules cannot be loaded.
> 
> This patch adds the missing reported kernel modules to the k3s recipe:
> 
>     * ip-vs
>     * ip-vs-rr
>     * ip-vs-wrr
>     * ip-vs-sh
> 
> The modules are configured by including the ip_vs kernel feature.
> 
> Signed-off-by: Richard Neill <richard.neill@arm.com>
> ---
>  recipes-containers/k3s/k3s_git.bb               | 4 ++++
>  recipes-kernel/linux/linux-yocto/kubernetes.scc | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/recipes-containers/k3s/k3s_git.bb b/recipes-containers/k3s/k3s_git.bb
> index 53a8677..a20092c 100644
> --- a/recipes-containers/k3s/k3s_git.bb
> +++ b/recipes-containers/k3s/k3s_git.bb
> @@ -2704,6 +2704,10 @@ RRECOMMENDS:${PN} = "\
>                       kernel-module-xt-nflog \
>                       kernel-module-xt-limit \
>                       kernel-module-nfnetlink-log \
> +                     kernel-module-ip-vs \
> +                     kernel-module-ip-vs-rr \
> +                     kernel-module-ip-vs-sh \
> +                     kernel-module-ip-vs-wrr \
>                       "
> 
>  RCONFLICTS:${PN} = "kubectl"
> diff --git a/recipes-kernel/linux/linux-yocto/kubernetes.scc b/recipes-kernel/linux/linux-yocto/kubernetes.scc
> index 1e93b70..a94ae84 100644
> --- a/recipes-kernel/linux/linux-yocto/kubernetes.scc
> +++ b/recipes-kernel/linux/linux-yocto/kubernetes.scc
> @@ -1,2 +1,3 @@
>  include docker.scc
> +include cgl/cfg/net/ip_vs.scc
>  kconf non-hardware kubernetes.cfg
> --
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7174): https://lists.yoctoproject.org/g/meta-virtualization/message/7174
> Mute This Topic: https://lists.yoctoproject.org/mt/90436886/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config
  2022-04-14  3:14 ` Bruce Ashfield
@ 2022-04-14  9:29   ` Richard Neill
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Neill @ 2022-04-14  9:29 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: meta-virtualization, nd

[-- Attachment #1: Type: text/plain, Size: 4157 bytes --]

Hi Bruce,

OK, no problem, I will send an updated patch

Richard
________________________________
From: Bruce Ashfield <bruce.ashfield@gmail.com>
Sent: Thursday, April 14, 2022 4:14 AM
To: Richard Neill <Richard.Neill@arm.com>
Cc: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org>; nd <nd@arm.com>
Subject: Re: [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config

On Wed, Apr 13, 2022 at 5:16 AM Richard Neill <richard.neill@arm.com> wrote:
>
> K3s (and Kubernetes) supports load balancing via IPVS, and by default reports
> errors when IPVS kernel modules cannot be loaded.
>
> This patch adds the missing reported kernel modules to the k3s recipe, and
> orders the kernel module list alphabetically:

I'd actually prefer that the list not be sorted, at the same time as
we are adding to it.

Can you re-submit with just the new kernel module recommendations added.

Bruce

>
>     * ip-vs
>     * ip-vs-rr
>     * ip-vs-wrr
>     * ip-vs-sh
>
> The modules are configured by including the ip_vs kernel feature.
>
> Signed-off-by: Richard Neill <richard.neill@arm.com>
> ---
>  recipes-containers/k3s/k3s_git.bb             | 22 +++++++++++--------
>  .../linux/linux-yocto/kubernetes.scc          |  1 +
>  2 files changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/recipes-containers/k3s/k3s_git.bb b/recipes-containers/k3s/k3s_git.bb
> index e2a3ffc..0b56e3c 100644
> --- a/recipes-containers/k3s/k3s_git.bb
> +++ b/recipes-containers/k3s/k3s_git.bb
> @@ -2690,20 +2690,24 @@ RDEPENDS:${PN}-server = "${PN}"
>  RDEPENDS:${PN}-agent = "${PN}"
>
>  RRECOMMENDS:${PN} = "\
> +                     kernel-module-ip-vs \
> +                     kernel-module-ip-vs-rr \
> +                     kernel-module-ip-vs-sh \
> +                     kernel-module-ip-vs-wrr \
> +                     kernel-module-nfnetlink-log \
> +                     kernel-module-vxlan \
>                       kernel-module-xt-addrtype \
> -                     kernel-module-xt-nat \
> -                     kernel-module-xt-multiport \
> -                     kernel-module-xt-conntrack \
>                       kernel-module-xt-comment \
> -                     kernel-module-xt-mark \
>                       kernel-module-xt-connmark \
> -                     kernel-module-vxlan \
> +                     kernel-module-xt-conntrack \
> +                     kernel-module-xt-limit \
> +                     kernel-module-xt-mark \
>                       kernel-module-xt-masquerade \
> -                     kernel-module-xt-statistic \
> -                     kernel-module-xt-physdev \
> +                     kernel-module-xt-multiport \
> +                     kernel-module-xt-nat \
>                       kernel-module-xt-nflog \
> -                     kernel-module-xt-limit \
> -                     kernel-module-nfnetlink-log \
> +                     kernel-module-xt-physdev \
> +                     kernel-module-xt-statistic \
>                       "
>
>  RCONFLICTS:${PN} = "kubectl"
> diff --git a/recipes-kernel/linux/linux-yocto/kubernetes.scc b/recipes-kernel/linux/linux-yocto/kubernetes.scc
> index 1e93b70..a94ae84 100644
> --- a/recipes-kernel/linux/linux-yocto/kubernetes.scc
> +++ b/recipes-kernel/linux/linux-yocto/kubernetes.scc
> @@ -1,2 +1,3 @@
>  include docker.scc
> +include cgl/cfg/net/ip_vs.scc
>  kconf non-hardware kubernetes.cfg
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7165): https://lists.yoctoproject.org/g/meta-virtualization/message/7165
> Mute This Topic: https://lists.yoctoproject.org/mt/90436886/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 9329 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config
  2022-04-13  9:16 Richard Neill
@ 2022-04-14  3:14 ` Bruce Ashfield
  2022-04-14  9:29   ` Richard Neill
  0 siblings, 1 reply; 6+ messages in thread
From: Bruce Ashfield @ 2022-04-14  3:14 UTC (permalink / raw)
  To: Richard Neill; +Cc: meta-virtualization, nd

On Wed, Apr 13, 2022 at 5:16 AM Richard Neill <richard.neill@arm.com> wrote:
>
> K3s (and Kubernetes) supports load balancing via IPVS, and by default reports
> errors when IPVS kernel modules cannot be loaded.
>
> This patch adds the missing reported kernel modules to the k3s recipe, and
> orders the kernel module list alphabetically:

I'd actually prefer that the list not be sorted, at the same time as
we are adding to it.

Can you re-submit with just the new kernel module recommendations added.

Bruce

>
>     * ip-vs
>     * ip-vs-rr
>     * ip-vs-wrr
>     * ip-vs-sh
>
> The modules are configured by including the ip_vs kernel feature.
>
> Signed-off-by: Richard Neill <richard.neill@arm.com>
> ---
>  recipes-containers/k3s/k3s_git.bb             | 22 +++++++++++--------
>  .../linux/linux-yocto/kubernetes.scc          |  1 +
>  2 files changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/recipes-containers/k3s/k3s_git.bb b/recipes-containers/k3s/k3s_git.bb
> index e2a3ffc..0b56e3c 100644
> --- a/recipes-containers/k3s/k3s_git.bb
> +++ b/recipes-containers/k3s/k3s_git.bb
> @@ -2690,20 +2690,24 @@ RDEPENDS:${PN}-server = "${PN}"
>  RDEPENDS:${PN}-agent = "${PN}"
>
>  RRECOMMENDS:${PN} = "\
> +                     kernel-module-ip-vs \
> +                     kernel-module-ip-vs-rr \
> +                     kernel-module-ip-vs-sh \
> +                     kernel-module-ip-vs-wrr \
> +                     kernel-module-nfnetlink-log \
> +                     kernel-module-vxlan \
>                       kernel-module-xt-addrtype \
> -                     kernel-module-xt-nat \
> -                     kernel-module-xt-multiport \
> -                     kernel-module-xt-conntrack \
>                       kernel-module-xt-comment \
> -                     kernel-module-xt-mark \
>                       kernel-module-xt-connmark \
> -                     kernel-module-vxlan \
> +                     kernel-module-xt-conntrack \
> +                     kernel-module-xt-limit \
> +                     kernel-module-xt-mark \
>                       kernel-module-xt-masquerade \
> -                     kernel-module-xt-statistic \
> -                     kernel-module-xt-physdev \
> +                     kernel-module-xt-multiport \
> +                     kernel-module-xt-nat \
>                       kernel-module-xt-nflog \
> -                     kernel-module-xt-limit \
> -                     kernel-module-nfnetlink-log \
> +                     kernel-module-xt-physdev \
> +                     kernel-module-xt-statistic \
>                       "
>
>  RCONFLICTS:${PN} = "kubectl"
> diff --git a/recipes-kernel/linux/linux-yocto/kubernetes.scc b/recipes-kernel/linux/linux-yocto/kubernetes.scc
> index 1e93b70..a94ae84 100644
> --- a/recipes-kernel/linux/linux-yocto/kubernetes.scc
> +++ b/recipes-kernel/linux/linux-yocto/kubernetes.scc
> @@ -1,2 +1,3 @@
>  include docker.scc
> +include cgl/cfg/net/ip_vs.scc
>  kconf non-hardware kubernetes.cfg
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7165): https://lists.yoctoproject.org/g/meta-virtualization/message/7165
> Mute This Topic: https://lists.yoctoproject.org/mt/90436886/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config
       [not found] <16E569FF005E4AC7.11417@lists.yoctoproject.org>
@ 2022-04-13  9:21 ` Richard Neill
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Neill @ 2022-04-13  9:21 UTC (permalink / raw)
  To: meta-virtualization; +Cc: nd

[-- Attachment #1: Type: text/plain, Size: 3308 bytes --]

Hi Bruce,

Could you please also backport this patch to the honister branch? Thanks!

Richard
________________________________
From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> on behalf of Richard Neill via lists.yoctoproject.org <richard.neill=arm.com@lists.yoctoproject.org>
Sent: Wednesday, April 13, 2022 10:16 AM
To: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org>
Cc: nd <nd@arm.com>
Subject: [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config

K3s (and Kubernetes) supports load balancing via IPVS, and by default reports
errors when IPVS kernel modules cannot be loaded.

This patch adds the missing reported kernel modules to the k3s recipe, and
orders the kernel module list alphabetically:

    * ip-vs
    * ip-vs-rr
    * ip-vs-wrr
    * ip-vs-sh

The modules are configured by including the ip_vs kernel feature.

Signed-off-by: Richard Neill <richard.neill@arm.com>
---
 recipes-containers/k3s/k3s_git.bb             | 22 +++++++++++--------
 .../linux/linux-yocto/kubernetes.scc          |  1 +
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/recipes-containers/k3s/k3s_git.bb b/recipes-containers/k3s/k3s_git.bb
index e2a3ffc..0b56e3c 100644
--- a/recipes-containers/k3s/k3s_git.bb
+++ b/recipes-containers/k3s/k3s_git.bb
@@ -2690,20 +2690,24 @@ RDEPENDS:${PN}-server = "${PN}"
 RDEPENDS:${PN}-agent = "${PN}"

 RRECOMMENDS:${PN} = "\
+                     kernel-module-ip-vs \
+                     kernel-module-ip-vs-rr \
+                     kernel-module-ip-vs-sh \
+                     kernel-module-ip-vs-wrr \
+                     kernel-module-nfnetlink-log \
+                     kernel-module-vxlan \
                      kernel-module-xt-addrtype \
-                     kernel-module-xt-nat \
-                     kernel-module-xt-multiport \
-                     kernel-module-xt-conntrack \
                      kernel-module-xt-comment \
-                     kernel-module-xt-mark \
                      kernel-module-xt-connmark \
-                     kernel-module-vxlan \
+                     kernel-module-xt-conntrack \
+                     kernel-module-xt-limit \
+                     kernel-module-xt-mark \
                      kernel-module-xt-masquerade \
-                     kernel-module-xt-statistic \
-                     kernel-module-xt-physdev \
+                     kernel-module-xt-multiport \
+                     kernel-module-xt-nat \
                      kernel-module-xt-nflog \
-                     kernel-module-xt-limit \
-                     kernel-module-nfnetlink-log \
+                     kernel-module-xt-physdev \
+                     kernel-module-xt-statistic \
                      "

 RCONFLICTS:${PN} = "kubectl"
diff --git a/recipes-kernel/linux/linux-yocto/kubernetes.scc b/recipes-kernel/linux/linux-yocto/kubernetes.scc
index 1e93b70..a94ae84 100644
--- a/recipes-kernel/linux/linux-yocto/kubernetes.scc
+++ b/recipes-kernel/linux/linux-yocto/kubernetes.scc
@@ -1,2 +1,3 @@
 include docker.scc
+include cgl/cfg/net/ip_vs.scc
 kconf non-hardware kubernetes.cfg
--
2.25.1


[-- Attachment #2: Type: text/html, Size: 7859 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config
@ 2022-04-13  9:16 Richard Neill
  2022-04-14  3:14 ` Bruce Ashfield
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Neill @ 2022-04-13  9:16 UTC (permalink / raw)
  To: meta-virtualization; +Cc: nd

K3s (and Kubernetes) supports load balancing via IPVS, and by default reports
errors when IPVS kernel modules cannot be loaded.

This patch adds the missing reported kernel modules to the k3s recipe, and
orders the kernel module list alphabetically:

    * ip-vs
    * ip-vs-rr
    * ip-vs-wrr
    * ip-vs-sh

The modules are configured by including the ip_vs kernel feature.

Signed-off-by: Richard Neill <richard.neill@arm.com>
---
 recipes-containers/k3s/k3s_git.bb             | 22 +++++++++++--------
 .../linux/linux-yocto/kubernetes.scc          |  1 +
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/recipes-containers/k3s/k3s_git.bb b/recipes-containers/k3s/k3s_git.bb
index e2a3ffc..0b56e3c 100644
--- a/recipes-containers/k3s/k3s_git.bb
+++ b/recipes-containers/k3s/k3s_git.bb
@@ -2690,20 +2690,24 @@ RDEPENDS:${PN}-server = "${PN}"
 RDEPENDS:${PN}-agent = "${PN}"

 RRECOMMENDS:${PN} = "\
+                     kernel-module-ip-vs \
+                     kernel-module-ip-vs-rr \
+                     kernel-module-ip-vs-sh \
+                     kernel-module-ip-vs-wrr \
+                     kernel-module-nfnetlink-log \
+                     kernel-module-vxlan \
                      kernel-module-xt-addrtype \
-                     kernel-module-xt-nat \
-                     kernel-module-xt-multiport \
-                     kernel-module-xt-conntrack \
                      kernel-module-xt-comment \
-                     kernel-module-xt-mark \
                      kernel-module-xt-connmark \
-                     kernel-module-vxlan \
+                     kernel-module-xt-conntrack \
+                     kernel-module-xt-limit \
+                     kernel-module-xt-mark \
                      kernel-module-xt-masquerade \
-                     kernel-module-xt-statistic \
-                     kernel-module-xt-physdev \
+                     kernel-module-xt-multiport \
+                     kernel-module-xt-nat \
                      kernel-module-xt-nflog \
-                     kernel-module-xt-limit \
-                     kernel-module-nfnetlink-log \
+                     kernel-module-xt-physdev \
+                     kernel-module-xt-statistic \
                      "

 RCONFLICTS:${PN} = "kubectl"
diff --git a/recipes-kernel/linux/linux-yocto/kubernetes.scc b/recipes-kernel/linux/linux-yocto/kubernetes.scc
index 1e93b70..a94ae84 100644
--- a/recipes-kernel/linux/linux-yocto/kubernetes.scc
+++ b/recipes-kernel/linux/linux-yocto/kubernetes.scc
@@ -1,2 +1,3 @@
 include docker.scc
+include cgl/cfg/net/ip_vs.scc
 kconf non-hardware kubernetes.cfg
--
2.25.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-04-21 16:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 10:17 [meta-virtualization] [PATCH] k3s: Add missing IP Virtual Server (ip_vs) feature to the kernel config Richard Neill
2022-04-20 18:12 ` Bruce Ashfield
     [not found] <16E569FF005E4AC7.11417@lists.yoctoproject.org>
2022-04-13  9:21 ` Richard Neill
  -- strict thread matches above, loose matches on Subject: below --
2022-04-13  9:16 Richard Neill
2022-04-14  3:14 ` Bruce Ashfield
2022-04-14  9:29   ` Richard Neill

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.