All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc
@ 2022-04-13 15:28 Ville Syrjala
  2022-04-13 15:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/fbc: s/false/0/ Ville Syrjala
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Ville Syrjala @ 2022-04-13 15:28 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

plane_state->uapi.crtc is not what we want to be looking at.
If bigjoiner is used hw.crtc is what tells us what crtc the plane
is supposedly using.

Not an actual problem on current hardware as the only FBC capable
pipe (A) can't be a bigjoiner slave and thus uapi.crtc==hw.crtc
always here. But when we get more FBC instances this will become
actually important.

Fixes: 2e6c99f88679 ("drm/i915/fbc: Nuke lots of crap from intel_fbc_state_cache")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 670835318a1f..ff303c7d3a57 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1045,7 +1045,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
 	struct intel_plane_state *plane_state =
 		intel_atomic_get_new_plane_state(state, plane);
 	const struct drm_framebuffer *fb = plane_state->hw.fb;
-	struct intel_crtc *crtc = to_intel_crtc(plane_state->uapi.crtc);
+	struct intel_crtc *crtc = to_intel_crtc(plane_state->hw.crtc);
 	const struct intel_crtc_state *crtc_state;
 	struct intel_fbc *fbc = plane->fbc;
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-04-23  0:11 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 15:28 [Intel-gfx] [PATCH 1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc Ville Syrjala
2022-04-13 15:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/fbc: s/false/0/ Ville Syrjala
2022-04-14 15:10   ` Navare, Manasi
2022-04-13 23:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc Patchwork
2022-04-14 15:12 ` [Intel-gfx] [PATCH 1/2] " Navare, Manasi
2022-04-21 16:58 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc (rev2) Patchwork
2022-04-21 23:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc (rev3) Patchwork
2022-04-22 20:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc (rev4) Patchwork
2022-04-23  0:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.