From: Sascha Hauer <s.hauer@pengutronix.de>
To: alsa-devel@alsa-project.org
Cc: Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
kernel@pengutronix.de, dmaengine@vger.kernel.org,
Shengjiu Wang <shengjiu.wang@gmail.com>
Subject: [PATCH v6 01/21] ASoC: fsl_micfil: Drop unnecessary register read
Date: Thu, 14 Apr 2022 18:22:29 +0200 [thread overview]
Message-ID: <20220414162249.3934543-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20220414162249.3934543-1-s.hauer@pengutronix.de>
in get_pdm_clk() REG_MICFIL_CTRL2 is read twice. Drop second read.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
---
sound/soc/fsl/fsl_micfil.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
index 9f90989ac59a6..64019d003784b 100644
--- a/sound/soc/fsl/fsl_micfil.c
+++ b/sound/soc/fsl/fsl_micfil.c
@@ -118,8 +118,6 @@ static inline int get_pdm_clk(struct fsl_micfil *micfil,
regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg);
osr = 16 - ((ctrl2_reg & MICFIL_CTRL2_CICOSR_MASK)
>> MICFIL_CTRL2_CICOSR_SHIFT);
-
- regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg);
qsel = ctrl2_reg & MICFIL_CTRL2_QSEL_MASK;
switch (qsel) {
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: alsa-devel@alsa-project.org
Cc: Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
kernel@pengutronix.de, Vinod Koul <vkoul@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
dmaengine@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH v6 01/21] ASoC: fsl_micfil: Drop unnecessary register read
Date: Thu, 14 Apr 2022 18:22:29 +0200 [thread overview]
Message-ID: <20220414162249.3934543-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20220414162249.3934543-1-s.hauer@pengutronix.de>
in get_pdm_clk() REG_MICFIL_CTRL2 is read twice. Drop second read.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
---
sound/soc/fsl/fsl_micfil.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
index 9f90989ac59a6..64019d003784b 100644
--- a/sound/soc/fsl/fsl_micfil.c
+++ b/sound/soc/fsl/fsl_micfil.c
@@ -118,8 +118,6 @@ static inline int get_pdm_clk(struct fsl_micfil *micfil,
regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg);
osr = 16 - ((ctrl2_reg & MICFIL_CTRL2_CICOSR_MASK)
>> MICFIL_CTRL2_CICOSR_SHIFT);
-
- regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg);
qsel = ctrl2_reg & MICFIL_CTRL2_QSEL_MASK;
switch (qsel) {
--
2.30.2
next prev parent reply other threads:[~2022-04-14 16:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 16:22 [PATCH v6 00/21] ASoC: fsl_micfil: Driver updates Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer [this message]
2022-04-14 16:22 ` [PATCH v6 01/21] ASoC: fsl_micfil: Drop unnecessary register read Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 02/21] ASoC: fsl_micfil: Drop unused " Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 03/21] ASoC: fsl_micfil: drop fsl_micfil_set_mclk_rate() Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 04/21] ASoC: fsl_micfil: do not define SHIFT/MASK for single bits Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 05/21] ASoC: fsl_micfil: use GENMASK to define register bit fields Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 06/21] ASoC: fsl_micfil: use clear/set bits Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 07/21] ASoC: fsl_micfil: drop error messages from failed register accesses Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 08/21] ASoC: fsl_micfil: drop unused variables Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 09/21] dmaengine: imx: Move header to include/dma/ Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 10/21] dmaengine: imx-sdma: error out on unsupported transfer types Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 11/21] dmaengine: imx-sdma: Add multi fifo support Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 12/21] ASoC: fsl_micfil: add " Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 13/21] ASoC: fsl_micfil: use define for OSR default value Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 14/21] ASoC: fsl_micfil: Drop get_pdm_clk() Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 15/21] ASoC: fsl_micfil: simplify clock setting Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 16/21] ASoC: fsl_micfil: rework quality setting Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 17/21] ASoC: fsl_micfil: drop unused include Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 18/21] ASoC: fsl_micfil: drop only once used defines Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 19/21] ASoC: fsl_micfil: drop support for undocumented property Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 20/21] ASoC: fsl_micfil: fold fsl_set_clock_params() into its only user Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-14 16:22 ` [PATCH v6 21/21] ASoC: fsl_micfil: Remove debug message Sascha Hauer
2022-04-14 16:22 ` Sascha Hauer
2022-04-20 21:40 ` [PATCH v6 00/21] ASoC: fsl_micfil: Driver updates Mark Brown
2022-04-20 21:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414162249.3934543-2-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=shengjiu.wang@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.