From: Sean Christopherson <seanjc@google.com>
To: Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Atish Patra <atishp@atishpatra.org>,
David Hildenbrand <david@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] KVM: x86 SRCU bug fix and SRCU hardening
Date: Fri, 15 Apr 2022 00:43:40 +0000 [thread overview]
Message-ID: <20220415004343.2203171-1-seanjc@google.com> (raw)
Fix an x86 bug where KVM overwrites vcpu->srcu_idx and can leak an SRCU
lock due to unlocking the wrong index, ultimately causing a hang if/when
KVM attempts to synchronize.
Switch RISC-V to the generic vcpu->srcu_idx, for reasons unknown it has
its own copy and ignores the generic one.
Add helpers with rudimentary detection of illegal vcpu->srcu_idx usage,
the x86 bug would have been incredibly painful to debug had I not known
what to look for (found by a selftest with very specific behavior...
that we recently modified with respect to SRCU).
Non-x86 changes are compile tested only.
Sean Christopherson (3):
KVM: x86: Don't re-acquire SRCU lock in complete_emulated_io()
KVM: RISC-V: Use kvm_vcpu.srcu_idx, drop RISC-V's unnecessary copy
KVM: Add helpers to wrap vcpu->srcu_idx and yell if it's abused
arch/powerpc/kvm/book3s_64_mmu_radix.c | 9 ++++---
arch/powerpc/kvm/book3s_hv_nested.c | 16 ++++++------
arch/powerpc/kvm/book3s_rtas.c | 4 +--
arch/powerpc/kvm/powerpc.c | 4 +--
arch/riscv/include/asm/kvm_host.h | 3 ---
arch/riscv/kvm/vcpu.c | 16 ++++++------
arch/riscv/kvm/vcpu_exit.c | 4 +--
arch/s390/kvm/interrupt.c | 4 +--
arch/s390/kvm/kvm-s390.c | 8 +++---
arch/s390/kvm/vsie.c | 4 +--
arch/x86/kvm/x86.c | 35 +++++++++++---------------
include/linux/kvm_host.h | 24 +++++++++++++++++-
12 files changed, 72 insertions(+), 59 deletions(-)
base-commit: 150866cd0ec871c765181d145aa0912628289c8a
--
2.36.0.rc0.470.gd361397f0d-goog
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Atish Patra <atishp@atishpatra.org>,
David Hildenbrand <david@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
Joerg Roedel <joro@8bytes.org>,
linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] KVM: x86 SRCU bug fix and SRCU hardening
Date: Fri, 15 Apr 2022 00:43:40 +0000 [thread overview]
Message-ID: <20220415004343.2203171-1-seanjc@google.com> (raw)
Fix an x86 bug where KVM overwrites vcpu->srcu_idx and can leak an SRCU
lock due to unlocking the wrong index, ultimately causing a hang if/when
KVM attempts to synchronize.
Switch RISC-V to the generic vcpu->srcu_idx, for reasons unknown it has
its own copy and ignores the generic one.
Add helpers with rudimentary detection of illegal vcpu->srcu_idx usage,
the x86 bug would have been incredibly painful to debug had I not known
what to look for (found by a selftest with very specific behavior...
that we recently modified with respect to SRCU).
Non-x86 changes are compile tested only.
Sean Christopherson (3):
KVM: x86: Don't re-acquire SRCU lock in complete_emulated_io()
KVM: RISC-V: Use kvm_vcpu.srcu_idx, drop RISC-V's unnecessary copy
KVM: Add helpers to wrap vcpu->srcu_idx and yell if it's abused
arch/powerpc/kvm/book3s_64_mmu_radix.c | 9 ++++---
arch/powerpc/kvm/book3s_hv_nested.c | 16 ++++++------
arch/powerpc/kvm/book3s_rtas.c | 4 +--
arch/powerpc/kvm/powerpc.c | 4 +--
arch/riscv/include/asm/kvm_host.h | 3 ---
arch/riscv/kvm/vcpu.c | 16 ++++++------
arch/riscv/kvm/vcpu_exit.c | 4 +--
arch/s390/kvm/interrupt.c | 4 +--
arch/s390/kvm/kvm-s390.c | 8 +++---
arch/s390/kvm/vsie.c | 4 +--
arch/x86/kvm/x86.c | 35 +++++++++++---------------
include/linux/kvm_host.h | 24 +++++++++++++++++-
12 files changed, 72 insertions(+), 59 deletions(-)
base-commit: 150866cd0ec871c765181d145aa0912628289c8a
--
2.36.0.rc0.470.gd361397f0d-goog
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Anup Patel <anup@brainfault.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, kvm-riscv@lists.infradead.org,
Atish Patra <atishp@atishpatra.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
Jim Mattson <jmattson@google.com>
Subject: [PATCH 0/3] KVM: x86 SRCU bug fix and SRCU hardening
Date: Fri, 15 Apr 2022 00:43:40 +0000 [thread overview]
Message-ID: <20220415004343.2203171-1-seanjc@google.com> (raw)
Fix an x86 bug where KVM overwrites vcpu->srcu_idx and can leak an SRCU
lock due to unlocking the wrong index, ultimately causing a hang if/when
KVM attempts to synchronize.
Switch RISC-V to the generic vcpu->srcu_idx, for reasons unknown it has
its own copy and ignores the generic one.
Add helpers with rudimentary detection of illegal vcpu->srcu_idx usage,
the x86 bug would have been incredibly painful to debug had I not known
what to look for (found by a selftest with very specific behavior...
that we recently modified with respect to SRCU).
Non-x86 changes are compile tested only.
Sean Christopherson (3):
KVM: x86: Don't re-acquire SRCU lock in complete_emulated_io()
KVM: RISC-V: Use kvm_vcpu.srcu_idx, drop RISC-V's unnecessary copy
KVM: Add helpers to wrap vcpu->srcu_idx and yell if it's abused
arch/powerpc/kvm/book3s_64_mmu_radix.c | 9 ++++---
arch/powerpc/kvm/book3s_hv_nested.c | 16 ++++++------
arch/powerpc/kvm/book3s_rtas.c | 4 +--
arch/powerpc/kvm/powerpc.c | 4 +--
arch/riscv/include/asm/kvm_host.h | 3 ---
arch/riscv/kvm/vcpu.c | 16 ++++++------
arch/riscv/kvm/vcpu_exit.c | 4 +--
arch/s390/kvm/interrupt.c | 4 +--
arch/s390/kvm/kvm-s390.c | 8 +++---
arch/s390/kvm/vsie.c | 4 +--
arch/x86/kvm/x86.c | 35 +++++++++++---------------
include/linux/kvm_host.h | 24 +++++++++++++++++-
12 files changed, 72 insertions(+), 59 deletions(-)
base-commit: 150866cd0ec871c765181d145aa0912628289c8a
--
2.36.0.rc0.470.gd361397f0d-goog
next reply other threads:[~2022-04-15 0:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 0:43 Sean Christopherson [this message]
2022-04-15 0:43 ` [PATCH 0/3] KVM: x86 SRCU bug fix and SRCU hardening Sean Christopherson
2022-04-15 0:43 ` Sean Christopherson
2022-04-15 0:43 ` [PATCH 1/3] KVM: x86: Don't re-acquire SRCU lock in complete_emulated_io() Sean Christopherson
2022-04-15 0:43 ` Sean Christopherson
2022-04-15 0:43 ` Sean Christopherson
2022-04-19 8:55 ` Maxim Levitsky
2022-04-19 8:55 ` Maxim Levitsky
2022-04-19 8:55 ` Maxim Levitsky
2022-04-15 0:43 ` [PATCH 2/3] KVM: RISC-V: Use kvm_vcpu.srcu_idx, drop RISC-V's unnecessary copy Sean Christopherson
2022-04-15 0:43 ` Sean Christopherson
2022-04-15 0:43 ` Sean Christopherson
2022-04-15 0:43 ` [PATCH 3/3] KVM: Add helpers to wrap vcpu->srcu_idx and yell if it's abused Sean Christopherson
2022-04-15 0:43 ` Sean Christopherson
2022-04-15 0:43 ` Sean Christopherson
2022-04-19 9:04 ` Maxim Levitsky
2022-04-19 9:04 ` Maxim Levitsky
2022-04-19 9:04 ` Maxim Levitsky
2022-04-19 15:45 ` Sean Christopherson
2022-04-19 15:45 ` Sean Christopherson
2022-04-19 15:45 ` Sean Christopherson
2022-04-20 4:36 ` Maxim Levitsky
2022-04-20 4:36 ` Maxim Levitsky
2022-04-20 4:36 ` Maxim Levitsky
2022-04-19 17:18 ` Fabiano Rosas
2022-04-19 17:18 ` Fabiano Rosas
2022-04-19 17:18 ` Fabiano Rosas
2022-04-20 10:00 ` [PATCH 0/3] KVM: x86 SRCU bug fix and SRCU hardening Paolo Bonzini
2022-04-20 10:00 ` Paolo Bonzini
2022-04-20 10:00 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415004343.2203171-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.