[PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

[PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

[Matthew G McGovern]

From: "Matthew G. McGovern" <matthew@mcgov.dev>
Date: Wed, 13 Apr 2022 15:48:15 -0700
Subject: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

An ext4 struct has the wrong array size for a field in the docs.

- Document correct array size (3) for ext4_xattr_header.h_reserved

Signed-off-by: Matthew G. McGovern <matthew@mcgov.dev>
---
 Documentation/filesystems/ext4/attributes.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/ext4/attributes.rst b/Documentation/filesystems/ext4/attributes.rst
index 54386a010a8d..871d2da7a0a9 100644
--- a/Documentation/filesystems/ext4/attributes.rst
+++ b/Documentation/filesystems/ext4/attributes.rst
@@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
      - Checksum of the extended attribute block.
    * - 0x14
      - \_\_u32
-     - h\_reserved[2]
+     - h\_reserved[3]
      - Zero.

 The checksum is calculated against the FS UUID, the 64-bit block number

base-commit: 96485e4462604744d66bf4301557d996d80b85eb
--
2.25.1

Re: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

[Darrick J. Wong]

On Fri, Apr 15, 2022 at 12:50:56AM +0000, Matthew G McGovern wrote:
> From: "Matthew G. McGovern" <matthew@mcgov.dev>
> Date: Wed, 13 Apr 2022 15:48:15 -0700
> Subject: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix
> 
> An ext4 struct has the wrong array size for a field in the docs.
> 
> - Document correct array size (3) for ext4_xattr_header.h_reserved
> 
> Signed-off-by: Matthew G. McGovern <matthew@mcgov.dev>

Yup.  Thanks for the correction.

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  Documentation/filesystems/ext4/attributes.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/filesystems/ext4/attributes.rst b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
>       - Checksum of the extended attribute block.
>     * - 0x14
>       - \_\_u32
> -     - h\_reserved[2]
> +     - h\_reserved[3]
>       - Zero.
> 
>  The checksum is calculated against the FS UUID, the 64-bit block number
> 
> base-commit: 96485e4462604744d66bf4301557d996d80b85eb
> --
> 2.25.1

Re: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

[wangjianjian (C)]

I submitted a similar patch fixed this and it should have already been 
in Ted's tree ?

Re: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

[Matthew G McGovern]

However the fix gets into main is fine with me, it is not in the working tree or linux-next currently. Can someone commit to getting one of these patches in? This is my first submission so I'm not sure who needs to apply and submit exactly.

-mm


On Fri, Apr 15, 2022 at 6:07 PM, wangjianjian (C) <wangjianjian3@huawei.com> wrote:

> I submitted a similar patch fixed this and it should have already been
> in Ted's tree ?