[PATCH] build-sys: add blkpr to gitignore

[PATCH] build-sys: add blkpr to gitignore

[Enze Li]

Since this commit 627428a95692 ("blkpr: add block persistent
reservations command"), we introduced blkpr, but the compiled generated
binary file is not added to the gitignore, so let's do it.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 3274563ec..0effa8945 100644
--- a/.gitignore
+++ b/.gitignore
@@ -73,6 +73,7 @@ GSYMS
 /addpart
 /agetty
 /blkdiscard
+/blkpr
 /blkzone
 /blkid
 /blockdev
-- 
2.35.1

Re: [PATCH] build-sys: add blkpr to gitignore

[zhenwei pi]

On 4/15/22 11:31, Enze Li wrote:
> Since this commit 627428a95692 ("blkpr: add block persistent
> reservations command"), we introduced blkpr, but the compiled generated
> binary file is not added to the gitignore, so let's do it.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
>   .gitignore | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 3274563ec..0effa8945 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -73,6 +73,7 @@ GSYMS
>   /addpart
>   /agetty
>   /blkdiscard
> +/blkpr
>   /blkzone
>   /blkid
>   /blockdev
Hi, Enze

Could you please reorder blkXX together to make them all in order?

-- 
zhenwei pi

Re: [PATCH] build-sys: add blkpr to gitignore

[Enze Li]

On Fri, 15 Apr 2022 11:31:31 +0800
zhenwei pi <pizhenwei@bytedance.com> wrote:

> On 4/15/22 11:31, Enze Li wrote:
> > Since this commit 627428a95692 ("blkpr: add block persistent
> > reservations command"), we introduced blkpr, but the compiled
> > generated binary file is not added to the gitignore, so let's do it.
> > 
> > Signed-off-by: Enze Li <lienze@kylinos.cn>
> > ---
> >   .gitignore | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 3274563ec..0effa8945 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -73,6 +73,7 @@ GSYMS
> >   /addpart
> >   /agetty
> >   /blkdiscard
> > +/blkpr
> >   /blkzone
> >   /blkid
> >   /blockdev  

Hi zhenwei,

Thanks for your review.

> 
> Could you please reorder blkXX together to make them all in order?
> 

Indeed, if this is necessary.  I've sent v2 to util-liux@list.

Thanks,
Enze

[PATCH v2] build-sys: add blkpr to gitignore

[Enze Li]

Since this commit 627428a95692 ("blkpr: add block persistent
reservations command"), we introduced blkpr, but the compiled generated
binary file is not added to the gitignore, so let's do it.

v2:
- Reorder blkxxx in alphabetical order.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
 .gitignore | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index 3274563ec..05ec48c9b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -73,8 +73,9 @@ GSYMS
 /addpart
 /agetty
 /blkdiscard
-/blkzone
 /blkid
+/blkpr
+/blkzone
 /blockdev
 /cal
 /cfdisk
-- 
2.25.1

Re: [PATCH v2] build-sys: add blkpr to gitignore

[Karel Zak]

On Fri, Apr 15, 2022 at 01:55:10PM +0800, Enze Li wrote:
>  .gitignore | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Good catch. Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com