All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: <rafael@kernel.org>, <viresh.kumar@linaro.org>,
	<robh+dt@kernel.org>, <krzk+dt@kernel.org>,
	<matthias.bgg@gmail.com>
Cc: <jia-wei.chang@mediatek.com>, <roger.lu@mediatek.com>,
	<hsinyi@google.com>, <khilman@baylibre.com>,
	<angelogioacchino.delregno@collabora.com>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Rex-BC Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH V3 08/15] cpufreq: mediatek: Make sram regulator optional
Date: Fri, 15 Apr 2022 13:59:09 +0800	[thread overview]
Message-ID: <20220415055916.28350-9-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220415055916.28350-1-rex-bc.chen@mediatek.com>

From: Jia-Wei Chang <jia-wei.chang@mediatek.com>

For some MediaTek SoCs, like MT8186, it's possible that the sram regulator
is shared between CPU and CCI.
We hope regulator framework can return NULL for error handling rather
than a dummy handler from regulator_get api.
Therefore, we choose to use regulator_get_optional.

Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/cpufreq/mediatek-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index 4d46e823c24e..559f4a383d30 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -436,7 +436,7 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
 	}
 
 	/* Both presence and absence of sram regulator are valid cases. */
-	info->sram_reg = regulator_get_exclusive(cpu_dev, "sram");
+	info->sram_reg = regulator_get_optional(cpu_dev, "sram");
 	if (IS_ERR(info->sram_reg))
 		info->sram_reg = NULL;
 	else {
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: <rafael@kernel.org>, <viresh.kumar@linaro.org>,
	<robh+dt@kernel.org>, <krzk+dt@kernel.org>,
	<matthias.bgg@gmail.com>
Cc: <jia-wei.chang@mediatek.com>, <roger.lu@mediatek.com>,
	<hsinyi@google.com>, <khilman@baylibre.com>,
	<angelogioacchino.delregno@collabora.com>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	 <Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Rex-BC Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH V3 08/15] cpufreq: mediatek: Make sram regulator optional
Date: Fri, 15 Apr 2022 13:59:09 +0800	[thread overview]
Message-ID: <20220415055916.28350-9-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220415055916.28350-1-rex-bc.chen@mediatek.com>

From: Jia-Wei Chang <jia-wei.chang@mediatek.com>

For some MediaTek SoCs, like MT8186, it's possible that the sram regulator
is shared between CPU and CCI.
We hope regulator framework can return NULL for error handling rather
than a dummy handler from regulator_get api.
Therefore, we choose to use regulator_get_optional.

Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/cpufreq/mediatek-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index 4d46e823c24e..559f4a383d30 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -436,7 +436,7 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
 	}
 
 	/* Both presence and absence of sram regulator are valid cases. */
-	info->sram_reg = regulator_get_exclusive(cpu_dev, "sram");
+	info->sram_reg = regulator_get_optional(cpu_dev, "sram");
 	if (IS_ERR(info->sram_reg))
 		info->sram_reg = NULL;
 	else {
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: <rafael@kernel.org>, <viresh.kumar@linaro.org>,
	<robh+dt@kernel.org>, <krzk+dt@kernel.org>,
	<matthias.bgg@gmail.com>
Cc: <jia-wei.chang@mediatek.com>, <roger.lu@mediatek.com>,
	<hsinyi@google.com>, <khilman@baylibre.com>,
	<angelogioacchino.delregno@collabora.com>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	 <Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Rex-BC Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH V3 08/15] cpufreq: mediatek: Make sram regulator optional
Date: Fri, 15 Apr 2022 13:59:09 +0800	[thread overview]
Message-ID: <20220415055916.28350-9-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220415055916.28350-1-rex-bc.chen@mediatek.com>

From: Jia-Wei Chang <jia-wei.chang@mediatek.com>

For some MediaTek SoCs, like MT8186, it's possible that the sram regulator
is shared between CPU and CCI.
We hope regulator framework can return NULL for error handling rather
than a dummy handler from regulator_get api.
Therefore, we choose to use regulator_get_optional.

Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/cpufreq/mediatek-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
index 4d46e823c24e..559f4a383d30 100644
--- a/drivers/cpufreq/mediatek-cpufreq.c
+++ b/drivers/cpufreq/mediatek-cpufreq.c
@@ -436,7 +436,7 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
 	}
 
 	/* Both presence and absence of sram regulator are valid cases. */
-	info->sram_reg = regulator_get_exclusive(cpu_dev, "sram");
+	info->sram_reg = regulator_get_optional(cpu_dev, "sram");
 	if (IS_ERR(info->sram_reg))
 		info->sram_reg = NULL;
 	else {
-- 
2.18.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  parent reply	other threads:[~2022-04-15  6:02 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  5:59 [PATCH V3 00/15] cpufreq: mediatek: Cleanup and support MT8183 and MT8186 Rex-BC Chen
2022-04-15  5:59 ` Rex-BC Chen
2022-04-15  5:59 ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 01/15] dt-bindings: cpufreq: mediatek: Add MediaTek CCI property Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 02/15] cpufreq: mediatek: Use device print to show logs Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:24   ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15  5:59 ` [PATCH V3 03/15] cpufreq: mediatek: Replace old_* with pre_* Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:24   ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15  5:59 ` [PATCH V3 04/15] cpufreq: mediatek: Record previous target vproc value Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:24   ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-18  1:37     ` Rex-BC Chen
2022-04-18  1:37       ` Rex-BC Chen
2022-04-18  1:37       ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 05/15] cpufreq: mediatek: Add opp notification support Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:24   ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-18  1:38     ` Rex-BC Chen
2022-04-18  1:38       ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 06/15] cpufreq: mediatek: Move voltage limits to platform data Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:24   ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15  5:59 ` [PATCH V3 07/15] cpufreq: mediatek: Add .get function Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59 ` Rex-BC Chen [this message]
2022-04-15  5:59   ` [PATCH V3 08/15] cpufreq: mediatek: Make sram regulator optional Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 09/15] cpufreq: mediatek: Refine mtk_cpufreq_voltage_tracking() Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 10/15] cpufreq: mediatek: Add counter to prevent infinite loop when tracking voltage Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  6:14   ` Hsin-Yi Wang
2022-04-15  6:14     ` Hsin-Yi Wang
2022-04-15  6:14     ` Hsin-Yi Wang
2022-04-15  6:29     ` Rex-BC Chen
2022-04-15  6:29       ` Rex-BC Chen
2022-04-15  6:29       ` Rex-BC Chen
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24       ` AngeloGioacchino Del Regno
2022-04-15 12:24       ` AngeloGioacchino Del Regno
2022-04-18  1:40       ` Rex-BC Chen
2022-04-18  1:40         ` Rex-BC Chen
2022-04-18  1:40         ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 11/15] cpufreq: mediatek: Link CCI device to CPU Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:24   ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-18  1:45     ` Rex-BC Chen
2022-04-18  1:45       ` Rex-BC Chen
2022-04-18  1:45       ` Rex-BC Chen
2022-04-20 18:09   ` Kevin Hilman
2022-04-20 18:09     ` Kevin Hilman
2022-04-20 18:09     ` Kevin Hilman
2022-04-15  5:59 ` [PATCH V3 12/15] cpufreq: mediatek: Add support for MT8186 Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 13/15] arm64: dts: mediatek: Add opp table and clock property for MT8183 cpufreq Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:24   ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-15 12:24     ` AngeloGioacchino Del Regno
2022-04-18  1:46     ` Rex-BC Chen
2022-04-18  1:46       ` Rex-BC Chen
2022-04-18  1:46       ` Rex-BC Chen
2022-04-15  5:59 ` [PATCH V3 14/15] arm64: dts: mediatek: Add MediaTek CCI node for MT8183 Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15  6:06   ` Hsin-Yi Wang
2022-04-15  6:06     ` Hsin-Yi Wang
2022-04-15  6:06     ` Hsin-Yi Wang
2022-04-15  6:10     ` Hsin-Yi Wang
2022-04-15  6:10       ` Hsin-Yi Wang
2022-04-15  6:10       ` Hsin-Yi Wang
2022-04-15 12:23   ` AngeloGioacchino Del Regno
2022-04-15 12:23     ` AngeloGioacchino Del Regno
2022-04-15 12:23     ` AngeloGioacchino Del Regno
2022-04-15  5:59 ` [PATCH V3 15/15] arm64: dts: mediatek: Add mediatek,cci property for MT8183 cpufreq Rex-BC Chen
2022-04-15  5:59   ` [PATCH V3 15/15] arm64: dts: mediatek: Add mediatek, cci " Rex-BC Chen
2022-04-15  5:59   ` Rex-BC Chen
2022-04-15 12:23   ` [PATCH V3 15/15] arm64: dts: mediatek: Add mediatek,cci " AngeloGioacchino Del Regno
2022-04-15 12:23     ` [PATCH V3 15/15] arm64: dts: mediatek: Add mediatek, cci " AngeloGioacchino Del Regno
2022-04-15 12:23     ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220415055916.28350-9-rex-bc.chen@mediatek.com \
    --to=rex-bc.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hsinyi@google.com \
    --cc=jia-wei.chang@mediatek.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=roger.lu@mediatek.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.